Re: [PATCH rdma-next 11/14] RDMA: Add support to dump resource tracker in RAW format

[Leon Romanovsky <leon@kernel.org>]

On Mon, May 25, 2020 at 11:41:36AM -0300, Jason Gunthorpe wrote:
> On Wed, May 13, 2020 at 12:50:31PM +0300, Leon Romanovsky wrote:
> > From: Maor Gottlieb <maorg@mellanox.com>
> >
> > Add support to get resource dump in raw format. It enable vendors
> > to return the entire QP/CQ/MR context without a need from the vendor
> > to set each field separately.
> > When user request to get the data in RAW, we return as key value
> > the generic fields which not require to query the vendor and in addition
> > we return the rest of the data as binary.
> >
> > Example:
> >
> > $rdma res show mr dev mlx5_1 mrn 2 -r -j
> > [{"ifindex":7,"ifname":"mlx5_1","mrn":2,"mrlen":4096,"pdn":5,
> > pid":24336, "comm":"ibv_rc_pingpong",
> > "data":[0,4,255,254,0,0,0,0,0,0,0,0,16,28,0,216,...]}]
>
> That is pretty gross, why not bas64 encode it or something?

We are talking about rdmatool output, right? It can.

>
> >  static int fill_res_mr_entry(struct sk_buff *msg, bool has_cap_net_admin,
> > -			     struct rdma_restrack_entry *res, uint32_t port)
> > +			     struct rdma_restrack_entry *res, uint32_t port,
> > +			     bool raw)
> >  {
>
> Should it be a flag not a bool?

I assume that once this RAW series will be merged, the MR res dump will
be close to feature complete.

Thank

>
> Jason