From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH] mptcp: attempt skb coalescing when moving skbs to mptcp rx queue
Date: Mon, 25 May 2020 20:10:29 +0200 [thread overview]
Message-ID: <20200525181029.GE2915@breakpoint.cc> (raw)
In-Reply-To: f4836de8b7756bd749878450935bc296c193f931.camel@redhat.com
[-- Attachment #1: Type: text/plain, Size: 831 bytes --]
Paolo Abeni <pabeni(a)redhat.com> wrote:
> On Mon, 2020-05-25 at 18:02 +0200, Florian Westphal wrote:
> > We can try to coalesce the skbs we take from the subflows rx queue
> > with the tail of the mptcp rx queue.
> >
> > If successful, the skb head can be discarded early.
> >
> > We can also free the skb extensions, we do not access them after
> > this so no need to hold on to them.
> >
> > Only caveat: do not built too fat skbs. They are only free'd once
> > userspace has read all data.
>
> To share IRC thoughts here:
>
> It looks like TCP allows skb to grow above GSO_MAX_SIZE and frees them
> only when user-space read all the data. Could we relax this constraint,
> too?
Yes, but I saw skbs of up ~320kb Truesize, which i considered too
much. I will remove the comment and the contraint in v2.
next reply other threads:[~2020-05-25 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 18:10 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-25 17:08 [MPTCP] Re: [PATCH] mptcp: attempt skb coalescing when moving skbs to mptcp rx queue Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525181029.GE2915@breakpoint.cc \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.