From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E684C433DF for ; Mon, 25 May 2020 20:52:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD3742071A for ; Mon, 25 May 2020 20:52:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590439923; bh=Uolwe84asMVFPUHLyWBSC47R3hMCsLozNi0QPlpqycA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=h0g9zg2KJVCNttoBQZSvPmIMa3GAF3JYHcD/UU21Xp7uJg3Me0Xh5ohDqsNPYvz9A tRZ1klABShnMET7x7qxhGV3ZEOGz+Gc1b/bsTnLNlnBaHdIjVEOGzVx4Sg35RAHDPO PI3JGLVIa4p2zEKiBBBlTNUk/JIBlyA/qYltToPY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390679AbgEYUwD (ORCPT ); Mon, 25 May 2020 16:52:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:40806 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388714AbgEYUwD (ORCPT ); Mon, 25 May 2020 16:52:03 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7CF90206D5; Mon, 25 May 2020 20:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590439922; bh=Uolwe84asMVFPUHLyWBSC47R3hMCsLozNi0QPlpqycA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U2jDMszNG3pXPzq4jon8JEVDZFDPTArcQJsbs5a8L7h//KbSJx89zkb+457kX3oDZ r9XP/Gljwe+G0JXqDIqv2qsRjlClBQFjoypg4ggMIDfsYatHHoMJvfmv+JuZBB10Nm zb7pNOPLHxKytXqFfTD5naona0PCnx7crW7rUgTQ= Date: Mon, 25 May 2020 16:52:01 -0400 From: Sasha Levin To: gregkh@linuxfoundation.org Cc: fabrice.gasnier@st.com, Jonathan.Cameron@huawei.com, Stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] iio: adc: stm32-adc: fix device used to request dma" failed to apply to 5.4-stable tree Message-ID: <20200525205201.GZ33628@sasha-vm> References: <15904148129183@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <15904148129183@kroah.com> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, May 25, 2020 at 03:53:32PM +0200, gregkh@linuxfoundation.org wrote: > >The patch below does not apply to the 5.4-stable tree. >If someone wants it applied there, or to any other stable or longterm >tree, then please email the backport, including the original git commit >id to . > >thanks, > >greg k-h > >------------------ original commit in Linus's tree ------------------ > >>From 52cd91c27f3908b88e8b25aed4a4d20660abcc45 Mon Sep 17 00:00:00 2001 >From: Fabrice Gasnier >Date: Thu, 30 Apr 2020 11:28:45 +0200 >Subject: [PATCH] iio: adc: stm32-adc: fix device used to request dma > >DMA channel request should use device struct from platform device struct. >Currently it's using iio device struct. But at this stage when probing, >device struct isn't yet registered (e.g. device_register is done in >iio_device_register). Since commit 71723a96b8b1 ("dmaengine: Create >symlinks between DMA channels and slaves"), a warning message is printed >as the links in sysfs can't be created, due to device isn't yet registered: >- Cannot create DMA slave symlink >- Cannot create DMA dma:rx symlink > >Fix this by using device struct from platform device to request dma chan. > >Fixes: 2763ea0585c99 ("iio: adc: stm32: add optional dma support") > >Signed-off-by: Fabrice Gasnier >Cc: >Signed-off-by: Jonathan Cameron I've also grabbed 735404b846df ("iio: adc: stm32-adc: Use dma_request_chan() instead dma_request_slave_channel()") and queued both for 5.4, 4.19, and 4.14. -- Thanks, Sasha