From: Pavel Machek <pavel@ucw.cz>
To: Flavio Suligoi <f.suligoi@asem.it>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: fix macro names for pca955x
Date: Tue, 26 May 2020 11:22:50 +0200 [thread overview]
Message-ID: <20200526092250.GB12838@amd> (raw)
In-Reply-To: <20200526092052.24172-1-f.suligoi@asem.it>
[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]
On Tue 2020-05-26 11:20:52, Flavio Suligoi wrote:
> The documentation reports the wrong macro names
> related to the pca9532 instead of the pca955x
>
> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
Nothing obviously wrong, but why did you send it twice within half an
hour?
Pavel
> Documentation/devicetree/bindings/leds/leds-pca955x.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-pca955x.txt b/Documentation/devicetree/bindings/leds/leds-pca955x.txt
> index 7984efb767b4..7a5830f8d5ab 100644
> --- a/Documentation/devicetree/bindings/leds/leds-pca955x.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-pca955x.txt
> @@ -26,9 +26,9 @@ LED sub-node properties:
> from 0 to 15 for the pca9552
> from 0 to 3 for the pca9553
> - type: (optional) either
> - PCA9532_TYPE_NONE
> - PCA9532_TYPE_LED
> - PCA9532_TYPE_GPIO
> + PCA955X_TYPE_NONE
> + PCA955X_TYPE_LED
> + PCA955X_TYPE_GPIO
> see dt-bindings/leds/leds-pca955x.h (default to LED)
> - label : (optional)
> see Documentation/devicetree/bindings/leds/common.txt
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-05-26 9:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 9:20 [PATCH] dt-bindings: leds: fix macro names for pca955x Flavio Suligoi
2020-05-26 9:22 ` Pavel Machek [this message]
2020-05-26 9:25 ` Flavio Suligoi
2020-05-26 9:28 ` Pavel Machek
2020-05-26 9:31 ` Flavio Suligoi
2020-05-29 17:27 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2020-05-26 8:37 Flavio Suligoi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526092250.GB12838@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=f.suligoi@asem.it \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.