From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Jeremy Linton <jeremy.linton@arm.com>,
netdev@vger.kernel.org
Subject: [PATCH RFC 0/7] Clause 45 PHY probing cleanups
Date: Tue, 26 May 2020 15:29:48 +0100 [thread overview]
Message-ID: <20200526142948.GY1551@shell.armlinux.org.uk> (raw)
Hi,
In response to the patch set that Jeremy posted, this is my proposal
to expand our Clause 45 PHY probing.
I've taken a slightly different approach, with the view to avoiding
as much behavioural change as possible. The biggest difference is
to do with "devices_in_package" - we were using it for two different
purposes, which are now separated.
This is not against net-next nor net trees, but against my own private
tree, but I'm posting it to serve as an illustration of what I think
should be done - I knocked this up this morning.
The only potential regression that I'm expecting is with 88x3310 PHYs
of the later revision, which have the clause 22 registers implemented.
I haven't yet checked whether they set bit 0, but if they do, the
various decision points that we have based on that bit could adversely
affect this PHY - it needs testing, which I'll do when I dig out the
appropriate hardware. Probably also needs the 2110 PHYs checked as
well.
I haven't tested this series yet beyond compile testing.
Given the proximity of the merge window, this *isn't* code I'd like to
see merged into net-next - it's way too risky at this point. So, we
have time to consider our options.
drivers/net/phy/bcm87xx.c | 2 +-
drivers/net/phy/cortina.c | 3 +-
drivers/net/phy/phy-c45.c | 4 +-
drivers/net/phy/phy-core.c | 11 ++--
drivers/net/phy/phy.c | 4 +-
drivers/net/phy/phy_device.c | 141 +++++++++++++++++++++++++++----------------
drivers/net/phy/phylink.c | 19 +++---
include/linux/mdio.h | 31 ++++++++++
include/linux/phy.h | 14 ++---
9 files changed, 146 insertions(+), 83 deletions(-)
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up
next reply other threads:[~2020-05-26 14:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 14:29 Russell King - ARM Linux admin [this message]
2020-05-26 14:31 ` [PATCH RFC 1/7] net: mdiobus: add clause 45 mdiobus accessors Russell King
2020-05-26 14:39 ` Andrew Lunn
2020-05-26 15:21 ` Russell King - ARM Linux admin
2020-05-26 14:31 ` [PATCH RFC 2/7] net: phy: clean up cortina workaround Russell King
2020-05-26 14:31 ` [PATCH RFC 3/7] net: phy: clean up PHY ID reading Russell King
2020-05-26 15:38 ` Jeremy Linton
2020-05-26 15:46 ` Russell King - ARM Linux admin
2020-05-26 14:31 ` [PATCH RFC 4/7] net: phy: add support for probing MMDs >= 8 for devices-in-package Russell King
2020-05-26 17:14 ` Russell King - ARM Linux admin
2020-05-26 17:20 ` Jeremy Linton
2020-05-26 17:53 ` Russell King - ARM Linux admin
2020-05-26 14:31 ` [PATCH RFC 5/7] net: phy: set devices_in_package only after validation Russell King
2020-05-26 15:39 ` Jeremy Linton
2020-05-26 15:50 ` Russell King - ARM Linux admin
2020-05-26 16:33 ` Russell King - ARM Linux admin
2020-05-26 14:31 ` [PATCH RFC 6/7] net: phy: split devices_in_package Russell King
2020-05-26 15:39 ` Jeremy Linton
2020-05-26 15:47 ` Russell King - ARM Linux admin
2020-05-26 16:00 ` Russell King - ARM Linux admin
2020-05-26 14:31 ` [PATCH RFC 7/7] net: phy: read MMD ID from all present MMDs Russell King
2020-05-26 15:35 ` Jeremy Linton
2020-05-26 15:46 ` Russell King - ARM Linux admin
2020-05-26 15:43 ` [PATCH RFC 0/7] Clause 45 PHY probing cleanups Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526142948.GY1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jeremy.linton@arm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.