From: Luis Chamberlain <mcgrof@kernel.org>
To: jeyu@kernel.org, davem@davemloft.net, kuba@kernel.org
Cc: michael.chan@broadcom.com, dchickles@marvell.com,
sburla@marvell.com, fmanlunas@marvell.com, aelior@marvell.com,
GR-everest-linux-l2@marvell.com, kvalo@codeaurora.org,
johannes@sipsolutions.net, akpm@linux-foundation.org,
arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com,
aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com,
peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com,
pmladek@suse.com, tiwai@suse.de, schlad@suse.de,
andriy.shevchenko@linux.intel.com, derosier@gmail.com,
keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org,
mchehab+samsung@kernel.org, vkoul@kernel.org,
mchehab+huawei@kernel.org, robh@kernel.org, mhiramat@kernel.org,
sfr@canb.auug.org.au, linux@dominikbrodowski.net,
glider@google.com, paulmck@kernel.org, elver@google.com,
bauerman@linux.ibm.com, yamada.masahiro@socionext.com,
samitolvanen@google.com, yzaikin@google.com, dvyukov@google.com,
rdunlap@infradead.org, corbet@lwn.net, dianders@chromium.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH v3 7/8] liquidio: use new taint_firmware_crashed()
Date: Tue, 26 May 2020 14:58:14 +0000 [thread overview]
Message-ID: <20200526145815.6415-8-mcgrof@kernel.org> (raw)
In-Reply-To: <20200526145815.6415-1-mcgrof@kernel.org>
This makes use of the new taint_firmware_crashed() to help
annotate when firmware for device drivers crash. When firmware
crashes devices can sometimes become unresponsive, and recovery
sometimes requires a driver unload / reload and in the worst cases
a reboot.
Using a taint flag allows us to annotate when this happens clearly.
Cc: Derek Chickles <dchickles@marvell.com>
Cc: Satanand Burla <sburla@marvell.com>
Cc: Felix Manlunas <fmanlunas@marvell.com>
Acked-by: Rafael Aquini <aquini@redhat.com>
Reviewed-by: Derek Chickles <dchickles@marvell.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
drivers/net/ethernet/cavium/liquidio/lio_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c
index 66d31c018c7e..ee1796ea4818 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
@@ -801,6 +801,7 @@ static int liquidio_watchdog(void *param)
continue;
WRITE_ONCE(oct->cores_crashed, true);
+ taint_firmware_crashed();
other_oct = get_other_octeon_device(oct);
if (other_oct)
WRITE_ONCE(other_oct->cores_crashed, true);
--
2.26.2
next prev parent reply other threads:[~2020-05-26 14:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 14:58 [PATCH v3 0/8] kernel: taint when the driver firmware crashes Luis Chamberlain
2020-05-26 14:58 ` [PATCH v3 1/8] kernel.h: move taint and system state flags to uapi Luis Chamberlain
2020-05-26 14:58 ` [PATCH v3 2/8] panic: add uevent support Luis Chamberlain
2020-05-31 4:46 ` kbuild test robot
2020-06-03 17:55 ` kernel test robot
2020-05-26 14:58 ` [PATCH v3 3/8] taint: add firmware crash taint support Luis Chamberlain
2020-05-26 14:58 ` [PATCH v3 4/8] panic: make taint data type clearer Luis Chamberlain
2020-05-26 14:58 ` [PATCH v3 5/8] ath10k: use new taint_firmware_crashed() Luis Chamberlain
2020-05-26 14:58 ` Luis Chamberlain
2020-06-02 21:01 ` Brian Norris
2020-06-02 21:01 ` Brian Norris
2020-05-26 14:58 ` [PATCH v3 6/8] bnxt_en: " Luis Chamberlain
2020-05-26 18:09 ` Michael Chan
2020-05-26 14:58 ` Luis Chamberlain [this message]
2020-05-26 14:58 ` [PATCH v3 8/8] qed: " Luis Chamberlain
2020-05-26 22:46 ` [PATCH v3 0/8] kernel: taint when the driver firmware crashes Jakub Kicinski
2020-05-26 23:07 ` Luis Chamberlain
2020-05-26 23:30 ` Jakub Kicinski
2020-05-27 3:19 ` Luis Chamberlain
2020-05-27 21:36 ` Jakub Kicinski
2020-05-28 14:27 ` Luis Chamberlain
2020-05-28 15:04 ` Ben Greear
2020-05-28 16:33 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526145815.6415-8-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aquini@redhat.com \
--cc=arnd@arndb.de \
--cc=bauerman@linux.ibm.com \
--cc=bhe@redhat.com \
--cc=cai@lca.pw \
--cc=corbet@lwn.net \
--cc=daniel.vetter@ffwll.ch \
--cc=davem@davemloft.net \
--cc=dchickles@marvell.com \
--cc=derosier@gmail.com \
--cc=dianders@chromium.org \
--cc=dvyukov@google.com \
--cc=dyoung@redhat.com \
--cc=elver@google.com \
--cc=fmanlunas@marvell.com \
--cc=glider@google.com \
--cc=gpiccoli@canonical.com \
--cc=jeyu@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mhiramat@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=sburla@marvell.com \
--cc=schlad@suse.de \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
--cc=yamada.masahiro@socionext.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.