From: Igor Mammedov <imammedo@redhat.com>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com
Subject: Re: [PATCH v2 1/2] qapi: Fix comment format for @CpuInstanceProperties
Date: Tue, 26 May 2020 15:11:44 +0200 [thread overview]
Message-ID: <20200526151144.1ca61c42@redhat.com> (raw)
In-Reply-To: <e7a678664d5f384f8d4cae72755c9a887643b0c0.1590481402.git.mprivozn@redhat.com>
On Tue, 26 May 2020 10:25:34 +0200
Michal Privoznik <mprivozn@redhat.com> wrote:
> In 176d2cda0de, the @die-id attribute was introduced to
> CpuInstanceProperties type. However, it mangled the comment.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> qapi/machine.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/machine.json b/qapi/machine.json
> index ff7b5032e3..39caa1d914 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -824,7 +824,8 @@
> # @node-id: NUMA node ID the CPU belongs to
> # @socket-id: socket number within node/board the CPU belongs to
> # @die-id: die number within node/board the CPU belongs to (Since 4.1)
> -# @core-id: core number within die the CPU belongs to# @thread-id: thread number within core the CPU belongs to
> +# @core-id: core number within die the CPU belongs to
> +# @thread-id: thread number within core the CPU belongs to
> #
> # Note: currently there are 5 properties that could be present
> # but management should be prepared to pass through other
next prev parent reply other threads:[~2020-05-26 13:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 8:25 [PATCH v2 0/2] qmp: Expose MachineClass::default_ram_id Michal Privoznik
2020-05-26 8:25 ` [PATCH v2 1/2] qapi: Fix comment format for @CpuInstanceProperties Michal Privoznik
2020-05-26 13:11 ` Igor Mammedov [this message]
2020-05-26 8:25 ` [PATCH v2 2/2] qmp: Expose MachineClass::default_ram_id Michal Privoznik
2020-05-26 13:15 ` Igor Mammedov
2020-05-26 13:17 ` Igor Mammedov
2020-07-27 18:41 ` [PATCH v2 0/2] " Eduardo Habkost
2020-07-28 8:05 ` Michal Privoznik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526151144.1ca61c42@redhat.com \
--to=imammedo@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.