From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
broonie@kernel.org, robh+dt@kernel.org,
linux-spi@vger.kernel.org, Sergey.Semin@baikalelectronics.ru,
fancer.lancer@gmail.com, lars.povlsen@microchip.com,
Liang Jin J <liang.j.jin@ericsson.com>
Subject: Re: [PATCHv2 1/2] spi: dw: add reset control
Date: Tue, 26 May 2020 18:21:29 +0300 [thread overview]
Message-ID: <20200526152129.GS1634618@smile.fi.intel.com> (raw)
In-Reply-To: <20200526151218.6186-1-dinguyen@kernel.org>
On Tue, May 26, 2020 at 10:12:17AM -0500, Dinh Nguyen wrote:
> Add mechanism to get the reset control and deassert it in order to bring
> the IP out of reset.
...
> struct clk *clk;
> struct clk *pclk;
> void *priv;
> + struct reset_control *rstc;
I think either you make it one space or you align all the rest members
accordingly. I would rather go with former.
...
> + /* find an optional reset controller */
> + dwsmmio->rstc = devm_reset_control_get_optional_exclusive(&pdev->dev, "spi");
> + if (IS_ERR(dwsmmio->rstc)) {
> + if (PTR_ERR(dwsmmio->rstc) == -EPROBE_DEFER)
> + return PTR_ERR(dwsmmio->rstc);
If it's other type of errors when reset control, we ignore them...
Why?!
> + }
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-05-26 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 15:12 [PATCHv2 1/2] spi: dw: add reset control Dinh Nguyen
2020-05-26 15:12 ` [PATCHv2 2/2] dt-bindings: snps,dw-apb-ssi: add optional reset property Dinh Nguyen
2020-05-26 15:21 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526152129.GS1634618@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=lars.povlsen@microchip.com \
--cc=liang.j.jin@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.