All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Heinz Mauelshagen <heinzm@redhat.com>, dm-devel@redhat.com
Subject: Re: delete dm_bufio_discard_buffers
Date: Wed, 27 May 2020 09:11:07 -0400	[thread overview]
Message-ID: <20200527131107.GA19310@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.02.2005270702460.6054@file01.intranet.prod.int.rdu2.redhat.com>

On Wed, May 27 2020 at  7:04am -0400,
Mikulas Patocka <mpatocka@redhat.com> wrote:

> Hi
> 
> I suggest to delete dm_bufio_discard_buffers because no one is using it.
> 
> If you need it in the future, tell me - and I will optimize it, so that it 
> walks the rb-tree of buffers instead of doing block-by-block lookups.
> 

OK, my only concern is: Heinz, should you have used
dm_bufio_discard_buffers() in dm-ebs commit a5089a95d84c ("dm ebs: pass
discards down to underlying device")?  Or are you certain all ebs'
bufio buffers have made it to disk?

Also now seeing that the FIXME commit a5089a95d84c removed referred to
making use of dm_bufio_discard_buffers()...

Mike

      reply	other threads:[~2020-05-27 13:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 11:04 [PATCH] delete dm_bufio_discard_buffers Mikulas Patocka
2020-05-27 13:11 ` Mike Snitzer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200527131107.GA19310@redhat.com \
    --to=snitzer@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=heinzm@redhat.com \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.