Re: [PATCH 3/5] netfilter: nf_conntrack_pptp: prevent buffer overflows in debug code

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2856 bytes --]

Hi Pablo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on nf-next/master]
[also build test WARNING on net-next/master v5.7-rc7]
[cannot apply to nf/master net/master next-20200526]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/Netfilter-fixes-for-net/20200526-055708
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: alpha-randconfig-r024-20200527 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

In file included from include/net/netfilter/nf_nat.h:7,
from include/net/tc_act/tc_ct.h:9,
from net/sched/cls_api.c:40:
>> include/linux/netfilter/nf_conntrack_pptp.h:13:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
13 | extern const char *const pptp_msg_name(u_int16_t msg);
|        ^~~~~
--
In file included from net/netfilter/nf_conntrack_pptp.c:36:
>> include/linux/netfilter/nf_conntrack_pptp.h:13:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
13 | extern const char *const pptp_msg_name(u_int16_t msg);
|        ^~~~~
>> net/netfilter/nf_conntrack_pptp.c:94:1: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
94 | const char *const pptp_msg_name(u_int16_t msg)
| ^~~~~
--
In file included from include/net/netfilter/nf_nat.h:7,
from net/ipv4/netfilter/nf_nat_snmp_basic_main.c:43:
>> include/linux/netfilter/nf_conntrack_pptp.h:13:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
13 | extern const char *const pptp_msg_name(u_int16_t msg);
|        ^~~~~
net/ipv4/netfilter/nf_nat_snmp_basic_main.c:47:10: fatal error: nf_nat_snmp_basic.asn1.h: No such file or directory
47 | #include "nf_nat_snmp_basic.asn1.h"
|          ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

vim +13 include/linux/netfilter/nf_conntrack_pptp.h

    12	
  > 13	extern const char *const pptp_msg_name(u_int16_t msg);
    14	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33108 bytes --]