All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [git pull] coredump infoleak fix
Date: Thu, 28 May 2020 09:44:42 +0200	[thread overview]
Message-ID: <20200528074442.GB790247@gmail.com> (raw)
In-Reply-To: <20200528070552.GJ23230@ZenIV.linux.org.uk>


* Al Viro <viro@zeniv.linux.org.uk> wrote:

> On Thu, May 28, 2020 at 09:02:55AM +0200, Ingo Molnar wrote:
> 
> > Looks good to me.
> > 
> > I'm wondering, shouldn't we also zero-initialize the dump data to 
> > begin with? See the patch below (untested).
> 
> Note that this hides the bug from KASAN, though ;-)  And the bug
> is not just infoleak - not all components are "all zeroes" in the
> init state.

Yeah, but is zero-init really a problem though? Wouldn't it be 
'better' to have all zeroes if the dump doesn't fit? But I might be 
missing something ...

Thanks,

	Ingo

  reply	other threads:[~2020-05-28  7:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 21:34 [git pull] coredump infoleak fix Al Viro
2020-05-28  7:02 ` Ingo Molnar
2020-05-28  7:05   ` Al Viro
2020-05-28  7:44     ` Ingo Molnar [this message]
2020-05-28 12:50       ` Al Viro
2020-05-29  9:35         ` Ingo Molnar
2020-05-28  7:29   ` [PATCH] fs/coredump/elf: Clean up fill_thread_core_info() Ingo Molnar
2020-05-28  7:40     ` [PATCH v2] " Ingo Molnar
2020-05-28 18:34   ` [git pull] coredump infoleak fix Linus Torvalds
2020-05-28 19:05     ` Al Viro
2020-05-28 19:09       ` Linus Torvalds
2020-05-28 19:17         ` Al Viro
2020-05-28 19:19           ` Linus Torvalds
2020-05-28 19:28             ` Al Viro
2020-05-29  9:39       ` Ingo Molnar
2020-05-31 18:05 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200528074442.GB790247@gmail.com \
    --to=mingo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.