From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74ED7C433E0 for ; Thu, 28 May 2020 13:51:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 557872084C for ; Thu, 28 May 2020 13:51:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390539AbgE1NvA (ORCPT ); Thu, 28 May 2020 09:51:00 -0400 Received: from muru.com ([72.249.23.125]:56018 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390530AbgE1NvA (ORCPT ); Thu, 28 May 2020 09:51:00 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 6F64D80BF; Thu, 28 May 2020 13:51:50 +0000 (UTC) Date: Thu, 28 May 2020 06:50:57 -0700 From: Tony Lindgren To: Arnd Bergmann Cc: arm@kernel.org, Rob Herring , Grygorii Strashko , Geert Uytterhoeven , Lokesh Vutla , Keerthy , Santosh Shilimkar , linux-kernel@vger.kernel.org, Tero Kristo , Olof Johansson , linux-omap@vger.kernel.org, afzal mohammed , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: omap2: drop broken broadcast timer hack Message-ID: <20200528135057.GO37466@atomide.com> References: <20200528091923.2951100-1-arnd@arndb.de> <20200528134621.GN37466@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200528134621.GN37466@atomide.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Tony Lindgren [200528 13:47]: > * Arnd Bergmann [200528 09:20]: > > The OMAP4 timer code had a special hack for using the broadcast timer > > without SMP. Since the dmtimer is now gone, this also needs to be dropped > > to avoid a link failure for non-SMP AM43xx configurations: > > > > kernel/time/tick-broadcast.o: in function `tick_device_uses_broadcast': > > tick-broadcast.c:(.text+0x130): undefined reference to `tick_broadcast' > > Hmm this sounds like a regression though. Isn't this needed for using > the ARM local timers on non-SMP SoC, so a separate timer from dmtimer? > > I've probably removed something accidentally to cause this. Sounds like arch/arm/mach-omap2/Makefile change needs to be removed to always still build in timer.o. And probably timer.c needs back the ifdef for CONFIG_SOC_HAS_REALTIME_COUNTER. I'll take a look today. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24E40C433DF for ; Thu, 28 May 2020 13:51:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB86420897 for ; Thu, 28 May 2020 13:51:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KrwhKV4D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB86420897 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sjSVX0zoqc6Bi6/NXlBvKV5chtD5EItC+KonbX7ZkA8=; b=KrwhKV4Do0Gj2F Owlih7jxdZzwko2R5UEg+qPEKVo4ZFtmgTa5V/vWCmcH2QDjeo0cdlp0Y5rWCsyOMGpAHb6W9xF7E 8o/uvnywcqOTeekKWOsseAOWG7NBMtamBaP2uXMDmJC2ibGt4pUB2Ux/3B0H4wVZtbbfmhIgYXAFI mARH2BryiVSH1udUiR6xSn9xJ6irkmb5aNJlxtPtJNBYae7GyBZOPN+utMhT2wUFRs6Z3o44LmcPT IGLCDK9NysYJbwSzX2IWjfWB8X65PtQmyoQc//KRRVbtt6qKJ9I9iAA8Rd8oeN7avhSb0H4/m8tKf Qv7AHV6HmfDEurxnV5KQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeIw2-0002Qm-UJ; Thu, 28 May 2020 13:51:02 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeIw0-0002QT-7k for linux-arm-kernel@lists.infradead.org; Thu, 28 May 2020 13:51:01 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 6F64D80BF; Thu, 28 May 2020 13:51:50 +0000 (UTC) Date: Thu, 28 May 2020 06:50:57 -0700 From: Tony Lindgren To: Arnd Bergmann Subject: Re: [PATCH] ARM: omap2: drop broken broadcast timer hack Message-ID: <20200528135057.GO37466@atomide.com> References: <20200528091923.2951100-1-arnd@arndb.de> <20200528134621.GN37466@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200528134621.GN37466@atomide.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_065100_313816_3E462D15 X-CRM114-Status: GOOD ( 10.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Grygorii Strashko , Geert Uytterhoeven , Lokesh Vutla , Keerthy , Santosh Shilimkar , linux-kernel@vger.kernel.org, Tero Kristo , arm@kernel.org, Olof Johansson , linux-omap@vger.kernel.org, afzal mohammed , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Tony Lindgren [200528 13:47]: > * Arnd Bergmann [200528 09:20]: > > The OMAP4 timer code had a special hack for using the broadcast timer > > without SMP. Since the dmtimer is now gone, this also needs to be dropped > > to avoid a link failure for non-SMP AM43xx configurations: > > > > kernel/time/tick-broadcast.o: in function `tick_device_uses_broadcast': > > tick-broadcast.c:(.text+0x130): undefined reference to `tick_broadcast' > > Hmm this sounds like a regression though. Isn't this needed for using > the ARM local timers on non-SMP SoC, so a separate timer from dmtimer? > > I've probably removed something accidentally to cause this. Sounds like arch/arm/mach-omap2/Makefile change needs to be removed to always still build in timer.o. And probably timer.c needs back the ifdef for CONFIG_SOC_HAS_REALTIME_COUNTER. I'll take a look today. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel