From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0B49C433DF for ; Thu, 28 May 2020 14:18:58 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B1772075F for ; Thu, 28 May 2020 14:18:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="vrZzcgZ1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B1772075F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B980816B3; Thu, 28 May 2020 16:18:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B980816B3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1590675536; bh=zqc71Q27/B8/dUwRLhvm0S+/HIhHCNTNHUpNdVv+Lzc=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vrZzcgZ1SX35hdKFaGcWMra+DI7SA+1ESnAUA412dXcdmEAV61k27US+aktN+uvnz 3Cflr9ukNqATX+PsebcmlGbHC7Aaz+TCnPGRw7TFvU0sQwtzqmOAlV6kZQM4KkiNMQ JCz4HhUM5YC6ydymccrRuCAy/GOk4WBv9bsRidOY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2FA3BF8014A; Thu, 28 May 2020 16:18:06 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8C820F800E4; Thu, 28 May 2020 16:18:04 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5C6CFF800E4 for ; Thu, 28 May 2020 16:17:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5C6CFF800E4 Received: by mail-io1-f67.google.com with SMTP id d7so30161458ioq.5 for ; Thu, 28 May 2020 07:17:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BQyivfejSNXbCqlTdGdrhX0zYMkRgbdRvewpKbUjPCY=; b=YMEMv2sFE0PdU1KLCs6Um8f6z0potRN71K2fdAVrgH3MlFFcyvpXeSHROVIxBc6BzN urh0n+PZkyrKIJQ4a8b697n73TQuifKuxN5QvB5zvRWjlyRSkATTeqNIm992BW0lC6Lh Uxlp4gsxGEQhMx20QHzQdQVTH/E39eKJmmbjlLZFIDjxdpOsFrqGprEwDwGTXa4J6uZY 2LKVgUUrkMOwb8UJelRNS51KONbGU2kQW1qGGRjYx1sRCJu74Smv9qt2YwWQwqPK3OKw JPFAmL+SAok6KgARaUnxrSdsdkKHarNVZv92tGDZCx8j0GtUBMnRGbmcTBQZa5Ts0PPX 5bbA== X-Gm-Message-State: AOAM531flR361T3uViHErEO/SFp5SewqpHU0ENgoQvvOtBtRZpeIFAyg y7FDFOsEahzU3/nJu2W3eQ== X-Google-Smtp-Source: ABdhPJz80onPAITqqpwaWbabl4SgfiYAPqN/MWHUc1QI9/knq0XMJmKYbmvkCambm8IbFEAYxixOHg== X-Received: by 2002:a05:6602:2e05:: with SMTP id o5mr2566148iow.28.1590675470945; Thu, 28 May 2020 07:17:50 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id z3sm2623657ior.45.2020.05.28.07.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 07:17:50 -0700 (PDT) Received: (nullmailer pid 4189639 invoked by uid 1000); Thu, 28 May 2020 14:17:49 -0000 Date: Thu, 28 May 2020 08:17:49 -0600 From: Rob Herring To: Steve Lee Subject: Re: [V6 PATCH 1/2] dt-bindings: Added device tree binding for max98390 Message-ID: <20200528141749.GB4186430@bogus> References: <20200528103755.17381-1-steves.lee@maximintegrated.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200528103755.17381-1-steves.lee@maximintegrated.com> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, ryan.lee.maxim@gmail.com, ryans.lee@maximintegrated.com, steves.lee.maxim@gmail.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, broonie@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, May 28, 2020 at 07:37:55PM +0900, Steve Lee wrote: > Add DT binding of max98390 amplifier driver. > > Signed-off-by: Steve Lee > --- > Changed since V5: > * Change txt to yaml and fix up the examples. > Changed since V4: > * No changes. > Changed since V3: > * No changes. > Changed since V2: > * No changes. > Changed since V1: > * Modified sample text in example > > .../bindings/sound/maxim,max98390.yaml | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/maxim,max98390.yaml > > diff --git a/Documentation/devicetree/bindings/sound/maxim,max98390.yaml b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml > new file mode 100644 > index 000000000000..1ed4ab9e1c37 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/maxim,max98390.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim Integrated MAX98390 Speaker Amplifier with Integrated Dynamic Speaker Management > + > +maintainers: > + - Steve Lee > + > +properties: > + compatible: > + const: maxim,max98390 > + > + reg: > + maxItems: 1 > + description: I2C address of the device. > + > + temperature_calib: s/_/-/ And missing 'maxim' prefix. > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: The calculated temperature data was measured while doing the calibration. Data : Temp / 100 * 2^12 Any constraints? 0-2^32 are valid values? > + > + r0_calib: Same here. > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: This is r0 calibration data which was measured in factory mode. > + > +required: > + - compatible > + - reg Add: additionalProperties: false > + > +examples: > + - | > + max98390: amplifier@38 { > + compatible = "maxim,max98390"; > + reg = <0x38>; > + maxim,temperature_calib = <1024>; > + maxim,r0_calib = <100232>; > + }; > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BDB0C433DF for ; Thu, 28 May 2020 14:17:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 034CE2075F for ; Thu, 28 May 2020 14:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590675475; bh=zqc71Q27/B8/dUwRLhvm0S+/HIhHCNTNHUpNdVv+Lzc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Yl95yUWHBN0f80A1VEmcFP1WgfZ3qDuwG3iRKPk3T/B6oVWaU6ybqkbSKTWU/alPM 4wpkqfpw461MMmLNN0pwMqqzyHV96X8djhzqgiH9keD0xQYqHRpUagUm5DAVrOfEUX tch80ImEeXyanNkN8DNwjXj2f7FexAKpiM3hq0+c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391066AbgE1ORy (ORCPT ); Thu, 28 May 2020 10:17:54 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:43014 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390953AbgE1ORw (ORCPT ); Thu, 28 May 2020 10:17:52 -0400 Received: by mail-io1-f67.google.com with SMTP id h10so30110855iob.10; Thu, 28 May 2020 07:17:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BQyivfejSNXbCqlTdGdrhX0zYMkRgbdRvewpKbUjPCY=; b=Dv1T5prLKuzwbUBcUepbVsAyZlBdUeMeG9WYo2EeWgvHycfJBrRs770zkO3Iijsg8l jUZl3VEb64xbCNURpo/DOfYh2+vNQzF0+LI4aNKdUfKKTiM26CJvBBCu8HGmh3uZiPZ+ 6rLmeUCYxveYV8T/GVqNakXqFe0H8a9T2Kx0lgieRvrCsO3DmaP6K8aVealyHgiMBqr5 bgEDCEOhjWf5IIBXRfMGvJqvspPiLasXDS95AX4DSSo70H3xLXzCjh/ILnMq67YKu2vZ dP9H3qLONiq2Hap7PcImJrvENINkDIQFDg8//f6MRdBtdvpBgHN1+GUiJrF+vZqQtJ1E y4vg== X-Gm-Message-State: AOAM531JzXRHLNo55YlE9JfaF3VnGcphW0RO7adt2dP45VMUjPg5+viv xYxquSwwFuC9/UW0KzIw6g== X-Google-Smtp-Source: ABdhPJz80onPAITqqpwaWbabl4SgfiYAPqN/MWHUc1QI9/knq0XMJmKYbmvkCambm8IbFEAYxixOHg== X-Received: by 2002:a05:6602:2e05:: with SMTP id o5mr2566148iow.28.1590675470945; Thu, 28 May 2020 07:17:50 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id z3sm2623657ior.45.2020.05.28.07.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 07:17:50 -0700 (PDT) Received: (nullmailer pid 4189639 invoked by uid 1000); Thu, 28 May 2020 14:17:49 -0000 Date: Thu, 28 May 2020 08:17:49 -0600 From: Rob Herring To: Steve Lee Cc: lgirdwood@gmail.com, broonie@kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ryan.lee.maxim@gmail.com, ryans.lee@maximintegrated.com, steves.lee.maxim@gmail.com Subject: Re: [V6 PATCH 1/2] dt-bindings: Added device tree binding for max98390 Message-ID: <20200528141749.GB4186430@bogus> References: <20200528103755.17381-1-steves.lee@maximintegrated.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200528103755.17381-1-steves.lee@maximintegrated.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, May 28, 2020 at 07:37:55PM +0900, Steve Lee wrote: > Add DT binding of max98390 amplifier driver. > > Signed-off-by: Steve Lee > --- > Changed since V5: > * Change txt to yaml and fix up the examples. > Changed since V4: > * No changes. > Changed since V3: > * No changes. > Changed since V2: > * No changes. > Changed since V1: > * Modified sample text in example > > .../bindings/sound/maxim,max98390.yaml | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/maxim,max98390.yaml > > diff --git a/Documentation/devicetree/bindings/sound/maxim,max98390.yaml b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml > new file mode 100644 > index 000000000000..1ed4ab9e1c37 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/maxim,max98390.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim Integrated MAX98390 Speaker Amplifier with Integrated Dynamic Speaker Management > + > +maintainers: > + - Steve Lee > + > +properties: > + compatible: > + const: maxim,max98390 > + > + reg: > + maxItems: 1 > + description: I2C address of the device. > + > + temperature_calib: s/_/-/ And missing 'maxim' prefix. > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: The calculated temperature data was measured while doing the calibration. Data : Temp / 100 * 2^12 Any constraints? 0-2^32 are valid values? > + > + r0_calib: Same here. > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: This is r0 calibration data which was measured in factory mode. > + > +required: > + - compatible > + - reg Add: additionalProperties: false > + > +examples: > + - | > + max98390: amplifier@38 { > + compatible = "maxim,max98390"; > + reg = <0x38>; > + maxim,temperature_calib = <1024>; > + maxim,r0_calib = <100232>; > + }; > -- > 2.17.1 >