All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qian Cai <cai@lca.pw>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	kasan-dev <kasan-dev@googlegroups.com>,
	Linux Memory Management List <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Leon Romanovsky <leonro@mellanox.com>,
	Leon Romanovsky <leon@kernel.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH 2/3] kasan: move kasan_report() into report.c
Date: Thu, 28 May 2020 11:15:54 -0400	[thread overview]
Message-ID: <20200528151554.GC2702@lca.pw> (raw)
In-Reply-To: <CAAeHK+zELpKm7QA7PCxRtvRDTCXpjef9wOcOuRwjc-RcT2HSiA@mail.gmail.com>

On Thu, May 28, 2020 at 05:00:54PM +0200, 'Andrey Konovalov' via kasan-dev wrote:
> On Thu, May 28, 2020 at 3:49 PM Qian Cai <cai@lca.pw> wrote:
> >
> > On Tue, May 12, 2020 at 05:33:20PM +0200, 'Andrey Konovalov' via kasan-dev wrote:
> > > The kasan_report() functions belongs to report.c, as it's a common
> > > functions that does error reporting.
> > >
> > > Reported-by: Leon Romanovsky <leon@kernel.org>
> > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> >
> > Today's linux-next produced this with Clang 11.
> >
> > mm/kasan/report.o: warning: objtool: kasan_report()+0x8a: call to __stack_chk_fail() with UACCESS enabled
> >
> > kasan_report at mm/kasan/report.c:536
> 
> Hm, the first patch in the series ("kasan: consistently disable
> debugging features") disables stack protector for kasan files. Is that
> patch in linux-next?

Yes, it is there,

+CFLAGS_report.o := $(call cc-option, -fno-conserve-stack -fno-stack-protector)

It seems that will not work for Clang?

  reply	other threads:[~2020-05-28 15:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12 15:33 [PATCH 1/3] kasan: consistently disable debugging features Andrey Konovalov
2020-05-12 15:33 ` [PATCH 2/3] kasan: move kasan_report() into report.c Andrey Konovalov
2020-05-12 16:42   ` Leon Romanovsky
2020-05-28 13:49   ` Qian Cai
2020-05-28 14:33     ` Josh Poimboeuf
2020-05-28 14:55       ` Peter Zijlstra
2020-05-28 15:00     ` Andrey Konovalov
2020-05-28 15:15       ` Qian Cai [this message]
2020-05-28 15:24         ` Andrey Konovalov
2020-05-12 15:33 ` [PATCH 3/3] kasan: add missing functions declarations to kasan.h Andrey Konovalov
2020-05-12 16:41   ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200528151554.GC2702@lca.pw \
    --to=cai@lca.pw \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@google.com \
    --cc=aryabinin@virtuozzo.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=jpoimboe@redhat.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=leon@kernel.org \
    --cc=leonro@mellanox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.