From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9210C433E0 for ; Thu, 28 May 2020 16:05:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B6EC2071A for ; Thu, 28 May 2020 16:05:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404864AbgE1QFI (ORCPT ); Thu, 28 May 2020 12:05:08 -0400 Received: from ex13-edg-ou-002.vmware.com ([208.91.0.190]:17500 "EHLO EX13-EDG-OU-002.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404688AbgE1QFG (ORCPT ); Thu, 28 May 2020 12:05:06 -0400 Received: from sc9-mailhost2.vmware.com (10.113.161.72) by EX13-EDG-OU-002.vmware.com (10.113.208.156) with Microsoft SMTP Server id 15.0.1156.6; Thu, 28 May 2020 09:05:02 -0700 Received: from localhost (unknown [10.200.192.41]) by sc9-mailhost2.vmware.com (Postfix) with ESMTP id 0782FB1646; Thu, 28 May 2020 12:05:05 -0400 (EDT) Date: Thu, 28 May 2020 09:05:05 -0700 From: Matt Helsley To: Josh Poimboeuf CC: , Peter Zijlstra , Steven Rostedt Subject: Re: [RFC][PATCH 3/3] objtool: Add support for relocations without addends Message-ID: <20200528160505.GX9040@rlwimi.vmware.com> Mail-Followup-To: Matt Helsley , Josh Poimboeuf , linux-kernel@vger.kernel.org, Peter Zijlstra , Steven Rostedt References: <933488b79c91ba040e68847fe53531fd97b18e07.1590597288.git.mhelsley@vmware.com> <20200528142414.rzk5mvz4nwhsjcwp@treble> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200528142414.rzk5mvz4nwhsjcwp@treble> Received-SPF: None (EX13-EDG-OU-002.vmware.com: mhelsley@vmware.com does not designate permitted sender hosts) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2020 at 09:24:14AM -0500, Josh Poimboeuf wrote: > On Wed, May 27, 2020 at 09:42:33AM -0700, Matt Helsley wrote: > > @@ -525,16 +556,8 @@ static int read_relocs(struct elf *elf) > > return -1; > > } > > memset(reloc, 0, sizeof(*reloc)); > > - > > - if (!gelf_getrela(sec->data, i, &reloc->rela)) { > > - WARN_ELF("gelf_getrela"); > > + if (read_reloc(sec, i, reloc, &symndx)) > > return -1; > > - } > > I try to avoid function pointers, them being slow and ugly and all. > > Since it's just a single call site, I'd rather a direct call. For > example, call read_reloc(), which has an if-then to decide which > subfunction to call. OK, I'll take the function pointers out in favor of switches. Cheers, -Matt Helsley