From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [git pull] coredump infoleak fix
Date: Thu, 28 May 2020 20:28:33 +0100 [thread overview]
Message-ID: <20200528192833.GQ23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAHk-=whsZ_en9wEwk+VuAGMXACcSDCYhMD-GmQER0snpp9S6yg@mail.gmail.com>
On Thu, May 28, 2020 at 12:19:32PM -0700, Linus Torvalds wrote:
> On Thu, May 28, 2020 at 12:17 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > Might make sense to change the summary of that pull request to something
> > like
> > make sure we don't forget to report the xstate components that happen
> > to be in init state - both for coredump and for PTRACE_GETREGSET
>
> Note that this has nothing to do with x86 per se.
>
> It's more about ->getregs() being a horrid interface, and being easy
> to get wrong in general. The fact that xstate is complex is just one
> such trigger.
The only one I've ran into so far, fortunately... Almost all instances
write sequentially; the only exceptions are this one (buggy) and ia64
horrors with unwind.
I certainly agree that ->get() is an atrocity...
next prev parent reply other threads:[~2020-05-28 19:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 21:34 [git pull] coredump infoleak fix Al Viro
2020-05-28 7:02 ` Ingo Molnar
2020-05-28 7:05 ` Al Viro
2020-05-28 7:44 ` Ingo Molnar
2020-05-28 12:50 ` Al Viro
2020-05-29 9:35 ` Ingo Molnar
2020-05-28 7:29 ` [PATCH] fs/coredump/elf: Clean up fill_thread_core_info() Ingo Molnar
2020-05-28 7:40 ` [PATCH v2] " Ingo Molnar
2020-05-28 18:34 ` [git pull] coredump infoleak fix Linus Torvalds
2020-05-28 19:05 ` Al Viro
2020-05-28 19:09 ` Linus Torvalds
2020-05-28 19:17 ` Al Viro
2020-05-28 19:19 ` Linus Torvalds
2020-05-28 19:28 ` Al Viro [this message]
2020-05-29 9:39 ` Ingo Molnar
2020-05-31 18:05 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528192833.GQ23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.