From: "J. Bruce Fields" <bfields@fieldses.org>
To: NeilBrown <neilb@suse.de>
Cc: Jeff Layton <jlayton@kernel.org>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>
Subject: Re: The file_lock_operatoins.lock API seems to be a BAD API.
Date: Thu, 28 May 2020 18:01:12 -0400 [thread overview]
Message-ID: <20200528220112.GD20602@fieldses.org> (raw)
In-Reply-To: <87a71s8u23.fsf@notabene.neil.brown.name>
On Thu, May 28, 2020 at 04:14:44PM +1000, NeilBrown wrote:
> I don't think we should just fix all those bugs in those filesystems.
> I think that F_UNLCK should *always* remove the lock/lease.
> I imaging this happening by *always* calling posix_lock_file() (or
> similar) in the unlock case - after calling f_op->lock() first if that
> is appropriate.
>
> What do people think? It there on obvious reason that is a non-starter?
Isn't NFS unlock like close, in that it may be our only chance to return
IO errors?
But I guess you're not saying that unlock can't return errors, just that
it should always remove the lock whether it returns 0 or not.
Hm.
--b.
next prev parent reply other threads:[~2020-05-28 22:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 6:14 The file_lock_operatoins.lock API seems to be a BAD API NeilBrown
2020-05-28 22:01 ` J. Bruce Fields [this message]
2020-05-29 1:01 ` NeilBrown
2020-05-29 1:16 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528220112.GD20602@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.