All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Peter Zijlstra <peterz@infradead.org>
Cc: john mathew <john.mathew@unikie.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	mingo@redhat.com, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	bristot@redhat.com, tsbogend@alpha.franken.de,
	lukas.bulwahn@gmail.com, x86@kernel.org,
	linux-mips@vger.kernel.org, tglx@linutronix.de,
	mostafa.chamanara@gmail.com, willy@infradead.org,
	valentin.schneider@arm.com, rdunlap@infradead.org,
	Mostafa Chamanara <mostafa.chamanara@basemark.com>,
	Oleg Tsymbal <oleg.tsymbal@unikie.com>
Subject: Re: [RFC PATCH v5 2/3] docs: scheduler: Add scheduler overview documentation
Date: Fri, 29 May 2020 08:10:21 -0600	[thread overview]
Message-ID: <20200529081021.013e37d9@lwn.net> (raw)
In-Reply-To: <20200529110012.GJ706495@hirez.programming.kicks-ass.net>

On Fri, 29 May 2020 13:00:12 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> > +**Thermal Pressure**:  
> 
> I find these attached headers really hard to read. And what's with the
> ** stuff ?
> 
> Other files in this same patch use a different style:
> 
> Header
> ------
> test goes here,
> 
> Which I find a lot more readable. Use it here too?

Normal headers would seem to be appropriate here, yes.

> > +process runs when. In that context, it has the following tasks:
> > +
> > +* share CPU cores equally among all currently running processes.
> > +* pick appropriate process to run next if required, considering scheduling
> > +  class/policy and process priorities.
> > +* balance processes between multiple cores in SMP systems.  
> 
> indent the bullets at least one space, like:
> 
>  * share CPU cores...
>  * pick ..
> 
> Write it like you want to read this as a text document. Ignore all that
> RST bullshit.

The "RST bullshit" can handle a leading space there just fine.

> > +Runqueue
> > +~~~~~~~~
> > +
> > +:c:type:`struct rq <rq>` is the central data structure of process  
> 
> I so hate that rst crap; John, can't we teach the thing that anything
> called 'struct foo' or 'foo_t' is in fact a C type, just like we did
> with foo() being a function?

Yes, we can, we're just waiting for somebody (perhaps even me) to find the
time to do it. Until then, I think we can probably just leave :c:type: out
entirely.

jon

  reply	other threads:[~2020-05-29 14:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14  9:26 [RFC PATCH v5 0/3] Add scheduler overview documentation john mathew
2020-05-14  9:26 ` [RFC PATCH v5 1/3] docs: scheduler: Restructure scheduler documentation john mathew
2020-05-14  9:26 ` [RFC PATCH v5 2/3] docs: scheduler: Add scheduler overview documentation john mathew
2020-05-29 11:00   ` Peter Zijlstra
2020-05-29 14:10     ` Jonathan Corbet [this message]
2020-06-05  9:40     ` John Mathew
2020-06-23  7:17     ` John Mathew
2020-05-29 14:48   ` Vincent Guittot
2020-06-05  9:42     ` John Mathew
2020-05-14  9:26 ` [RFC PATCH v5 3/3] docs: scheduler: Add introduction to scheduler context-switch john mathew
2020-05-26 10:25   ` Srikar Dronamraju
2020-05-27  8:17     ` John Mathew
2020-05-25 16:35 ` [RFC PATCH v5 0/3] Add scheduler overview documentation Jonathan Corbet
2020-05-29  3:39   ` John Mathew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200529081021.013e37d9@lwn.net \
    --to=corbet@lwn.net \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=john.mathew@unikie.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=mostafa.chamanara@basemark.com \
    --cc=mostafa.chamanara@gmail.com \
    --cc=oleg.tsymbal@unikie.com \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=tsbogend@alpha.franken.de \
    --cc=valentin.schneider@arm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=willy@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.