From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 155A3C433E0 for ; Fri, 29 May 2020 08:31:56 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8F1B2075A for ; Fri, 29 May 2020 08:31:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="tj5OnQuy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8F1B2075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jeaQV-0004YA-2L; Fri, 29 May 2020 08:31:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jeaQT-0004Y5-DW for xen-devel@lists.xenproject.org; Fri, 29 May 2020 08:31:37 +0000 X-Inumbo-ID: cf85b5a4-a186-11ea-8993-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cf85b5a4-a186-11ea-8993-bc764e2007e4; Fri, 29 May 2020 08:31:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vZOraFRi6ebW9XR1eiOz56rc1fu0447TUnDn/r88w0o=; b=tj5OnQuyLzx2BNwRr0g0R7Hb9u /1VDZaiEQ1meYA/dRnaBhw7hAqH/+RANumF4l1F1R+PEWyGNpceBEuZl6D5gqxcLZxWYASKMClauS 7UdjweEQeKSApHI3FdYLfmCZIo4rZ/ptXqRwtOctjoC0TC4Ux6dqljOl0AqVBaK4KZJ8=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jeaQS-0006qZ-5f; Fri, 29 May 2020 08:31:36 +0000 Received: from [212.230.157.105] (helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jeaQR-0004kQ-Qv; Fri, 29 May 2020 08:31:36 +0000 Date: Fri, 29 May 2020 10:31:22 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Julien Grall Subject: Re: [PATCH v2 3/3] clang: don't define nocall Message-ID: <20200529083122.GJ1195@Air-de-Roger> References: <20200528144023.10814-1-roger.pau@citrix.com> <20200528144023.10814-4-roger.pau@citrix.com> <8aa8d35f-2928-2096-a47c-26659c5a43a2@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8aa8d35f-2928-2096-a47c-26659c5a43a2@xen.org> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Jan Beulich , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, May 29, 2020 at 08:25:44AM +0100, Julien Grall wrote: > Hi Roger, > > On 28/05/2020 15:40, Roger Pau Monne wrote: > > Clang doesn't support attribute error, and the possible equivalents > > like diagnose_if don't seem to work well in this case as they trigger > > when when the function is not called (just by being used by the > > APPEND_CALL macro). > > OOI, could you share the diagnose_if change you tried? I've sent a reduced version to the llvm-dev mailing list, because I think the documentation should be fixed for diagnose_if. The email with the example is at: http://lists.llvm.org/pipermail/llvm-dev/2020-May/141908.html FWIW, using the deprecated attribute will also trigger the same error/warning even when not calling the function from C. > > > > Define nocall to a noop on clang until a proper solution can be found. > > > > Signed-off-by: Roger Pau Monné > > Acked-by: Julien Grall Thanks!