From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yi Wang <wang.yi59@zte.com.cn>
Cc: davem@davemloft.net, kuba@kernel.org, mst@redhat.com,
hkallweit1@gmail.com, snelson@pensando.io,
xiyou.wangcong@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, xue.zhihong@zte.com.cn,
wang.liang82@zte.com.cn, Liao Pingfang <liao.pingfang@zte.com.cn>
Subject: Re: [PATCH] net: atm: Replace kmalloc with kzalloc in the error message
Date: Fri, 29 May 2020 12:22:55 +0300 [thread overview]
Message-ID: <20200529092255.GW1634618@smile.fi.intel.com> (raw)
In-Reply-To: <1590714102-15651-1-git-send-email-wang.yi59@zte.com.cn>
On Fri, May 29, 2020 at 09:01:42AM +0800, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Use kzalloc instead of kmalloc in the error message according to
> the previous kzalloc() call.
Looking into the context (atomic!) and error message itself I would rather drop
message completely.
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> ---
> net/atm/lec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/atm/lec.c b/net/atm/lec.c
> index ca37f5a..33033d7 100644
> --- a/net/atm/lec.c
> +++ b/net/atm/lec.c
> @@ -1537,7 +1537,7 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv,
>
> to_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC);
> if (!to_return) {
> - pr_info("LEC: Arp entry kmalloc failed\n");
> + pr_info("LEC: Arp entry kzalloc failed\n");
> return NULL;
> }
> ether_addr_copy(to_return->mac_addr, mac_addr);
> --
> 2.9.5
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-05-29 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 1:01 [PATCH] net: atm: Replace kmalloc with kzalloc in the error message Yi Wang
2020-05-29 9:22 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-29 17:54 Markus Elfring
2020-05-29 17:54 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529092255.GW1634618@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=liao.pingfang@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=xiyou.wangcong@gmail.com \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.