All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [staging:staging-next 391/415] drivers/staging/wfx/sta.c:203:5: warning: no previous prototype for 'wfx_get_ps_timeout'
Date: Fri, 29 May 2020 09:27:36 +0800	[thread overview]
Message-ID: <202005290933.XU0wefb9%lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3868 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
head:   36cf583eaff3458abbfac144c5e4d417a23fa1a1
commit: 398999dabc8cfc51c7274639cb87e2a316138859 [391/415] staging: wfx: split wfx_get_ps_timeout() from wfx_update_pm()
config: nds32-allyesconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 398999dabc8cfc51c7274639cb87e2a316138859
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

In file included from ./arch/nds32/include/generated/asm/bug.h:1,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/nds32/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/skbuff.h:15,
from include/linux/if_ether.h:19,
from include/linux/etherdevice.h:20,
from drivers/staging/wfx/sta.c:8:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/nds32/include/asm/memory.h:82:32: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
82 | #define pfn_valid(pfn)  ((pfn) >= PHYS_PFN_OFFSET && (pfn) < (PHYS_PFN_OFFSET + max_mapnr))
|                                ^~
include/asm-generic/bug.h:139:27: note: in definition of macro 'WARN_ON_ONCE'
139 |  int __ret_warn_once = !!(condition);            |                           ^~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 |  if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
|                   ^~~~~~~~~
drivers/staging/wfx/sta.c: At top level:
>> drivers/staging/wfx/sta.c:203:5: warning: no previous prototype for 'wfx_get_ps_timeout' [-Wmissing-prototypes]
203 | int wfx_get_ps_timeout(struct wfx_vif *wvif, bool *enable_ps)
|     ^~~~~~~~~~~~~~~~~~
drivers/staging/wfx/sta.c:233:5: warning: no previous prototype for 'wfx_update_pm' [-Wmissing-prototypes]
233 | int wfx_update_pm(struct wfx_vif *wvif)
|     ^~~~~~~~~~~~~

vim +/wfx_get_ps_timeout +203 drivers/staging/wfx/sta.c

   202	
 > 203	int wfx_get_ps_timeout(struct wfx_vif *wvif, bool *enable_ps)
   204	{
   205		struct ieee80211_channel *chan0 = NULL, *chan1 = NULL;
   206		struct ieee80211_conf *conf = &wvif->wdev->hw->conf;
   207	
   208		WARN(!wvif->vif->bss_conf.assoc && enable_ps,
   209		     "enable_ps is reliable only if associated");
   210		if (wdev_to_wvif(wvif->wdev, 0))
   211			chan0 = wdev_to_wvif(wvif->wdev, 0)->vif->bss_conf.chandef.chan;
   212		if (wdev_to_wvif(wvif->wdev, 1))
   213			chan1 = wdev_to_wvif(wvif->wdev, 1)->vif->bss_conf.chandef.chan;
   214		if (chan0 && chan1 && chan0->hw_value != chan1->hw_value &&
   215		    wvif->vif->type != NL80211_IFTYPE_AP) {
   216			// It is necessary to enable powersave if channels
   217			// are differents.
   218			if (enable_ps)
   219				*enable_ps = true;
   220			if (wvif->bss_not_support_ps_poll)
   221				return 30;
   222			else
   223				return 0;
   224		}
   225		if (enable_ps)
   226			*enable_ps = wvif->vif->bss_conf.ps;
   227		if (wvif->vif->bss_conf.assoc && wvif->vif->bss_conf.ps)
   228			return conf->dynamic_ps_timeout;
   229		else
   230			return -1;
   231	}
   232	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 56171 bytes --]

                 reply	other threads:[~2020-05-29  1:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202005290933.XU0wefb9%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.