From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74B5AC433E0 for ; Fri, 29 May 2020 10:16:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 476802075A for ; Fri, 29 May 2020 10:16:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YDCI2e/L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 476802075A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xzaNyMAd66zuLVKUh4RsjQxboxGgAbSqPOAh86WnYho=; b=YDCI2e/LXfFUEj JjJ9tqi8xFuZ+opfH0jct2kqWTTkFTPd7tPejqgK2kFPtTnOwZznmmQ0rTCT6nf5Gf49eDe3T/W+p gWDtJNb8jzMSL5Cp3xMXbGZsPE8nphSCO7N5jYTcyu4fy7HqmPPkzSZpTcyXySqD7Md4/Og8r5sLM hUO7ZZL0dQ81qiZdPEQFnHc3GPGc0upRAEKp6vK92XWD/+48J0RIFOYNTE7Z3qA7E+oIj7v6ihy8T 30vqofW5x8Noyr0CZ+s3CMVshevmE87vjRD+3zt/l6MZLodVvK3y8Chqwr0PjsNMo8oIcOztu87Wl hJHrD/sXFHKrPLOHtQag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jec3m-0001IJ-QO; Fri, 29 May 2020 10:16:18 +0000 Received: from mail-lj1-f193.google.com ([209.85.208.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jec3k-0001HW-4t; Fri, 29 May 2020 10:16:17 +0000 Received: by mail-lj1-f193.google.com with SMTP id z18so1881452lji.12; Fri, 29 May 2020 03:16:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qb23YrFge2bev6B+pdY5MYpRbBAt1YLbxMOSUywPdHk=; b=QUJHk+rjfRS6Mzozco5dZQcKmlQCv3K+k7fXcHZVtkKN1OsjLSbGXLrDrMqo4kt27X qXJZdsrLnIIVVsbRL6iobjoaxczwLwn+tSEPQT+HkmPKEcREUWjMLoFbbvip4IFI+ps5 f+ZC1PV27uIPZ7F9L3NftBBl6dm7Phfz9SEWFLiVu+gx9VDehV2XztHwlKSRomMolEV5 cHZXjVrOGS+4krw/wCQ3dVoA9n4pXghfTDoSAn7832VZ+bNtDWZCnug4CDiYx7+zLs2W e7wLbORxEzJTKqt9n9onufO0NSrOPhZIkGSA7ejo28Ia3FTSnDRem0EaLH9FGOrYgSk9 IfBg== X-Gm-Message-State: AOAM531VKpvp5XfU4otPrV7fh6bPZ8cWv9naqDWS/3wzKKqynDJ79aAv +IE1Gh2KYZj4bZzfgn4pFXY= X-Google-Smtp-Source: ABdhPJyb49lJcndlDqUtkrSajYOpqC0lpLBM00Du0tW1RABChW4sreguvSnQJV4+HR28+sDilaHYIw== X-Received: by 2002:a05:651c:39b:: with SMTP id e27mr3886282ljp.253.1590747373144; Fri, 29 May 2020 03:16:13 -0700 (PDT) Received: from xi.terra (c-beaee455.07-184-6d6c6d4.bbcust.telenor.se. [85.228.174.190]) by smtp.gmail.com with ESMTPSA id h26sm2236339lja.0.2020.05.29.03.16.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 03:16:12 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.93.0.4) (envelope-from ) id 1jec3c-0004TR-D6; Fri, 29 May 2020 12:16:08 +0200 Date: Fri, 29 May 2020 12:16:08 +0200 From: Johan Hovold To: Alexandru Ardelean Subject: Re: [PATCH 4/5] iio: light: lm3533-als: remove explicit parent assignment Message-ID: <20200529101608.GC19480@localhost> References: <20200522082208.383631-1-alexandru.ardelean@analog.com> <20200522082208.383631-4-alexandru.ardelean@analog.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200522082208.383631-4-alexandru.ardelean@analog.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200529_031616_190737_B6A4A29F X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: milo.kim@ti.com, tomislav.denis@avl.com, dan@dlrobertson.com, heiko@sntech.de, linux-aspeed@lists.ozlabs.org, linux-iio@vger.kernel.org, linus.walleij@linaro.org, eajames@linux.ibm.com, platform-driver-x86@vger.kernel.org, paul@crapouillou.net, lorenzo.bianconi83@gmail.com, songqiang1304521@gmail.com, srinivas.pandruvada@linux.intel.com, linux-stm32@st-md-mailman.stormreply.com, devel@driverdev.osuosl.org, linux-samsung-soc@vger.kernel.org, khilman@baylibre.com, tduszyns@gmail.com, krzk@kernel.org, linux-rockchip@lists.infradead.org, wens@csie.org, kgene@kernel.org, bcm-kernel-feedback-list@broadcom.com, agross@kernel.org, linux-input@vger.kernel.org, orsonzhai@gmail.com, alexandre.torgue@st.com, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, jikos@kernel.org, vilhelm.gray@gmail.com, mripard@kernel.org, vz@mleia.com, hdegoede@redhat.com, linux-mediatek@lists.infradead.org, ak@it-klinger.de, matthias.bgg@gmail.com, linux-amlogic@lists.infradead.org, fabrice.gasnier@st.com, linux-arm-kernel@lists.infradead.org, sbranden@broadcom.com, rmfrfs@gmail.com, shawnguo@kernel.org, dmitry.torokhov@gmail.com, coproscefalo@gmail.com, linux-kernel@vger.kernel.org, rjui@broadcom.com, slemieux.tyco@gmail.com, bjorn.andersson@linaro.org, mcoquelin.stm32@gmail.com, zhang.lyra@gmail.com, baolin.wang7@gmail.com, ktsai@capellamicro.com, syednwaris@gmail.com, peda@axentia.se, jic23@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Fri, May 22, 2020 at 11:22:07AM +0300, Alexandru Ardelean wrote: > This assignment is the more peculiar of the bunch as it assigns the parent > of the platform-device's device (i.e. pdev->dev.parent) as the IIO device's > parent. > > It's unclear whether this is intentional or not. > Hence it is in it's own patch. Yeah, we have a few mfd drivers whose child drivers registers their class devices directly under the parent mfd device rather than the corresponding child platform device. Since it's done consistently I think you need to update them all if you really want to change this. And it may not be worth it since at least in theory someone could now be relying on this topology. > Signed-off-by: Alexandru Ardelean > --- > drivers/iio/light/lm3533-als.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c > index bc196c212881..0f380ec8d30c 100644 > --- a/drivers/iio/light/lm3533-als.c > +++ b/drivers/iio/light/lm3533-als.c > @@ -852,7 +852,6 @@ static int lm3533_als_probe(struct platform_device *pdev) > indio_dev->channels = lm3533_als_channels; > indio_dev->num_channels = ARRAY_SIZE(lm3533_als_channels); > indio_dev->name = dev_name(&pdev->dev); > - indio_dev->dev.parent = pdev->dev.parent; > indio_dev->modes = INDIO_DIRECT_MODE; > > als = iio_priv(indio_dev); Johan _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Date: Fri, 29 May 2020 12:16:08 +0200 Subject: [PATCH 4/5] iio: light: lm3533-als: remove explicit parent assignment In-Reply-To: <20200522082208.383631-4-alexandru.ardelean@analog.com> References: <20200522082208.383631-1-alexandru.ardelean@analog.com> <20200522082208.383631-4-alexandru.ardelean@analog.com> Message-ID: <20200529101608.GC19480@localhost> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, May 22, 2020 at 11:22:07AM +0300, Alexandru Ardelean wrote: > This assignment is the more peculiar of the bunch as it assigns the parent > of the platform-device's device (i.e. pdev->dev.parent) as the IIO device's > parent. > > It's unclear whether this is intentional or not. > Hence it is in it's own patch. Yeah, we have a few mfd drivers whose child drivers registers their class devices directly under the parent mfd device rather than the corresponding child platform device. Since it's done consistently I think you need to update them all if you really want to change this. And it may not be worth it since at least in theory someone could now be relying on this topology. > Signed-off-by: Alexandru Ardelean > --- > drivers/iio/light/lm3533-als.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c > index bc196c212881..0f380ec8d30c 100644 > --- a/drivers/iio/light/lm3533-als.c > +++ b/drivers/iio/light/lm3533-als.c > @@ -852,7 +852,6 @@ static int lm3533_als_probe(struct platform_device *pdev) > indio_dev->channels = lm3533_als_channels; > indio_dev->num_channels = ARRAY_SIZE(lm3533_als_channels); > indio_dev->name = dev_name(&pdev->dev); > - indio_dev->dev.parent = pdev->dev.parent; > indio_dev->modes = INDIO_DIRECT_MODE; > > als = iio_priv(indio_dev); Johan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79C34C433E0 for ; Fri, 29 May 2020 10:16:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 594492075A for ; Fri, 29 May 2020 10:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590747384; bh=S4FW1mFhzacDYR6Eu/v6cF3Wv3v9bxdFZaT+hUnGvao=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tVQ+Ve1sJN+DlJFWhBorHpwu1CyPquQsdR9YtiAhVQlFLhhDRfA0lk9XmE3ob213/ H4/scP8KvZB0RCZ3uFcA6qF+LqCosFU5/bk0yCpf6qp9VMHU+Fn2SQ7aOR5F5n+gTo /lpNXMrT4Uhp8KfGtr1SSOejCXpnOdvBols2jPos= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726394AbgE2KQU (ORCPT ); Fri, 29 May 2020 06:16:20 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:45483 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbgE2KQR (ORCPT ); Fri, 29 May 2020 06:16:17 -0400 Received: by mail-lj1-f196.google.com with SMTP id z18so1881456lji.12; Fri, 29 May 2020 03:16:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qb23YrFge2bev6B+pdY5MYpRbBAt1YLbxMOSUywPdHk=; b=cZaH0DKeLwkKayN1g+x2VJNhADXnu4nL0vSdS/b+fM2kg+16H4sXwqx6iK+z8ZyLeF uPY2l26f1BPnMQft2ohw7um4HIFJRpj6OL3aQkyb1cFItrFXrXmSCdT5H7jC+TlyQwDm ZjfpqLk5ryiZaCaBSoSaMAVOEfWBRMg2yP4zNFDPNLx1iDNny2k1ZgNw3mx02BIpRWVV XKCXBojmkFewoirKEDwupB9EKXMiPWwfaXZg7aJUIaIrifa5ohS7rFYYTkMXQGo2J/z0 0CVzTu3Gp9kz3GXLKhI4Dir9VBMXpCVOy+TnoQHfJ7wUQFB5TvozI5lpt2meE0lEoBln 9m3A== X-Gm-Message-State: AOAM531MzDINtCgDtROORRtIEWc36Cnsd2TOl9Tl3yF03DFtuIwvi6f6 51KH4BmEL9ijvv2nF/RLdPs= X-Google-Smtp-Source: ABdhPJyb49lJcndlDqUtkrSajYOpqC0lpLBM00Du0tW1RABChW4sreguvSnQJV4+HR28+sDilaHYIw== X-Received: by 2002:a05:651c:39b:: with SMTP id e27mr3886282ljp.253.1590747373144; Fri, 29 May 2020 03:16:13 -0700 (PDT) Received: from xi.terra (c-beaee455.07-184-6d6c6d4.bbcust.telenor.se. [85.228.174.190]) by smtp.gmail.com with ESMTPSA id h26sm2236339lja.0.2020.05.29.03.16.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 03:16:12 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.93.0.4) (envelope-from ) id 1jec3c-0004TR-D6; Fri, 29 May 2020 12:16:08 +0200 Date: Fri, 29 May 2020 12:16:08 +0200 From: Johan Hovold To: Alexandru Ardelean Cc: bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org, platform-driver-x86@vger.kernel.org, devel@driverdev.osuosl.org, vilhelm.gray@gmail.com, syednwaris@gmail.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, jic23@kernel.org, dan@dlrobertson.com, jikos@kernel.org, srinivas.pandruvada@linux.intel.com, linus.walleij@linaro.org, wens@csie.org, hdegoede@redhat.com, rjui@broadcom.com, sbranden@broadcom.com, peda@axentia.se, kgene@kernel.org, krzk@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, ak@it-klinger.de, paul@crapouillou.net, milo.kim@ti.com, vz@mleia.com, slemieux.tyco@gmail.com, khilman@baylibre.com, matthias.bgg@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org, heiko@sntech.de, orsonzhai@gmail.com, baolin.wang7@gmail.com, zhang.lyra@gmail.com, mripard@kernel.org, tduszyns@gmail.com, rmfrfs@gmail.com, lorenzo.bianconi83@gmail.com, ktsai@capellamicro.com, songqiang1304521@gmail.com, tomislav.denis@avl.com, eajames@linux.ibm.com, dmitry.torokhov@gmail.com, coproscefalo@gmail.com Subject: Re: [PATCH 4/5] iio: light: lm3533-als: remove explicit parent assignment Message-ID: <20200529101608.GC19480@localhost> References: <20200522082208.383631-1-alexandru.ardelean@analog.com> <20200522082208.383631-4-alexandru.ardelean@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200522082208.383631-4-alexandru.ardelean@analog.com> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, May 22, 2020 at 11:22:07AM +0300, Alexandru Ardelean wrote: > This assignment is the more peculiar of the bunch as it assigns the parent > of the platform-device's device (i.e. pdev->dev.parent) as the IIO device's > parent. > > It's unclear whether this is intentional or not. > Hence it is in it's own patch. Yeah, we have a few mfd drivers whose child drivers registers their class devices directly under the parent mfd device rather than the corresponding child platform device. Since it's done consistently I think you need to update them all if you really want to change this. And it may not be worth it since at least in theory someone could now be relying on this topology. > Signed-off-by: Alexandru Ardelean > --- > drivers/iio/light/lm3533-als.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c > index bc196c212881..0f380ec8d30c 100644 > --- a/drivers/iio/light/lm3533-als.c > +++ b/drivers/iio/light/lm3533-als.c > @@ -852,7 +852,6 @@ static int lm3533_als_probe(struct platform_device *pdev) > indio_dev->channels = lm3533_als_channels; > indio_dev->num_channels = ARRAY_SIZE(lm3533_als_channels); > indio_dev->name = dev_name(&pdev->dev); > - indio_dev->dev.parent = pdev->dev.parent; > indio_dev->modes = INDIO_DIRECT_MODE; > > als = iio_priv(indio_dev); Johan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A64AC433E0 for ; Fri, 29 May 2020 10:16:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E10FD2075A for ; Fri, 29 May 2020 10:16:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fM0OFdBx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E10FD2075A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GeL9jsmdn8FSKTvOGMlLf8PPvIg/64FP/HMWfvq4YEo=; b=fM0OFdBxxx2ki1 YlyDoRjymgtO+wy1CVilvwmLYmOfhUBKrsHyP7zWtfbTtovq8jOLPB9FLST86WFGqtujCLwyYBZzn Sh98A1mKfvTvS6vZikFCRumwY5x9cce7u2/6pyEO7K6/Cc31+xkWipGKfAWeJQzv7LbBfcsHOC6Ws txrDBC002gzH9L+qxXhIHm1Usx4hZRyCYdros1F2yuGvY0BwL5aC1klagr1Q8Xld72ZcXFETLMHl/ OSbRgnKwlurkv6wmzMC00D+sa+xYK7AXnjGGquUFjOCs6cxH65A16S/NwwE74dtD5KnX7c7lgGRo6 uYYAxsjDXNm0zCIIuSYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jec3n-0001Ix-Ec; Fri, 29 May 2020 10:16:19 +0000 Received: from mail-lj1-f193.google.com ([209.85.208.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jec3k-0001HW-4t; Fri, 29 May 2020 10:16:17 +0000 Received: by mail-lj1-f193.google.com with SMTP id z18so1881452lji.12; Fri, 29 May 2020 03:16:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qb23YrFge2bev6B+pdY5MYpRbBAt1YLbxMOSUywPdHk=; b=QUJHk+rjfRS6Mzozco5dZQcKmlQCv3K+k7fXcHZVtkKN1OsjLSbGXLrDrMqo4kt27X qXJZdsrLnIIVVsbRL6iobjoaxczwLwn+tSEPQT+HkmPKEcREUWjMLoFbbvip4IFI+ps5 f+ZC1PV27uIPZ7F9L3NftBBl6dm7Phfz9SEWFLiVu+gx9VDehV2XztHwlKSRomMolEV5 cHZXjVrOGS+4krw/wCQ3dVoA9n4pXghfTDoSAn7832VZ+bNtDWZCnug4CDiYx7+zLs2W e7wLbORxEzJTKqt9n9onufO0NSrOPhZIkGSA7ejo28Ia3FTSnDRem0EaLH9FGOrYgSk9 IfBg== X-Gm-Message-State: AOAM531VKpvp5XfU4otPrV7fh6bPZ8cWv9naqDWS/3wzKKqynDJ79aAv +IE1Gh2KYZj4bZzfgn4pFXY= X-Google-Smtp-Source: ABdhPJyb49lJcndlDqUtkrSajYOpqC0lpLBM00Du0tW1RABChW4sreguvSnQJV4+HR28+sDilaHYIw== X-Received: by 2002:a05:651c:39b:: with SMTP id e27mr3886282ljp.253.1590747373144; Fri, 29 May 2020 03:16:13 -0700 (PDT) Received: from xi.terra (c-beaee455.07-184-6d6c6d4.bbcust.telenor.se. [85.228.174.190]) by smtp.gmail.com with ESMTPSA id h26sm2236339lja.0.2020.05.29.03.16.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 03:16:12 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.93.0.4) (envelope-from ) id 1jec3c-0004TR-D6; Fri, 29 May 2020 12:16:08 +0200 Date: Fri, 29 May 2020 12:16:08 +0200 From: Johan Hovold To: Alexandru Ardelean Subject: Re: [PATCH 4/5] iio: light: lm3533-als: remove explicit parent assignment Message-ID: <20200529101608.GC19480@localhost> References: <20200522082208.383631-1-alexandru.ardelean@analog.com> <20200522082208.383631-4-alexandru.ardelean@analog.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200522082208.383631-4-alexandru.ardelean@analog.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200529_031616_190737_B6A4A29F X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: milo.kim@ti.com, tomislav.denis@avl.com, dan@dlrobertson.com, heiko@sntech.de, linux-aspeed@lists.ozlabs.org, linux-iio@vger.kernel.org, linus.walleij@linaro.org, eajames@linux.ibm.com, platform-driver-x86@vger.kernel.org, paul@crapouillou.net, lorenzo.bianconi83@gmail.com, songqiang1304521@gmail.com, srinivas.pandruvada@linux.intel.com, linux-stm32@st-md-mailman.stormreply.com, devel@driverdev.osuosl.org, linux-samsung-soc@vger.kernel.org, khilman@baylibre.com, tduszyns@gmail.com, krzk@kernel.org, linux-rockchip@lists.infradead.org, wens@csie.org, kgene@kernel.org, bcm-kernel-feedback-list@broadcom.com, agross@kernel.org, linux-input@vger.kernel.org, orsonzhai@gmail.com, alexandre.torgue@st.com, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, jikos@kernel.org, vilhelm.gray@gmail.com, mripard@kernel.org, vz@mleia.com, hdegoede@redhat.com, linux-mediatek@lists.infradead.org, ak@it-klinger.de, matthias.bgg@gmail.com, linux-amlogic@lists.infradead.org, fabrice.gasnier@st.com, linux-arm-kernel@lists.infradead.org, sbranden@broadcom.com, rmfrfs@gmail.com, shawnguo@kernel.org, dmitry.torokhov@gmail.com, coproscefalo@gmail.com, linux-kernel@vger.kernel.org, rjui@broadcom.com, slemieux.tyco@gmail.com, bjorn.andersson@linaro.org, mcoquelin.stm32@gmail.com, zhang.lyra@gmail.com, baolin.wang7@gmail.com, ktsai@capellamicro.com, syednwaris@gmail.com, peda@axentia.se, jic23@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, May 22, 2020 at 11:22:07AM +0300, Alexandru Ardelean wrote: > This assignment is the more peculiar of the bunch as it assigns the parent > of the platform-device's device (i.e. pdev->dev.parent) as the IIO device's > parent. > > It's unclear whether this is intentional or not. > Hence it is in it's own patch. Yeah, we have a few mfd drivers whose child drivers registers their class devices directly under the parent mfd device rather than the corresponding child platform device. Since it's done consistently I think you need to update them all if you really want to change this. And it may not be worth it since at least in theory someone could now be relying on this topology. > Signed-off-by: Alexandru Ardelean > --- > drivers/iio/light/lm3533-als.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c > index bc196c212881..0f380ec8d30c 100644 > --- a/drivers/iio/light/lm3533-als.c > +++ b/drivers/iio/light/lm3533-als.c > @@ -852,7 +852,6 @@ static int lm3533_als_probe(struct platform_device *pdev) > indio_dev->channels = lm3533_als_channels; > indio_dev->num_channels = ARRAY_SIZE(lm3533_als_channels); > indio_dev->name = dev_name(&pdev->dev); > - indio_dev->dev.parent = pdev->dev.parent; > indio_dev->modes = INDIO_DIRECT_MODE; > > als = iio_priv(indio_dev); Johan _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: Re: [PATCH 4/5] iio: light: lm3533-als: remove explicit parent assignment Date: Fri, 29 May 2020 12:16:08 +0200 Message-ID: <20200529101608.GC19480@localhost> References: <20200522082208.383631-1-alexandru.ardelean@analog.com> <20200522082208.383631-4-alexandru.ardelean@analog.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200522082208.383631-4-alexandru.ardelean@analog.com> Sender: linux-kernel-owner@vger.kernel.org To: Alexandru Ardelean Cc: bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org, platform-driver-x86@vger.kernel.org, devel@driverdev.osuosl.org, vilhelm.gray@gmail.com, syednwaris@gmail.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, jic23@kernel.org, dan@dlrobertson.com, jikos@kernel.org, srinivas.pandruvada@linux.intel.com, linus.walleij@linaro.org, wens@csie.org, hdegoede@redhat.com, rjui@b List-Id: linux-rockchip.vger.kernel.org On Fri, May 22, 2020 at 11:22:07AM +0300, Alexandru Ardelean wrote: > This assignment is the more peculiar of the bunch as it assigns the parent > of the platform-device's device (i.e. pdev->dev.parent) as the IIO device's > parent. > > It's unclear whether this is intentional or not. > Hence it is in it's own patch. Yeah, we have a few mfd drivers whose child drivers registers their class devices directly under the parent mfd device rather than the corresponding child platform device. Since it's done consistently I think you need to update them all if you really want to change this. And it may not be worth it since at least in theory someone could now be relying on this topology. > Signed-off-by: Alexandru Ardelean > --- > drivers/iio/light/lm3533-als.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c > index bc196c212881..0f380ec8d30c 100644 > --- a/drivers/iio/light/lm3533-als.c > +++ b/drivers/iio/light/lm3533-als.c > @@ -852,7 +852,6 @@ static int lm3533_als_probe(struct platform_device *pdev) > indio_dev->channels = lm3533_als_channels; > indio_dev->num_channels = ARRAY_SIZE(lm3533_als_channels); > indio_dev->name = dev_name(&pdev->dev); > - indio_dev->dev.parent = pdev->dev.parent; > indio_dev->modes = INDIO_DIRECT_MODE; > > als = iio_priv(indio_dev); Johan