All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 3/6] lockdep: Change hardirq{s_enabled, _context} to per-cpu variables
Date: Fri, 29 May 2020 11:55:31 +0800	[thread overview]
Message-ID: <202005291154.gxc8GIiI%lkp@intel.com> (raw)
In-Reply-To: <20200528140946.831087909@infradead.org>

[-- Attachment #1: Type: text/plain, Size: 3416 bytes --]

Hi Peter,

I love your patch! Yet something to improve:

[auto build test ERROR on tip/auto-latest]
[cannot apply to tip/locking/core tip/x86/asm linus/master tip/x86/core v5.7-rc7 next-20200528]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Peter-Zijlstra/x86-entry-lockdep-Improve-IRQ-state-tracking/20200528-222257
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 4e052965f46b6fd9641d79bf10208eac2631475f
config: s390-randconfig-m031-20200528 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>, old ones prefixed by <<):

In file included from arch/s390/include/asm/processor.h:41,
from arch/s390/include/asm/thread_info.h:27,
from include/linux/thread_info.h:38,
from arch/s390/include/asm/preempt.h:6,
from include/linux/preempt.h:78,
from arch/s390/include/asm/percpu.h:5,
from include/linux/lockdep.h:23,
from include/linux/spinlock_types.h:18,
from kernel/bounds.c:14:
>> include/linux/irqflags.h:36:22: error: unknown type name 'hardirqs_enabled'
36 | DECLARE_PER_CPU(int, hardirqs_enabled);
|                      ^~~~~~~~~~~~~~~~
>> include/linux/irqflags.h:37:22: error: unknown type name 'hardirq_context'
37 | DECLARE_PER_CPU(int, hardirq_context);
|                      ^~~~~~~~~~~~~~~
make[2]: *** [scripts/Makefile.build:100: kernel/bounds.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1149: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:180: sub-make] Error 2

vim +/hardirqs_enabled +36 include/linux/irqflags.h

    35	
  > 36	DECLARE_PER_CPU(int, hardirqs_enabled);
  > 37	DECLARE_PER_CPU(int, hardirq_context);
    38	
    39	  extern void trace_hardirqs_on_prepare(void);
    40	  extern void trace_hardirqs_off_finish(void);
    41	  extern void trace_hardirqs_on(void);
    42	  extern void trace_hardirqs_off(void);
    43	# define lockdep_hardirq_context(p)	(this_cpu_read(hardirq_context))
    44	# define lockdep_softirq_context(p)	((p)->softirq_context)
    45	# define lockdep_hardirqs_enabled(p)	(this_cpu_read(hardirqs_enabled))
    46	# define lockdep_softirqs_enabled(p)	((p)->softirqs_enabled)
    47	# define lockdep_hardirq_enter()			\
    48	do {							\
    49		if (this_cpu_inc_return(hardirq_context) == 1)	\
    50			current->hardirq_threaded = 0;		\
    51	} while (0)
    52	# define lockdep_hardirq_threaded()		\
    53	do {						\
    54		current->hardirq_threaded = 1;		\
    55	} while (0)
    56	# define lockdep_hardirq_exit()			\
    57	do {						\
    58		this_cpu_dec(hardirq_context);		\
    59	} while (0)
    60	# define lockdep_softirq_enter()		\
    61	do {						\
    62		current->softirq_context++;		\
    63	} while (0)
    64	# define lockdep_softirq_exit()			\
    65	do {						\
    66		current->softirq_context--;		\
    67	} while (0)
    68	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 29429 bytes --]

  reply	other threads:[~2020-05-29  3:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28 14:05 [PATCH v2 0/6] x86/entry,lockdep: Improve IRQ state tracking Peter Zijlstra
2020-05-28 14:05 ` [PATCH v2 1/6] x86/entry: Clarify irq_{enter,exit}_rcu() Peter Zijlstra
2020-05-28 14:05 ` [PATCH v2 2/6] x86/entry: Rename trace_hardirqs_off_prepare() Peter Zijlstra
2020-05-28 14:05 ` [PATCH v2 3/6] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables Peter Zijlstra
2020-05-29  3:55   ` kbuild test robot [this message]
2020-05-29  4:12   ` [PATCH v2 3/6] lockdep: Change hardirq{s_enabled, _context} " kbuild test robot
2020-05-29 16:16   ` [PATCH v2 3/6] lockdep: Change hardirq{s_enabled,_context} " Peter Zijlstra
2020-05-29 19:38     ` Peter Zijlstra
2020-05-28 14:05 ` [PATCH v2 4/6] lockdep: Remove lockdep_hardirq{s_enabled,_context}() argument Peter Zijlstra
2020-05-28 14:05 ` [PATCH v2 5/6] lockdep: Prepare for NMI IRQ state tracking Peter Zijlstra
2020-05-28 14:05 ` [PATCH v2 6/6] x86/entry: Fix NMI vs " Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202005291154.gxc8GIiI%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.