From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB691C433E0 for ; Fri, 29 May 2020 12:26:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF6982075A for ; Fri, 29 May 2020 12:26:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726860AbgE2M0y (ORCPT ); Fri, 29 May 2020 08:26:54 -0400 Received: from verein.lst.de ([213.95.11.211]:32774 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726052AbgE2M0x (ORCPT ); Fri, 29 May 2020 08:26:53 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id F0F8468B02; Fri, 29 May 2020 14:26:50 +0200 (CEST) Date: Fri, 29 May 2020 14:26:50 +0200 From: Christoph Hellwig To: Keith Busch Cc: Christoph Hellwig , linux-nvme@lists.infradead.org, sagi@grimberg.me, linux-block@vger.kernel.org, axboe@kernel.dk Subject: Re: [PATCHv2 1/2] blk-mq: export __blk_mq_complete_request Message-ID: <20200529122650.GA28107@lst.de> References: <20200528151931.3501506-1-kbusch@kernel.org> <20200528164256.GA25651@lst.de> <20200528181807.GA3504306@dhcp-10-100-145-180.wdl.wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200528181807.GA3504306@dhcp-10-100-145-180.wdl.wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, May 28, 2020 at 11:18:07AM -0700, Keith Busch wrote: > On Thu, May 28, 2020 at 06:42:56PM +0200, Christoph Hellwig wrote: > > I think this needs a better name. > > blk_mq_do_complete_req()? do isn't exactly descriptive, is it? blk_mq_force_complete_request maybe? And yes, I think for 5.9 we need to lift the error injection into the callers, this is a mess.. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD9BC433DF for ; Fri, 29 May 2020 12:27:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DFBB2075A for ; Fri, 29 May 2020 12:27:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QSIHLrwa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DFBB2075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xLNE5uKdEsp2hBt9+js4Bn+ZQqiefL+p66uk5Lml7/8=; b=QSIHLrwaOxjPqR jp8+fngZfxuJIAFuoQlw26SlQhmstim88WsqVO+eTcdyogJ5IOKpDn97chHsAXo+wXt+fPNJXVtwM 7FFDAKIlaxDiZX/uo/AnT2LDQDdZgf9c9PfHfGEgQtxHw0BYLV1Ymeg7TToF0N5v6yTiqKoYXqKdK lCO6Gx6d88J0R5j4hcFDKwV2ySoFC+2GXF7BSMgn76c32FVGHgLg2Kd4AAmsme09Kc0ftgJ3COFBF jnKEWZL7/wpK/i01nlt3acP05aAiqx+kj/MylVX1eRhHmuz/P85izr0YYG/2KU7ompA7z4OngGUv+ o6gfURfFv1gcbBdHIo/w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jee6I-0001sh-Hm; Fri, 29 May 2020 12:27:02 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jee6F-0001rl-Gl for linux-nvme@lists.infradead.org; Fri, 29 May 2020 12:27:01 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id F0F8468B02; Fri, 29 May 2020 14:26:50 +0200 (CEST) Date: Fri, 29 May 2020 14:26:50 +0200 From: Christoph Hellwig To: Keith Busch Subject: Re: [PATCHv2 1/2] blk-mq: export __blk_mq_complete_request Message-ID: <20200529122650.GA28107@lst.de> References: <20200528151931.3501506-1-kbusch@kernel.org> <20200528164256.GA25651@lst.de> <20200528181807.GA3504306@dhcp-10-100-145-180.wdl.wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200528181807.GA3504306@dhcp-10-100-145-180.wdl.wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200529_052659_724515_88DA28B8 X-CRM114-Status: UNSURE ( 8.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-block@vger.kernel.org, axboe@kernel.dk, Christoph Hellwig , linux-nvme@lists.infradead.org, sagi@grimberg.me Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, May 28, 2020 at 11:18:07AM -0700, Keith Busch wrote: > On Thu, May 28, 2020 at 06:42:56PM +0200, Christoph Hellwig wrote: > > I think this needs a better name. > > blk_mq_do_complete_req()? do isn't exactly descriptive, is it? blk_mq_force_complete_request maybe? And yes, I think for 5.9 we need to lift the error injection into the callers, this is a mess.. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme