From: Ilya Dryomov <idryomov@gmail.com>
To: ceph-devel@vger.kernel.org
Cc: Jeff Layton <jlayton@kernel.org>
Subject: [PATCH 5/5] libceph: read_policy option
Date: Fri, 29 May 2020 17:19:52 +0200 [thread overview]
Message-ID: <20200529151952.15184-6-idryomov@gmail.com> (raw)
In-Reply-To: <20200529151952.15184-1-idryomov@gmail.com>
Expose balanced and localized reads through read_policy=balance
and read_policy=localize. The default is to read from primary.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
---
include/linux/ceph/libceph.h | 2 ++
net/ceph/ceph_common.c | 26 ++++++++++++++++++++++++++
net/ceph/osd_client.c | 5 ++++-
3 files changed, 32 insertions(+), 1 deletion(-)
diff --git a/include/linux/ceph/libceph.h b/include/linux/ceph/libceph.h
index 4733959f1ec7..0a9f807ceda6 100644
--- a/include/linux/ceph/libceph.h
+++ b/include/linux/ceph/libceph.h
@@ -52,6 +52,8 @@ struct ceph_options {
unsigned long osd_idle_ttl; /* jiffies */
unsigned long osd_keepalive_timeout; /* jiffies */
unsigned long osd_request_timeout; /* jiffies */
+ unsigned int osd_req_flags; /* CEPH_OSD_FLAG_*, applied to
+ each OSD request */
/*
* any type that can't be simply compared or doesn't need
diff --git a/net/ceph/ceph_common.c b/net/ceph/ceph_common.c
index 6d495685ee03..1a834cb0d04d 100644
--- a/net/ceph/ceph_common.c
+++ b/net/ceph/ceph_common.c
@@ -265,6 +265,7 @@ enum {
Opt_key,
Opt_ip,
Opt_crush_location,
+ Opt_read_policy,
/* string args above */
Opt_share,
Opt_crc,
@@ -274,6 +275,17 @@ enum {
Opt_abort_on_full,
};
+enum {
+ Opt_read_policy_balance,
+ Opt_read_policy_localize,
+};
+
+static const struct constant_table ceph_param_read_policy[] = {
+ {"balance", Opt_read_policy_balance},
+ {"localize", Opt_read_policy_localize},
+ {}
+};
+
static const struct fs_parameter_spec ceph_parameters[] = {
fsparam_flag ("abort_on_full", Opt_abort_on_full),
fsparam_flag_no ("cephx_require_signatures", Opt_cephx_require_signatures),
@@ -290,6 +302,8 @@ static const struct fs_parameter_spec ceph_parameters[] = {
fsparam_u32 ("osdkeepalive", Opt_osdkeepalivetimeout),
__fsparam (fs_param_is_s32, "osdtimeout", Opt_osdtimeout,
fs_param_deprecated, NULL),
+ fsparam_enum ("read_policy", Opt_read_policy,
+ ceph_param_read_policy),
fsparam_string ("secret", Opt_secret),
fsparam_flag_no ("share", Opt_share),
fsparam_flag_no ("tcp_nodelay", Opt_tcp_nodelay),
@@ -470,6 +484,18 @@ int ceph_parse_param(struct fs_parameter *param, struct ceph_options *opt,
return err;
}
break;
+ case Opt_read_policy:
+ switch (result.uint_32) {
+ case Opt_read_policy_balance:
+ opt->osd_req_flags |= CEPH_OSD_FLAG_BALANCE_READS;
+ break;
+ case Opt_read_policy_localize:
+ opt->osd_req_flags |= CEPH_OSD_FLAG_LOCALIZE_READS;
+ break;
+ default:
+ BUG();
+ }
+ break;
case Opt_osdtimeout:
warn_plog(&log, "Ignoring osdtimeout");
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
index 15c3afa8089b..da7046db9fbe 100644
--- a/net/ceph/osd_client.c
+++ b/net/ceph/osd_client.c
@@ -2425,11 +2425,14 @@ static void __submit_request(struct ceph_osd_request *req, bool wrlocked)
static void account_request(struct ceph_osd_request *req)
{
+ struct ceph_osd_client *osdc = req->r_osdc;
+
WARN_ON(req->r_flags & (CEPH_OSD_FLAG_ACK | CEPH_OSD_FLAG_ONDISK));
WARN_ON(!(req->r_flags & (CEPH_OSD_FLAG_READ | CEPH_OSD_FLAG_WRITE)));
req->r_flags |= CEPH_OSD_FLAG_ONDISK;
- atomic_inc(&req->r_osdc->num_requests);
+ req->r_flags |= osdc->client->options->osd_req_flags;
+ atomic_inc(&osdc->num_requests);
req->r_start_stamp = jiffies;
req->r_start_latency = ktime_get();
--
2.19.2
next prev parent reply other threads:[~2020-05-29 15:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 15:19 [PATCH 0/5] libceph: support for replica reads Ilya Dryomov
2020-05-29 15:19 ` [PATCH 1/5] libceph: add non-asserting rbtree insertion helper Ilya Dryomov
2020-05-29 15:19 ` [PATCH 2/5] libceph: decode CRUSH device/bucket types and names Ilya Dryomov
2020-05-29 15:19 ` [PATCH 3/5] libceph: crush_location infrastructure Ilya Dryomov
2020-05-29 17:27 ` Jeff Layton
2020-05-29 18:38 ` Ilya Dryomov
2020-05-29 19:10 ` Jeff Layton
2020-05-29 20:42 ` Ilya Dryomov
2020-05-30 15:47 ` Ilya Dryomov
2020-05-29 15:19 ` [PATCH 4/5] libceph: support for balanced and localized reads Ilya Dryomov
2020-05-29 15:19 ` Ilya Dryomov [this message]
2020-05-29 17:19 ` [PATCH 5/5] libceph: read_policy option Jeff Layton
2020-05-29 18:42 ` Ilya Dryomov
[not found] ` <CA+aFP1D_povJnBfH5pT8E7OVK_WHWa0TtBwRCxB=OmscTjGf8Q@mail.gmail.com>
2020-05-29 17:21 ` [PATCH 0/5] libceph: support for replica reads Ilya Dryomov
2020-05-29 17:25 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529151952.15184-6-idryomov@gmail.com \
--to=idryomov@gmail.com \
--cc=ceph-devel@vger.kernel.org \
--cc=jlayton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.