From: Andrew Lunn <andrew@lunn.ch>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Thomas Bogendoerfer <tbogendoerfer@suse.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports
Date: Fri, 29 May 2020 18:25:04 +0200 [thread overview]
Message-ID: <20200529162504.GH869823@lunn.ch> (raw)
In-Reply-To: <20200529155121.GA1551@shell.armlinux.org.uk>
> I wonder how much risk there is to changing that, so we force the link
> down if phylink says the link should be down, otherwise we force the
> speed/duplex, disable AN, and allow the link to come up depending on
> the serdes status. It /sounds/ like something sane to do.
Hi Russell
I actually did this for mv88e6xxx in a patchset for ZII devel B. It
was determining link based on SFP LOS, which we know is unreliable. It
said there was link even when the SERDES had lost link.
I did it by making use of the fixed-link state call back, since it was
a quick and dirty patch. But it might make more sense for the MAC to
call phylink_mac_change() for change in PCS state? Or add a PCS
specific.
Andrew
next prev parent reply other threads:[~2020-05-29 16:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 12:11 [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports Thomas Bogendoerfer
2020-05-28 13:07 ` Russell King - ARM Linux admin
2020-05-28 13:17 ` Thomas Bogendoerfer
2020-05-28 13:56 ` Russell King - ARM Linux admin
2020-05-28 14:33 ` Thomas Bogendoerfer
2020-05-28 14:48 ` Russell King - ARM Linux admin
2020-05-28 18:43 ` Thomas Bogendoerfer
2020-05-28 20:15 ` Andrew Lunn
2020-05-28 22:04 ` Russell King - ARM Linux admin
2020-05-29 11:05 ` Thomas Bogendoerfer
2020-05-29 14:59 ` Andrew Lunn
2020-05-29 15:51 ` Russell King - ARM Linux admin
2020-05-29 16:25 ` Andrew Lunn [this message]
2020-05-29 17:02 ` Russell King - ARM Linux admin
2020-05-29 15:52 ` Thomas Bogendoerfer
2020-05-29 16:33 ` Andrew Lunn
2020-06-02 8:08 ` Thomas Bogendoerfer
2020-06-02 22:50 ` Russell King - ARM Linux admin
2020-06-03 12:31 ` Russell King - ARM Linux admin
2020-06-03 13:21 ` Andrew Lunn
2020-06-03 14:58 ` Russell King - ARM Linux admin
2020-05-28 16:33 ` Andrew Lunn
2020-05-28 18:43 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529162504.GH869823@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=tbogendoerfer@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.