From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Hu Jiahui <kirin.say@gmail.com>,
Eric Dumazet <edumazet@google.com>,
security@kernel.org, linux-wireless@vger.kernel.org,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v3] airo: Fix read overflows sending packets
Date: Fri, 29 May 2020 17:40:38 +0000 (UTC) [thread overview]
Message-ID: <20200529174038.6EC21C433C6@smtp.codeaurora.org> (raw)
In-Reply-To: <20200527184830.GA1164846@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The problem is that we always copy a minimum of ETH_ZLEN (60) bytes from
> skb->data even when skb->len is less than ETH_ZLEN so it leads to a read
> overflow.
>
> The fix is to pad skb->data to at least ETH_ZLEN bytes.
>
> Cc: <stable@vger.kernel.org>
> Reported-by: Hu Jiahui <kirin.say@gmail.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
Patch applied to wireless-drivers-next.git, thanks.
11e7a91994c2 airo: Fix read overflows sending packets
--
https://patchwork.kernel.org/patch/11573765/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-05-29 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <EED43E20-9B88-42EC-80B0-0245F0FAF980@gmail.com>
2020-05-27 13:36 ` [PATCH resend] airo: Fix read overflow in mpi_send_packet() Dan Carpenter
2020-05-27 16:52 ` Eric Dumazet
2020-05-27 17:58 ` [PATCH v2] airo: Fix read overflows sending packets Dan Carpenter
2020-05-27 18:08 ` Eric Dumazet
2020-05-27 18:48 ` [PATCH v3] " Dan Carpenter
2020-05-28 14:41 ` Sasha Levin
2020-05-28 15:55 ` Eric Dumazet
2020-05-29 17:40 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529174038.6EC21C433C6@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=edumazet@google.com \
--cc=kirin.say@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.