From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Serge Semin <fancer.lancer@gmail.com>, linux-spi@vger.kernel.org
Subject: Re: [PATCH v2 1/2] spi: dw: Make DMA request line assignments explicit for Intel Medfield
Date: Fri, 29 May 2020 20:52:43 +0100 [thread overview]
Message-ID: <20200529195243.GV4610@sirena.org.uk> (raw)
In-Reply-To: <20200529184955.GY1634618@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
On Fri, May 29, 2020 at 09:49:55PM +0300, Andy Shevchenko wrote:
> On Fri, May 29, 2020 at 09:40:50PM +0300, Serge Semin wrote:
> > > - struct dw_dma_slave slave = {
> > > - .src_id = 0,
> > > - .dst_id = 0
> > > - };
> > > + struct dw_dma_slave dma_tx = { .dst_id = 1 }, *tx = &dma_tx;
> > > + struct dw_dma_slave dma_rx = { .src_id = 0 }, *rx = &dma_rx;
> > You know my attitude to these changes.) But anyway what's the point in having
> > the *tx and *rx pointers here? Without any harm to the readability you can use
> > the structures names directly, don't you?
> I will wait for Mark to decide.
Like I said before I don't particularly care either way, I've queued the
patch to apply but really I'd rather that the people working on the
driver could come to some sort of agreement here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-05-29 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 18:31 [PATCH v2 1/2] spi: dw: Make DMA request line assignments explicit for Intel Medfield Andy Shevchenko
2020-05-29 18:31 ` [PATCH v2 2/2] spi: dw: Refactor mid_spi_dma_setup() to separate DMA and IRQ config Andy Shevchenko
2020-05-29 18:40 ` [PATCH v2 1/2] spi: dw: Make DMA request line assignments explicit for Intel Medfield Serge Semin
2020-05-29 18:49 ` Andy Shevchenko
2020-05-29 19:04 ` Serge Semin
2020-05-29 19:21 ` Andy Shevchenko
2020-05-29 19:52 ` Mark Brown [this message]
2020-06-01 12:00 ` Serge Semin
2020-05-29 21:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529195243.GV4610@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=fancer.lancer@gmail.com \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.