From: Kees Cook <keescook@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kees Cook <keescook@chromium.org>,
Prasad Sodagudi <psodagud@codeaurora.org>,
Sami Tolvanen <samitolvanen@google.com>,
Amit Daniel Kachhap <amit.kachhap@arm.com>,
linux-kselftest@vger.kernel.org,
clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] selftests/lkdtm: Reset WARN_ONCE to avoid false negatives
Date: Fri, 29 May 2020 13:03:46 -0700 [thread overview]
Message-ID: <20200529200347.2464284-4-keescook@chromium.org> (raw)
In-Reply-To: <20200529200347.2464284-1-keescook@chromium.org>
Since we expect to see warnings every time for many tests, just reset
the WARN_ONCE flags each time the script runs.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
tools/testing/selftests/lkdtm/run.sh | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tools/testing/selftests/lkdtm/run.sh b/tools/testing/selftests/lkdtm/run.sh
index ee64ff8df8f4..8383eb89d88a 100755
--- a/tools/testing/selftests/lkdtm/run.sh
+++ b/tools/testing/selftests/lkdtm/run.sh
@@ -8,6 +8,7 @@
#
set -e
TRIGGER=/sys/kernel/debug/provoke-crash/DIRECT
+CLEAR_ONCE=/sys/kernel/debug/clear_warn_once
KSELFTEST_SKIP_TEST=4
# Verify we have LKDTM available in the kernel.
@@ -67,6 +68,11 @@ cleanup() {
}
trap cleanup EXIT
+# Reset WARN_ONCE counters so we trip it each time this runs.
+if [ -w $CLEAR_ONCE ] ; then
+ echo 1 > $CLEAR_ONCE
+fi
+
# Save existing dmesg so we can detect new content below
dmesg > "$DMESG"
--
2.25.1
next prev parent reply other threads:[~2020-05-29 20:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 20:03 [PATCH drivers/misc 0/4] lkdtm: Various clean ups Kees Cook
2020-05-29 20:03 ` [PATCH 1/4] lkdtm: Avoid more compiler optimizations for bad writes Kees Cook
2020-05-29 20:10 ` Nick Desaulniers
2020-05-29 20:03 ` [PATCH 2/4] lkdtm/heap: Avoid edge and middle of slabs Kees Cook
2020-05-29 20:03 ` Kees Cook [this message]
2020-05-29 20:22 ` [PATCH 3/4] selftests/lkdtm: Reset WARN_ONCE to avoid false negatives Shuah Khan
2020-05-29 20:03 ` [PATCH 4/4] lkdtm: Make arch-specific tests always available Kees Cook
2020-06-23 23:10 ` [PATCH drivers/misc 0/4] lkdtm: Various clean ups Kees Cook
2020-06-23 23:32 ` Randy Dunlap
2020-06-24 0:01 ` Kees Cook
2020-06-24 7:23 ` Richard Weinberger
2020-06-24 20:36 ` Kees Cook
2020-06-24 21:29 ` Randy Dunlap
2020-06-24 22:01 ` Richard Weinberger
2020-06-24 22:23 ` Randy Dunlap
2020-06-24 22:35 ` Randy Dunlap
2020-06-25 1:45 ` Randy Dunlap
2020-06-25 6:06 ` Kees Cook
2020-06-25 6:24 ` Richard Weinberger
2020-06-25 15:24 ` Randy Dunlap
2020-06-24 6:13 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529200347.2464284-4-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=amit.kachhap@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=psodagud@codeaurora.org \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.