From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")
Date: Fri, 29 May 2020 23:58:01 +0100 [thread overview]
Message-ID: <20200529225801.szl4obsas6ndilz4@srcf.ucam.org> (raw)
In-Reply-To: <824d63d8-668c-22c8-a303-b44e30e805e1@gmail.com>
On Sat, May 30, 2020 at 12:26:17AM +0200, Heiner Kallweit wrote:
> Current situation means that PME is unusable on all systems where
> pcie_aspm_support_enabled() returns false, what is basically every
> system except EXPERT mode is enabled and CONFIG_PCIEASPM is set.
> So we definitely need to do something.
CONFIG_PCIEASPM is default y. I don't think there's huge value in
adding complexity to deal with it being disabled, given that the kernel
is then in a configuration that no vendor is testing against. There are
existing runtime mechanisms to disable it at runtime.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2020-05-29 22:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 21:44 Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default") Heiner Kallweit
2020-05-29 18:50 ` Heiner Kallweit
2020-05-29 19:21 ` Bjorn Helgaas
2020-05-29 19:40 ` Heiner Kallweit
2020-05-29 20:09 ` Heiner Kallweit
2020-05-29 20:21 ` Bjorn Helgaas
2020-05-29 20:53 ` Heiner Kallweit
2020-05-29 20:59 ` Matthew Garrett
2020-05-29 22:26 ` Heiner Kallweit
2020-05-29 22:58 ` Matthew Garrett [this message]
2020-05-30 6:33 ` Heiner Kallweit
2020-05-30 7:14 ` Matthew Garrett
2020-05-30 11:33 ` Christoph Hellwig
2020-06-01 10:58 ` Rafael J. Wysocki
2020-06-01 15:13 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529225801.szl4obsas6ndilz4@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.