From: Andrew Lunn <andrew@lunn.ch>
To: Vadym Kochan <vadym.kochan@plvision.eu>
Cc: David Miller <davem@davemloft.net>,
kuba@kernel.org, jiri@mellanox.com, idosch@mellanox.com,
oleksandr.mazur@plvision.eu, serhiy.boiko@plvision.eu,
serhiy.pshyk@plvision.eu, volodymyr.mytnyk@plvision.eu,
taras.chornyi@plvision.eu, andrii.savka@plvision.eu,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
mickeyr@marvell.com
Subject: Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices
Date: Sat, 30 May 2020 04:20:22 +0200 [thread overview]
Message-ID: <20200530022022.GI877847@lunn.ch> (raw)
In-Reply-To: <20200530004622.GA19411@plvision.eu>
On Sat, May 30, 2020 at 03:46:22AM +0300, Vadym Kochan wrote:
> Hi David,
>
> On Fri, May 29, 2020 at 05:18:39PM -0700, David Miller wrote:
> >
> > Please remove all of the __packed attributes.
> >
> > I looked at your data structures and all of them use fixed sized types
> > and are multiples of 4 so the __packed attribute is completely
> > unnecessary.
> >
> > The alignment attribute is also unnecessary so please remove that too.
>
> Some of the fields are u8, so I assume there might be holes added by
> the compiler ? Also these attributes guarantee some ABI compatibility
> with FW side, I will try to remove them and check but it sounds for me a bit
> risky.
Hi Vadym
You might want to play with pahole(1).
Andrew
next prev parent reply other threads:[~2020-05-30 2:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 15:12 [net-next 0/6] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX326x (AC3x) Vadym Kochan
2020-05-28 15:12 ` [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices Vadym Kochan
2020-05-30 0:18 ` David Miller
2020-05-30 0:46 ` Vadym Kochan
2020-05-30 2:20 ` Andrew Lunn [this message]
2020-05-30 15:48 ` Ido Schimmel
2020-06-01 10:50 ` Vadym Kochan
2020-06-03 9:23 ` Ido Schimmel
2020-06-20 12:56 ` Vadym Kochan
2020-06-21 8:57 ` Ido Schimmel
2020-06-03 14:16 ` Jiri Pirko
2020-06-10 13:41 ` Vadym Kochan
2020-06-03 14:29 ` Jiri Pirko
2020-06-03 14:36 ` Jiri Pirko
2020-05-28 15:12 ` [net-next 2/6] net: marvell: prestera: Add PCI interface support Vadym Kochan
2020-06-03 9:59 ` Ido Schimmel
2020-05-28 15:12 ` [net-next 3/6] net: marvell: prestera: Add basic devlink support Vadym Kochan
2020-06-03 10:07 ` Ido Schimmel
2020-06-03 14:36 ` Jiri Pirko
2020-05-28 15:12 ` [net-next 4/6] net: marvell: prestera: Add ethtool interface support Vadym Kochan
2020-05-28 15:12 ` [net-next 5/6] net: marvell: prestera: Add Switchdev driver implementation Vadym Kochan
2020-05-28 15:12 ` [net-next 6/6] dt-bindings: marvell,prestera: Add description for device-tree bindings Vadym Kochan
2020-05-30 14:29 ` [net-next 0/6] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX326x (AC3x) Ido Schimmel
2020-05-30 14:52 ` Vadym Kochan
2020-05-30 15:54 ` Ido Schimmel
2020-06-01 6:24 ` Jiri Pirko
2020-06-20 13:25 ` Vadym Kochan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200530022022.GI877847@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrii.savka@plvision.eu \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mickeyr@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=oleksandr.mazur@plvision.eu \
--cc=serhiy.boiko@plvision.eu \
--cc=serhiy.pshyk@plvision.eu \
--cc=taras.chornyi@plvision.eu \
--cc=vadym.kochan@plvision.eu \
--cc=volodymyr.mytnyk@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.