All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [linux-next:master 6671/14131] drivers/net/dsa/sja1105/sja1105_vl.c:238:5: warning: no previous prototype for function 'sja1105_vl_redirect'
Date: Sat, 30 May 2020 03:39:40 +0800	[thread overview]
Message-ID: <202005300337.X1IWFUAh%lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3788 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: dfacc5a23e227cabdff41b6202f510398e90d36b [6671/14131] net: dsa: sja1105: support flow-based redirection via virtual links
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2d068e534f1671459e1b135852c1b3c10502e929)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        git checkout dfacc5a23e227cabdff41b6202f510398e90d36b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/net/dsa/sja1105/sja1105_vl.c:238:5: warning: no previous prototype for function 'sja1105_vl_redirect' [-Wmissing-prototypes]
int sja1105_vl_redirect(struct sja1105_private *priv, int port,
^
drivers/net/dsa/sja1105/sja1105_vl.c:238:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int sja1105_vl_redirect(struct sja1105_private *priv, int port,
^
static
>> drivers/net/dsa/sja1105/sja1105_vl.c:286:5: warning: no previous prototype for function 'sja1105_vl_delete' [-Wmissing-prototypes]
int sja1105_vl_delete(struct sja1105_private *priv, int port,
^
drivers/net/dsa/sja1105/sja1105_vl.c:286:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int sja1105_vl_delete(struct sja1105_private *priv, int port,
^
static
2 warnings generated.

vim +/sja1105_vl_redirect +238 drivers/net/dsa/sja1105/sja1105_vl.c

   237	
 > 238	int sja1105_vl_redirect(struct sja1105_private *priv, int port,
   239				struct netlink_ext_ack *extack, unsigned long cookie,
   240				struct sja1105_key *key, unsigned long destports,
   241				bool append)
   242	{
   243		struct sja1105_rule *rule = sja1105_rule_find(priv, cookie);
   244		int rc;
   245	
   246		if (dsa_port_is_vlan_filtering(dsa_to_port(priv->ds, port)) &&
   247		    key->type != SJA1105_KEY_VLAN_AWARE_VL) {
   248			NL_SET_ERR_MSG_MOD(extack,
   249					   "Can only redirect based on {DMAC, VID, PCP}");
   250			return -EOPNOTSUPP;
   251		} else if (key->type != SJA1105_KEY_VLAN_UNAWARE_VL) {
   252			NL_SET_ERR_MSG_MOD(extack,
   253					   "Can only redirect based on DMAC");
   254			return -EOPNOTSUPP;
   255		}
   256	
   257		if (!rule) {
   258			rule = kzalloc(sizeof(*rule), GFP_KERNEL);
   259			if (!rule)
   260				return -ENOMEM;
   261	
   262			rule->cookie = cookie;
   263			rule->type = SJA1105_RULE_VL;
   264			rule->key = *key;
   265			list_add(&rule->list, &priv->flow_block.rules);
   266		}
   267	
   268		rule->port_mask |= BIT(port);
   269		if (append)
   270			rule->vl.destports |= destports;
   271		else
   272			rule->vl.destports = destports;
   273	
   274		rc = sja1105_init_virtual_links(priv, extack);
   275		if (rc) {
   276			rule->port_mask &= ~BIT(port);
   277			if (!rule->port_mask) {
   278				list_del(&rule->list);
   279				kfree(rule);
   280			}
   281		}
   282	
   283		return rc;
   284	}
   285	
 > 286	int sja1105_vl_delete(struct sja1105_private *priv, int port,

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 73556 bytes --]

                 reply	other threads:[~2020-05-29 19:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202005300337.X1IWFUAh%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.