Re: [PATCH v5 4/6] dmaengine: xilinx: dpdma: Add the Xilinx DisplayPort DMA engine driver

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4885 bytes --]

Hi Laurent,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on slave-dma/next linus/master v5.7-rc7 next-20200529]
[cannot apply to xlnx/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Laurent-Pinchart/dma-Add-Xilinx-ZynqMP-DPDMA-driver/20200528-114041
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arc-randconfig-r035-20200531 (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

In file included from include/linux/build_bug.h:5,
from include/linux/bitfield.h:10,
from drivers/dma/xilinx/xilinx_dpdma.c:10:
drivers/dma/xilinx/xilinx_dpdma.c: In function 'xilinx_dpdma_config':
drivers/dma/xilinx/xilinx_dpdma.c:1093:15: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
1093 |  if (chan->id >= ZYNQMP_DPDMA_VIDEO0 && chan->id <= ZYNQMP_DPDMA_VIDEO2)
|               ^~
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
|                                                    ^~~~
>> drivers/dma/xilinx/xilinx_dpdma.c:1093:2: note: in expansion of macro 'if'
1093 |  if (chan->id >= ZYNQMP_DPDMA_VIDEO0 && chan->id <= ZYNQMP_DPDMA_VIDEO2)
|  ^~
drivers/dma/xilinx/xilinx_dpdma.c:1093:15: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
1093 |  if (chan->id >= ZYNQMP_DPDMA_VIDEO0 && chan->id <= ZYNQMP_DPDMA_VIDEO2)
|               ^~
include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
|                                                             ^~~~
>> drivers/dma/xilinx/xilinx_dpdma.c:1093:2: note: in expansion of macro 'if'
1093 |  if (chan->id >= ZYNQMP_DPDMA_VIDEO0 && chan->id <= ZYNQMP_DPDMA_VIDEO2)
|  ^~
drivers/dma/xilinx/xilinx_dpdma.c:1093:15: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
1093 |  if (chan->id >= ZYNQMP_DPDMA_VIDEO0 && chan->id <= ZYNQMP_DPDMA_VIDEO2)
|               ^~
include/linux/compiler.h:69:3: note: in definition of macro '__trace_if_value'
69 |  (cond) ?              |   ^~~~
include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var'
56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
|                            ^~~~~~~~~~~~~~
>> drivers/dma/xilinx/xilinx_dpdma.c:1093:2: note: in expansion of macro 'if'
1093 |  if (chan->id >= ZYNQMP_DPDMA_VIDEO0 && chan->id <= ZYNQMP_DPDMA_VIDEO2)
|  ^~

vim +/if +1093 drivers/dma/xilinx/xilinx_dpdma.c

  1063	
  1064	static int xilinx_dpdma_config(struct dma_chan *dchan,
  1065				       struct dma_slave_config *config)
  1066	{
  1067		struct xilinx_dpdma_chan *chan = to_xilinx_chan(dchan);
  1068		unsigned long flags;
  1069		int ret = 0;
  1070	
  1071		if (config->direction != DMA_MEM_TO_DEV)
  1072			return -EINVAL;
  1073	
  1074		/*
  1075		 * The destination address doesn't need to be specified as the DPDMA is
  1076		 * hardwired to the destination (the DP controller). The transfer
  1077		 * width, burst size and port window size are thus meaningless, they're
  1078		 * fixed both on the DPDMA side and on the DP controller side.
  1079		 */
  1080	
  1081		spin_lock_irqsave(&chan->lock, flags);
  1082	
  1083		/* Can't reconfigure a running channel. */
  1084		if (chan->running) {
  1085			ret = -EBUSY;
  1086			goto unlock;
  1087		}
  1088	
  1089		/*
  1090		 * Abuse the slave_id to indicate that the channel is part of a video
  1091		 * group.
  1092		 */
> 1093		if (chan->id >= ZYNQMP_DPDMA_VIDEO0 && chan->id <= ZYNQMP_DPDMA_VIDEO2)
  1094			chan->video_group = config->slave_id != 0;
  1095	
  1096	unlock:
  1097		spin_unlock_irqrestore(&chan->lock, flags);
  1098	
  1099		return ret;
  1100	}
  1101	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 29476 bytes --]