From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: chemical: atlas-ezo-sensor: move ret variable scope in atlas_ezo_read_raw()
Date: Sun, 31 May 2020 09:36:04 +0100 [thread overview]
Message-ID: <20200531093604.7af8d091@archlinux> (raw)
In-Reply-To: <20200531030208.12167-1-matt.ranostay@konsulko.com>
On Sun, 31 May 2020 06:02:08 +0300
Matt Ranostay <matt.ranostay@konsulko.com> wrote:
> Move ret variable to the IIO_CHAN_INFO_RAW switch since currently
> only used within that scope.
>
> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/chemical/atlas-ezo-sensor.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/chemical/atlas-ezo-sensor.c b/drivers/iio/chemical/atlas-ezo-sensor.c
> index f5a6d8ec6d4d..a94eb8a6bf32 100644
> --- a/drivers/iio/chemical/atlas-ezo-sensor.c
> +++ b/drivers/iio/chemical/atlas-ezo-sensor.c
> @@ -69,13 +69,13 @@ static int atlas_ezo_read_raw(struct iio_dev *indio_dev,
> {
> struct atlas_ezo_data *data = iio_priv(indio_dev);
> struct i2c_client *client = data->client;
> - int ret = 0;
>
> if (chan->type != IIO_CONCENTRATION)
> return -EINVAL;
>
> switch (mask) {
> case IIO_CHAN_INFO_RAW: {
> + int ret;
> long tmp;
>
> mutex_lock(&data->lock);
> @@ -110,7 +110,7 @@ static int atlas_ezo_read_raw(struct iio_dev *indio_dev,
> return IIO_VAL_INT_PLUS_MICRO;
> }
>
> - return ret;
> + return 0;
> }
>
> static const struct iio_info atlas_info = {
prev parent reply other threads:[~2020-05-31 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 3:02 [PATCH] iio: chemical: atlas-ezo-sensor: move ret variable scope in atlas_ezo_read_raw() Matt Ranostay
2020-05-31 8:36 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200531093604.7af8d091@archlinux \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.