Re: [PATCH-for-5.0] gdbstub: Use correct address space with Qqemu.PhyMemMode packet

[Jon Doron <arilou@gmail.com>]

On 31/05/2020, Peter Maydell wrote:
>On Sun, 31 May 2020 at 17:42, Jon Doron <arilou@gmail.com> wrote:
>>
>> On 31/05/2020, Philippe Mathieu-Daudé wrote:
>> >On 3/30/20 6:41 PM, Peter Maydell wrote:
>> >> PS: do we have any documentation of this new command ?
>> >> ab4752ec8d9 has the implementation but no documentation...
>> >
>> >Jon, do you have documentation on the Qqemu.PhyMemMode packet?
>
>> Hi, there is no documentation for this mode, but in general the idea was
>> very simple.
>>
>> I want to have GDB the option to see the physical memory and examine it
>> and have this option toggled.
>>
>> This was useful to me when I was working on nested virtual machine and I
>> wanted to examine different states of the VMCS12 and EPTs.
>>
>> I used this in the following commands:
>> // Enable
>> maint packet Qqemu.PhyMemMode:1
>>
>> // Disable
>> maint packet Qqemu.PhyMemMode:0
>
>docs/system/gdb.rst would be the place to document QEMU-specific
>extensions to the gdb protocol (there's an "advanced debugging
>options" section where we document things like the single-step
>stuff you can also change via 'maint packet').
>
>thanks
>-- PMM

Thanks, I'll know for next time, when I did all that work and 
re-factored gdbstub, that doc did not exist.

Perhaps Peter can just add the documentation to this commit?

-- Jon.