From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD06C433E0 for ; Mon, 1 Jun 2020 09:13:56 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 787FB206E2 for ; Mon, 1 Jun 2020 09:13:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 787FB206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jfgVG-0001KG-RB; Mon, 01 Jun 2020 09:13:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jfgVF-0001KB-9k for xen-devel@lists.xenproject.org; Mon, 01 Jun 2020 09:13:05 +0000 X-Inumbo-ID: 18c47eae-a3e8-11ea-ab03-12813bfff9fa Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 18c47eae-a3e8-11ea-ab03-12813bfff9fa; Mon, 01 Jun 2020 09:13:03 +0000 (UTC) Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: viemTyYNZzVUTDSU1LA4Tvf48+n77yXbjI0CMcFyKg5TBDNA9LGYwIdZRKLCZN2TM6NUDhM3wP FTeQgmOXn7NxK2TVdwBOB1mzuCuS0DywKcIXE8DrWZTyXRN9iwBAqTtPhfYVvHY+1LCSX1tn4i 39nT61HGHrp9rrXvXVFo8f6mQeIEDQLKjhKRi9Rs4KuvZwVQQn+JlZmbHLJDYc5sUQvsh5ugsn YFXP+OLx5nbw7ZWjBQr1qiUBTbODiqxKs9CSfZD6+Ff+TdiM5n2VUlmogBApYLy2k/yWcTCdyX iFE= X-SBRS: 2.7 X-MesageID: 18896880 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,460,1583211600"; d="scan'208";a="18896880" Date: Mon, 1 Jun 2020 11:12:56 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Subject: Re: [PATCH v2 2/3] build32: don't discard .shstrtab in linker script Message-ID: <20200601091256.GR1195@Air-de-Roger> References: <20200528144023.10814-1-roger.pau@citrix.com> <20200528144023.10814-3-roger.pau@citrix.com> <41429ddc-a6c3-ddba-97d6-aeb413df1960@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <41429ddc-a6c3-ddba-97d6-aeb413df1960@suse.com> X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Wei Liu , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, May 29, 2020 at 05:45:44PM +0200, Jan Beulich wrote: > On 28.05.2020 16:40, Roger Pau Monne wrote: > > LLVM linker doesn't support discarding .shstrtab, and complains with: > > > > ld -melf_i386_fbsd -N -T build32.lds -o reloc.lnk reloc.o > > ld: error: discarding .shstrtab section is not allowed > > Well, yes, GNU ld is more intelligent and doesn't extend the > discarding to the control sections in the first place. All > of .symtab, .strtab, and .shstrtab are still there. > > > Add an explicit .shstrtab section to the linker script after the text > > section in order to make LLVM LD happy. > > > > Signed-off-by: Roger Pau Monné > > Assuming the change was tested to not confuse GNU ld > Acked-by: Jan Beulich Yes, it's been tested on the gitlab CI, no issues reported on any of the builds: https://gitlab.com/xen-project/people/royger/xen/pipelines/151009839 > I wouldn't mind extending this to the other two control > sections named above. In case the binaries need picking > apart, them being present is surely helpful. I don't mind extending, it might make sense in case linkers start complaining about trying to discard those too. Thanks, Roger.