From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Mon, 01 Jun 2020 13:56:45 +0000 Subject: Re: [PATCH -next] IB/hfi1: Remove set but not used variable 'priv' Message-Id: <20200601135644.GD4872@ziepe.ca> List-Id: References: <20200528075946.123480-1-yuehaibing@huawei.com> <86634519-3dd8-0c6a-a8d2-19f4b986fd3d@intel.com> In-Reply-To: <86634519-3dd8-0c6a-a8d2-19f4b986fd3d@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dennis Dalessandro Cc: "Marciniszyn, Mike" , YueHaibing , Doug Ledford , "linux-rdma@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , "Dan Carpenter (dan.carpenter@oracle.com)" On Mon, Jun 01, 2020 at 09:45:52AM -0400, Dennis Dalessandro wrote: > On 5/28/2020 7:25 AM, Marciniszyn, Mike wrote: > > > From: YueHaibing > > > Sent: Thursday, May 28, 2020 4:00 AM > > > Signed-off-by: YueHaibing > > > drivers/infiniband/hw/hfi1/netdev_rx.c | 11 +++-------- > > > 1 file changed, 3 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c > > > b/drivers/infiniband/hw/hfi1/netdev_rx.c > > > index 58af6a454761..bd6546b52159 100644 > > > +++ b/drivers/infiniband/hw/hfi1/netdev_rx.c > > > @@ -371,14 +371,9 @@ int hfi1_netdev_alloc(struct hfi1_devdata *dd) > > > > > > void hfi1_netdev_free(struct hfi1_devdata *dd) > > > { > > > -struct hfi1_netdev_priv *priv; > > > - > > > -if (dd->dummy_netdev) { > > > -priv = hfi1_netdev_priv(dd->dummy_netdev); > > > -dd_dev_info(dd, "hfi1 netdev freed\n"); > > > -kfree(dd->dummy_netdev); > > > -dd->dummy_netdev = NULL; > > > -} > > > +dd_dev_info(dd, "hfi1 netdev freed\n"); > > > +kfree(dd->dummy_netdev); > > > > Dan Carpenter has reported kfree() should be free_netdev()... > > > > Mike > > > > I'm OK with this patch going in and then adding a separate one to fix the > kfree. Or this one can be touched up to include that as well. Please resend it with both things fixed Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49617C433DF for ; Mon, 1 Jun 2020 13:56:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FF022077D for ; Mon, 1 Jun 2020 13:56:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="CNZwg+F2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726555AbgFAN4r (ORCPT ); Mon, 1 Jun 2020 09:56:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725976AbgFAN4r (ORCPT ); Mon, 1 Jun 2020 09:56:47 -0400 Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDF46C05BD43 for ; Mon, 1 Jun 2020 06:56:46 -0700 (PDT) Received: by mail-qk1-x741.google.com with SMTP id v79so9022937qkb.10 for ; Mon, 01 Jun 2020 06:56:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ntTQh6WltJCEpegt7h2c57+gIBfSY5EOmHIEsgHmRIU=; b=CNZwg+F26lNY1SXnZVmmSMZ1s3wURI5mydV600unahy2nf+Sq43rl1GEyJ2sG1aE5Y uPKF4mQ7lvFBncydxzKWwkxXxDQ1nc5wt46auLeL+KYtST6DJ7gK9nUm4DS6oWOEOwZG lnWKlgexrnInnplLafYvwuyHLAJ3V00DSDkU1AtgvEf0u9f8eGJELuBolKTi61jtYRjZ GQX+GDBr2EuChpxPCQU3xcoXmDfq3Gj3qp8naHWHOgVbeeNJfF1n8iW0sxVlHkFFDdie 5lhWeWOCWwIA+getqlMHXxUDE9+vLGxNcrco9FlkaeiopKti4FP5+rQVztySlLJ2slOF PPXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ntTQh6WltJCEpegt7h2c57+gIBfSY5EOmHIEsgHmRIU=; b=PCcm0v9aA6sjTF0d9zK1THmaAFA4NcVmWbDUq6RQ9/gdbiTTWZZCVQ2jomMWI3dZ20 /2z5TYftvQDxSCg8wX7gemB06hqQcNlKmOvz77Ph2A1iAxZ2DQ0CtAfjm9GDhZYoLmwM TvIhp5HdlYBMya0xoM+5aQu8+Rw3Pk2uQvneC7mqh+5Qc3+OKUZQr/nvxgVAqQRBUe/F UBzKTTBuR8oYp8+nKKsIZUJEiftd5NJyFAwgE4O6HIytlIhySmBxli1HIHDDJD+PXGV1 6Brd4r0Ga1qjcNOeizBjK1SODnJGkHh/MCkdAb3ivV/wReVv6zIVzewsTaMdwy0zhpCX N7Bw== X-Gm-Message-State: AOAM532BIQwp5wPMPmYrLhBnpSc88wm0SuuKrBGU5nzWxa5/DiSwji+f aDWtN8CfkGRH2CLZB7fHi0aNaQ== X-Google-Smtp-Source: ABdhPJxDT/YlICzGv8LgIeCF6lFgoL6j+xKq2z+DcM5OIioTXwPBgw7wCBUAW/nOX+6QKfh1IlKWxA== X-Received: by 2002:a37:b547:: with SMTP id e68mr2119990qkf.127.1591019806061; Mon, 01 Jun 2020 06:56:46 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id j22sm14545311qke.117.2020.06.01.06.56.45 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Jun 2020 06:56:45 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jfkvl-0004UF-0T; Mon, 01 Jun 2020 10:56:45 -0300 Date: Mon, 1 Jun 2020 10:56:45 -0300 From: Jason Gunthorpe To: Dennis Dalessandro Cc: "Marciniszyn, Mike" , YueHaibing , Doug Ledford , "linux-rdma@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , "Dan Carpenter (dan.carpenter@oracle.com)" Subject: Re: [PATCH -next] IB/hfi1: Remove set but not used variable 'priv' Message-ID: <20200601135644.GD4872@ziepe.ca> References: <20200528075946.123480-1-yuehaibing@huawei.com> <86634519-3dd8-0c6a-a8d2-19f4b986fd3d@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86634519-3dd8-0c6a-a8d2-19f4b986fd3d@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Jun 01, 2020 at 09:45:52AM -0400, Dennis Dalessandro wrote: > On 5/28/2020 7:25 AM, Marciniszyn, Mike wrote: > > > From: YueHaibing > > > Sent: Thursday, May 28, 2020 4:00 AM > > > Signed-off-by: YueHaibing > > > drivers/infiniband/hw/hfi1/netdev_rx.c | 11 +++-------- > > > 1 file changed, 3 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c > > > b/drivers/infiniband/hw/hfi1/netdev_rx.c > > > index 58af6a454761..bd6546b52159 100644 > > > +++ b/drivers/infiniband/hw/hfi1/netdev_rx.c > > > @@ -371,14 +371,9 @@ int hfi1_netdev_alloc(struct hfi1_devdata *dd) > > > > > > void hfi1_netdev_free(struct hfi1_devdata *dd) > > > { > > > -struct hfi1_netdev_priv *priv; > > > - > > > -if (dd->dummy_netdev) { > > > -priv = hfi1_netdev_priv(dd->dummy_netdev); > > > -dd_dev_info(dd, "hfi1 netdev freed\n"); > > > -kfree(dd->dummy_netdev); > > > -dd->dummy_netdev = NULL; > > > -} > > > +dd_dev_info(dd, "hfi1 netdev freed\n"); > > > +kfree(dd->dummy_netdev); > > > > Dan Carpenter has reported kfree() should be free_netdev()... > > > > Mike > > > > I'm OK with this patch going in and then adding a separate one to fix the > kfree. Or this one can be touched up to include that as well. Please resend it with both things fixed Jason