From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03508C433DF for ; Mon, 1 Jun 2020 13:57:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D791F207BC for ; Mon, 1 Jun 2020 13:57:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="OIHcqRFX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726073AbgFAN5Z (ORCPT ); Mon, 1 Jun 2020 09:57:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbgFAN5Z (ORCPT ); Mon, 1 Jun 2020 09:57:25 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3028C05BD43 for ; Mon, 1 Jun 2020 06:57:24 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id c185so9063938qke.7 for ; Mon, 01 Jun 2020 06:57:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=n54U2lwa0cvcl+i8m+i2vrVzdhJrXQ5YxgiDnXtT9Fg=; b=OIHcqRFX3lbedwvIvP1dT4hBezYEDSz1+QQUsDgkB60EPV+Rt1I5zgE4ghfuQ3Vkti IEf+y4xU5Q3CvdEmtvvW0jqX5gT+VFwx3+5jVoppx7N6gQi1LY2hAHBaf/FXnZnPIh0p nEOPvXMj6VVM5KqrHXU50NCLBRJLo7N3tPmbd2Si/nuD0siwTNWJgVfU1w2pRfydGc2a +vh5pvoa3P38eou/a4K+5v/xS2K6VlQ1NeyAGvOm6jb/DPm2TVcEiXz5Ws7cHR5YdHYN TpPN3EVqCoIHwkUva6FXCkk4LGhP2QEvT2pX+kGhyjtB3MpIf7heQ1y/+RaiEGcNFVAu c6NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=n54U2lwa0cvcl+i8m+i2vrVzdhJrXQ5YxgiDnXtT9Fg=; b=jo5pdJq1fJPqXTZKTpFb0pjoVnnfThWeTqzA+SQYmlmyoA5uITkihcTrRrzl3uQS4F alDr1jy7OKGKPwPO2QrgbIHVJSgXtpe8Mag/mOtQuxbg/C9aVIfNdu8sEY0qUfoyig3L 8LaVYyfGPHVR8KMaxkacwpGOwhN7yIz3BfDKz6pqVKSS+ukrdUWy209kE3BP7dH5np9B Osisd3OTGpphKn16ZOr+IFuhzlQ8/SDHxfxh2pVRwHyDkOntG6oWUzxXfHPcOWvLu+UF ABl0KnWNPaheOyfagz+6OcbaQrsy4yXwK6N+puJxDHdydfjG/1ePaUlppn1XLddnQ2uW z4/w== X-Gm-Message-State: AOAM532FQaDiG+y3PnAvR/GNkhU05b3VgG449lALMHp9+sWmKgma+Ur5 0Vi0ZTzqo52npnV1LHplBtw9xQ== X-Google-Smtp-Source: ABdhPJwskiAqvnZjYEPWiNtrbmxDMErZBOfD4F6Y8Oc1vXFvTbDIR11Iq3JNWynIgdxVYZrEAIIRYQ== X-Received: by 2002:a05:620a:8da:: with SMTP id z26mr5615486qkz.461.1591019844160; Mon, 01 Jun 2020 06:57:24 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id v2sm15426016qtq.8.2020.06.01.06.57.23 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Jun 2020 06:57:23 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jfkwM-0004V5-UW; Mon, 01 Jun 2020 10:57:22 -0300 Date: Mon, 1 Jun 2020 10:57:22 -0300 From: Jason Gunthorpe To: Dennis Dalessandro Cc: Nathan Chancellor , dledford@redhat.com, linux-rdma@vger.kernel.org, Mike Marciniszyn , Sadanand Warrier , Kaike Wan Subject: Re: [PATCH v3 for-next 07/16] IB/ipoib: Increase ipoib Datagram mode MTU's upper limit Message-ID: <20200601135722.GE4872@ziepe.ca> References: <20200511155337.173205.77558.stgit@awfm-01.aw.intel.com> <20200511160618.173205.23053.stgit@awfm-01.aw.intel.com> <20200527040350.GA3118979@ubuntu-s3-xlarge-x86> <9e9147ad-6d7c-9381-72f3-dc2f3d0723fd@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9e9147ad-6d7c-9381-72f3-dc2f3d0723fd@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Jun 01, 2020 at 09:48:47AM -0400, Dennis Dalessandro wrote: > They should probably all be in "enum ib_mtu". Jason any issues with us donig > that? I can't for certain recall the real reason they were kept separate in > the first place. It is probably OK Jason