From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAAC8C433E1 for ; Mon, 1 Jun 2020 15:10:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CAAE20738 for ; Mon, 1 Jun 2020 15:10:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GyztyQv9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="c5umpFK/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CAAE20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YhjXUYsP5Zh76i7p/IhrqLD6Ws5iaLxDJs9zCYlLeoU=; b=GyztyQv9Gy4Wca hzRwOH50cnwlRtQwlDLhLm53+Rggb0zyEGsnUmx0tUGTl1DySbJpInAtKeaI0YxYozMpYK5f4ldaF SI7ymo65zUOuESrZSAFUxSbcql2FPJt1NnHsA9kD2mlCxtGdM/w1JKC0v9teLUoAXkDQgvHo1YEiW bhVD01YTLi1n8MZadgb2vZJLacE00qbWCJG8gyGLwrbVTphdMG8M2qBKdVJ/3fXk4u90fc91MlA3y NLjfRJFMzSStrVW7wBqWevIKZ6lzxkHGKY3gQQBO3vhnI+QDa6KNSHS/BMy9GHPX8AuXhVNZy+v/x LAvhwCnYY0kMlPC0nnPQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jfm5Q-0001bk-04; Mon, 01 Jun 2020 15:10:48 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jfm5N-0001bA-4i for linux-arm-kernel@lists.infradead.org; Mon, 01 Jun 2020 15:10:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qyaZKCXXV6sKGAOCvFszwj+5rDsE8vvtfD9Kg6pCq+A=; b=c5umpFK/fS8VKhR9x6DY4E0vg flJd70nTs9XDy8KtVtirXxghIg35XLo+dBzrnlmsZNpsio9sat7SbnsO42zUkpFBo61WErrNq6GT0 2saUzmQ36pIRODEsOaOe8zkFpJCWT1yrt66ZvVSm1vBhMrIans7j5DkW0d0ELWP9yq6NxtTuVAAQv B174bdX/GlCgz4gt+kMnJqbFbMIb8xLPnkC9WMBK/nxUmG+7ZMS9CGou4pK8fOEC1+GGwVhXvU+gk JsQtVuUZqc3KuBfqcoTuoFnP9/4eUFI8qtG0q+w9ydvAScv+YYIeQYY6TAYtfkJkrFtcd9VdQvD+d gwf/+FRKA==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:37552) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfm5A-0000d5-4q; Mon, 01 Jun 2020 16:10:32 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jfm59-0003Q9-Gu; Mon, 01 Jun 2020 16:10:31 +0100 Date: Mon, 1 Jun 2020 16:10:31 +0100 From: Russell King - ARM Linux admin To: Lukasz Stelmach Subject: Re: [PATCH 1/5] arm: decompressor: set malloc pool size for the decompressor Message-ID: <20200601151031.GM1551@shell.armlinux.org.uk> References: <20200601144607.GI1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200601_081045_186836_8D468368 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Bartlomiej Zolnierkiewicz , Masahiro Yamada , Nick Desaulniers , linux-kernel@vger.kernel.org, AKASHI Takahiro , Ben Dooks , Thomas Gleixner , Enrico Weigelt , Ingo Molnar , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdW4gMDEsIDIwMjAgYXQgMDQ6NTY6NDBQTSArMDIwMCwgTHVrYXN6IFN0ZWxtYWNo IHdyb3RlOgo+IEl0IHdhcyA8MjAyMC0wNi0wMSBwb24gMTU6NDY+LCB3aGVuIFJ1c3NlbGwgS2lu ZyAtIEFSTSBMaW51eCBhZG1pbiB3cm90ZToKPiA+IE9uIE1vbiwgSnVuIDAxLCAyMDIwIGF0IDA0 OjI3OjUwUE0gKzAyMDAsIMWBdWthc3ogU3RlbG1hY2ggd3JvdGU6Cj4gPj4gTW92ZSB0aGUgZGVm aW5pdGlvbiBvZiBtYWxsb2MgcG9vbCBzaXplIG9mIHRoZSBkZWNvbXByZXNzb3IgdG8KPiA+PiBh IHNpbmdsZSBwbGFjZS4gVGhpcyB2YWx1ZSB3aWxsIGJlIGV4cG9zZWQgbGF0ZXIgZm9yIGtleGVj X2ZpbGUgbG9hZGVyLgo+ID4+IAo+ID4+IFNpZ25lZC1vZmYtYnk6IMWBdWthc3ogU3RlbG1hY2gg PGwuc3RlbG1hY2hAc2Ftc3VuZy5jb20+Cj4gPj4gLS0tCj4gPj4gIGFyY2gvYXJtL2Jvb3QvY29t cHJlc3NlZC9NYWtlZmlsZSB8IDIgKysKPiA+PiAgYXJjaC9hcm0vYm9vdC9jb21wcmVzc2VkL2hl YWQuUyAgIHwgNiArKysrLS0KPiA+PiAgMiBmaWxlcyBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyks IDIgZGVsZXRpb25zKC0pCj4gPj4gCj4gPj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvY29t cHJlc3NlZC9NYWtlZmlsZSBiL2FyY2gvYXJtL2Jvb3QvY29tcHJlc3NlZC9NYWtlZmlsZQo+ID4+ IGluZGV4IDljMTFlNzQ5MDI5Mi4uYjM1OTRjZDE1ODhjIDEwMDY0NAo+ID4+IC0tLSBhL2FyY2gv YXJtL2Jvb3QvY29tcHJlc3NlZC9NYWtlZmlsZQo+ID4+ICsrKyBiL2FyY2gvYXJtL2Jvb3QvY29t cHJlc3NlZC9NYWtlZmlsZQo+ID4+IEBAIC0xMjUsNiArMTI1LDggQEAgS0JTU19TWiA9ICQoc2hl bGwgZWNobyAkJCgoJCQoJChOTSkgJChvYmopLy4uLy4uLy4uLy4uL3ZtbGludXggfCBcCj4gPj4g IAkJc2VkIC1uIC1lICdzL15cKFteIF0qXCkgW0FCXSBfX2Jzc19zdGFydCQkLy0weFwxL3AnIFwK PiA+PiAgCQkgICAgICAgLWUgJ3MvXlwoW14gXSpcKSBbQUJdIF9fYnNzX3N0b3AkJC8rMHhcMS9w JykgKSkgKQo+ID4+ICBMREZMQUdTX3ZtbGludXggPSAtLWRlZnN5bSBfa2VybmVsX2Jzc19zaXpl PSQoS0JTU19TWikKPiA+PiArIyBtYWxsb2MgcG9vbCBzaXplCj4gPj4gK0xERkxBR1Nfdm1saW51 eCArPSAtLWRlZnN5bSBfbWFsbG9jX3NpemU9MHgxMDAwMAo+ID4+ICAjIFN1cHBseSBaUkVMQURE UiB0byB0aGUgZGVjb21wcmVzc29yIHZpYSBhIGxpbmtlciBzeW1ib2wuCj4gPj4gIGlmbmVxICgk KENPTkZJR19BVVRPX1pSRUxBRERSKSx5KQo+ID4+ICBMREZMQUdTX3ZtbGludXggKz0gLS1kZWZz eW0genJlbGFkZHI9JChaUkVMQUREUikKPiA+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9j b21wcmVzc2VkL2hlYWQuUyBiL2FyY2gvYXJtL2Jvb3QvY29tcHJlc3NlZC9oZWFkLlMKPiA+PiBp bmRleCBlOGUxYzg2NmU0MTMuLmRjYzFhZmE2MGZiOSAxMDA2NDQKPiA+PiAtLS0gYS9hcmNoL2Fy bS9ib290L2NvbXByZXNzZWQvaGVhZC5TCj4gPj4gKysrIGIvYXJjaC9hcm0vYm9vdC9jb21wcmVz c2VkL2hlYWQuUwo+ID4+IEBAIC0zMDksNyArMzA5LDggQEAgcmVzdGFydDoJYWRyCXIwLCBMQzAK PiA+PiAgI2lmbmRlZiBDT05GSUdfWkJPT1RfUk9NCj4gPj4gIAkJLyogbWFsbG9jIHNwYWNlIGlz IGFib3ZlIHRoZSByZWxvY2F0ZWQgc3RhY2sgKDY0ayBtYXgpICovCj4gPj4gIAkJYWRkCXNwLCBz cCwgcjAKPiA+PiAtCQlhZGQJcjEwLCBzcCwgIzB4MTAwMDAKPiA+PiArCQlsZHIJcjEwLCA9X21h bGxvY19zaXplCj4gPj4gKwkJYWRkCXIxMCwgcjEwLCBzcAo+ID4KPiA+IFRoaXMgc2F5cyAibG9j YXRlIF9tYWxsb2Nfc2l6ZSBpbiBhIGxpdGVyYWwgcG9vbCBzb21ld2hlcmUsIGFuZCBsb2FkIGl0 Cj4gPiB1c2luZyBhIFBDLXJlbGF0aXZlIG9mZnNldCIuICBBcmUgeW91IHN1cmUgdGhhdCB0aGUg bGl0ZXJhbCBwb29sIGlzCj4gPiBzZW5zaWJseSBsb2NhdGVkPwo+ID4KPiA+IFdvdWxkIGl0IGJl IGJldHRlciB0byB1c2UgYSBkZWZpbml0aW9uIGZvciB0aGlzPwo+IAo+IEkndmUgZm9sbG93ZWQg WlJFTEFERFIgd2F5LiBJIHRoaW5rIGJvdGggdmFsdWVzIHNob3VsZCBiZSBoYW5kbGVkIHRoZQo+ IHNhbWUgd2F5IChpdCBtYWtlcyBpdCBlYXNpZXIgdG8gY29tcHJlaGVuZCBJTUhPKS4gSXMgdGhl cmUgYW55IHJlYXNvbgo+IG5vdCB0bz8gIFNob3VsZCBJIGNoYW5nZSBaUkVMQUREUiBmb3IgdjIg dG9vPwoKVGhlcmUncyBhIGdvb2QgcmVhc29uLiAgWlJFTEFERFIgY2FuIGJlIGEgY29uc3RhbnQg dGhhdCBkb2VzIG5vdCBmaXQKaW50byB0aGUgQVJNcyBpbW1lZGlhdGUgY29uc3RhbnRzICg4IGJp dHMgb2Ygc2lnbmlmaWNhbnQgZGF0YSBwbHVzCmEgbXVsdGlwbGUgb2YgYSAyLWJpdCBzaGlmdCks IHdoZXJlYXMgdGhlIHNpemUgb2YgdGhlIG1hbGxvYyBzcGFjZQppcyBndWFyYW50ZWVkIHRvIGZp dC4gIFNvLCBaUkVMQUREUiBoYXMgdG8gdXNlIGEgbGl0ZXJhbCBsb2FkLgpUaGlzIGRvZXNuJ3Qu CgotLSAKUk1LJ3MgUGF0Y2ggc3lzdGVtOiBodHRwczovL3d3dy5hcm1saW51eC5vcmcudWsvZGV2 ZWxvcGVyL3BhdGNoZXMvCkZUVEMgZm9yIDAuOG0gKGVzdC4gMTc2Mm0pIGxpbmUgaW4gc3VidXJi aWE6IHN5bmMgYXQgMTMuMU1icHMgZG93biA0MjRrYnBzIHVwCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79776C433E0 for ; Mon, 1 Jun 2020 15:10:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5502920738 for ; Mon, 1 Jun 2020 15:10:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="c5umpFK/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727900AbgFAPKq (ORCPT ); Mon, 1 Jun 2020 11:10:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbgFAPKq (ORCPT ); Mon, 1 Jun 2020 11:10:46 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1554C05BD43 for ; Mon, 1 Jun 2020 08:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qyaZKCXXV6sKGAOCvFszwj+5rDsE8vvtfD9Kg6pCq+A=; b=c5umpFK/fS8VKhR9x6DY4E0vg flJd70nTs9XDy8KtVtirXxghIg35XLo+dBzrnlmsZNpsio9sat7SbnsO42zUkpFBo61WErrNq6GT0 2saUzmQ36pIRODEsOaOe8zkFpJCWT1yrt66ZvVSm1vBhMrIans7j5DkW0d0ELWP9yq6NxtTuVAAQv B174bdX/GlCgz4gt+kMnJqbFbMIb8xLPnkC9WMBK/nxUmG+7ZMS9CGou4pK8fOEC1+GGwVhXvU+gk JsQtVuUZqc3KuBfqcoTuoFnP9/4eUFI8qtG0q+w9ydvAScv+YYIeQYY6TAYtfkJkrFtcd9VdQvD+d gwf/+FRKA==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:37552) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfm5A-0000d5-4q; Mon, 01 Jun 2020 16:10:32 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jfm59-0003Q9-Gu; Mon, 01 Jun 2020 16:10:31 +0100 Date: Mon, 1 Jun 2020 16:10:31 +0100 From: Russell King - ARM Linux admin To: Lukasz Stelmach Cc: Masahiro Yamada , Nick Desaulniers , Thomas Gleixner , Enrico Weigelt , Kees Cook , Ingo Molnar , Ben Dooks , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, AKASHI Takahiro , Bartlomiej Zolnierkiewicz , Marek Szyprowski Subject: Re: [PATCH 1/5] arm: decompressor: set malloc pool size for the decompressor Message-ID: <20200601151031.GM1551@shell.armlinux.org.uk> References: <20200601144607.GI1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 01, 2020 at 04:56:40PM +0200, Lukasz Stelmach wrote: > It was <2020-06-01 pon 15:46>, when Russell King - ARM Linux admin wrote: > > On Mon, Jun 01, 2020 at 04:27:50PM +0200, Łukasz Stelmach wrote: > >> Move the definition of malloc pool size of the decompressor to > >> a single place. This value will be exposed later for kexec_file loader. > >> > >> Signed-off-by: Łukasz Stelmach > >> --- > >> arch/arm/boot/compressed/Makefile | 2 ++ > >> arch/arm/boot/compressed/head.S | 6 ++++-- > >> 2 files changed, 6 insertions(+), 2 deletions(-) > >> > >> diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile > >> index 9c11e7490292..b3594cd1588c 100644 > >> --- a/arch/arm/boot/compressed/Makefile > >> +++ b/arch/arm/boot/compressed/Makefile > >> @@ -125,6 +125,8 @@ KBSS_SZ = $(shell echo $$(($$($(NM) $(obj)/../../../../vmlinux | \ > >> sed -n -e 's/^\([^ ]*\) [AB] __bss_start$$/-0x\1/p' \ > >> -e 's/^\([^ ]*\) [AB] __bss_stop$$/+0x\1/p') )) ) > >> LDFLAGS_vmlinux = --defsym _kernel_bss_size=$(KBSS_SZ) > >> +# malloc pool size > >> +LDFLAGS_vmlinux += --defsym _malloc_size=0x10000 > >> # Supply ZRELADDR to the decompressor via a linker symbol. > >> ifneq ($(CONFIG_AUTO_ZRELADDR),y) > >> LDFLAGS_vmlinux += --defsym zreladdr=$(ZRELADDR) > >> diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S > >> index e8e1c866e413..dcc1afa60fb9 100644 > >> --- a/arch/arm/boot/compressed/head.S > >> +++ b/arch/arm/boot/compressed/head.S > >> @@ -309,7 +309,8 @@ restart: adr r0, LC0 > >> #ifndef CONFIG_ZBOOT_ROM > >> /* malloc space is above the relocated stack (64k max) */ > >> add sp, sp, r0 > >> - add r10, sp, #0x10000 > >> + ldr r10, =_malloc_size > >> + add r10, r10, sp > > > > This says "locate _malloc_size in a literal pool somewhere, and load it > > using a PC-relative offset". Are you sure that the literal pool is > > sensibly located? > > > > Would it be better to use a definition for this? > > I've followed ZRELADDR way. I think both values should be handled the > same way (it makes it easier to comprehend IMHO). Is there any reason > not to? Should I change ZRELADDR for v2 too? There's a good reason. ZRELADDR can be a constant that does not fit into the ARMs immediate constants (8 bits of significant data plus a multiple of a 2-bit shift), whereas the size of the malloc space is guaranteed to fit. So, ZRELADDR has to use a literal load. This doesn't. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up