From: Vivek Goyal <vgoyal@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
yangerkun <yangerkun@huawei.com>,
overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH 1/3] overlayfs: Simplify setting of origin for index lookup
Date: Mon, 1 Jun 2020 13:51:29 -0400 [thread overview]
Message-ID: <20200601175129.GD3219@redhat.com> (raw)
In-Reply-To: <CAOQ4uxj-r5kpOTRx9BV+hcS7sk0TGnWR0vGzSpEENLn_ZHeXWg@mail.gmail.com>
On Mon, Jun 01, 2020 at 06:15:44PM +0300, Amir Goldstein wrote:
[..]
> > > But see one improvement below.
> > > Also, please make sure to run unionmount setups:
> > >
> > > ./run --ov=10 --verify
> > > ./run --ov=10 --meta --verify
> > >
> > > --verify will enable index and check st_dev;st_ino are not broken
> > > on copy up. --ov=10 will cause lower hardlink copy up, because
> > > after hardlink is creates by some test, upper is rotated to mid layer
> > > and next modifying operation will trigger the hardlink copy up.
> >
> > Hi Amir,
> >
> > I ran above configurations and it passes with the patches.
> >
> > Thanks for these suggestions. I used to run only "./run --ov" so far.
> > It will be nice to have some documentation about --meta, --verify in README.
> >
>
> Yeh, I never get to it.
> But now I finally posted xfstest integration, so we can just add more
> xfstests to run metacopy configurations on a full test cycle.
Yes, I saw those patches. Very nice. Will be good to run all overlay
tests from single place. Once your patches get merged, I definitely
want to add some more tests to run "--meta" tests.
Vivek
next prev parent reply other threads:[~2020-06-01 17:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 21:29 [PATCH 0/3] overlayfs: Do not check metacopy in ovl_get_inode() Vivek Goyal
2020-05-29 21:29 ` [PATCH 1/3] overlayfs: Simplify setting of origin for index lookup Vivek Goyal
2020-05-30 10:37 ` Amir Goldstein
2020-06-01 14:04 ` Vivek Goyal
2020-06-01 15:15 ` Amir Goldstein
2020-06-01 17:51 ` Vivek Goyal [this message]
2020-05-29 21:29 ` [PATCH 2/3] overlayfs: ovl_lookup(): Use only uppermetacopy state Vivek Goyal
2020-05-30 11:01 ` Amir Goldstein
2020-06-01 15:22 ` Vivek Goyal
2020-05-29 21:29 ` [PATCH 3/3] overlayfs: Initialize OVL_UPPERDATA in ovl_lookup() Vivek Goyal
2020-05-30 11:02 ` Amir Goldstein
2020-05-30 0:59 ` [PATCH 0/3] overlayfs: Do not check metacopy in ovl_get_inode() yangerkun
2020-05-30 3:55 ` yangerkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601175129.GD3219@redhat.com \
--to=vgoyal@redhat.com \
--cc=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.