From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jfxvX-0000Mi-GF for mharc-qemu-trivial@gnu.org; Mon, 01 Jun 2020 23:49:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfxvV-0000KP-9I for qemu-trivial@nongnu.org; Mon, 01 Jun 2020 23:49:21 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:58750 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jfxvT-0005Fa-77 for qemu-trivial@nongnu.org; Mon, 01 Jun 2020 23:49:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591069757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ExLd1Z+1FIxt0ntrrBRLTV4rcrryp6L3gYgD3JMEe7Y=; b=NBW72FDhpLe52v1SNV4xZxz7ETgpbVoM3nIswTun+gGALr12gJT6LUgiw7MJ3cHcfeQm85 KxuhG4vInCiXzLemhm3NFPfU0BKeDgjF/dOwKC4HfQ40lJKltjnhaMQpEFvdnTs3kuGePW d1ZkPilbswuTPfodPk0smjD72ZZFUhk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-17-KUxWMsXLPv6AwOJbETDBNw-1; Mon, 01 Jun 2020 23:49:16 -0400 X-MC-Unique: KUxWMsXLPv6AwOJbETDBNw-1 Received: by mail-wr1-f70.google.com with SMTP id l1so820449wrc.8 for ; Mon, 01 Jun 2020 20:49:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=UPZhIAGyj/VLbIsoUlC2KngQ5PLwTgQRP4hRk68ZAN8=; b=nqNahtkdJRlXo46cxuRtIVionKZgxDoZTHZfu3lWxbHW1PTBLeBnKL8mqVyT+4ER9O 6TpgVDI/LwXIoKhFO8LVFRWYzAWx/YPzQFo6M3Gl3SBhgjqDNxIPeia7RO3PIEpcURVy qL9pTYcZ+yMWt2HLFTdQcdUIYa/xei/mbfk7x1uBHUgq+LmNpBGzPypWiT5r7CUOrzFI CX5yTKSVDc0GXBSdaGk4hxZ6g/dJB5CJR/FcjDT42kdP774w+h1vpdEzd3O+A6ZNP+Al MX+MkV737ldPOy25oUBvKAATqbV+GxkM3Rd1Pc625vE62Bh02BP3lCyZkpq9dwZbsU6x bQjg== X-Gm-Message-State: AOAM531ieh44EE+978MhWp1cuSjecfijNJH81Ug12dk47UFrJ6RLoYQV yLYSzu1O/lwKDQI0dlNVjwrL0siY+q/HgjWiMNjp6jO28S1jxj5Bxlb/SVQ6W2nzPJHfpW3ph0o 5z6ULsRaRhFpKw2FqZg== X-Received: by 2002:a5d:4a43:: with SMTP id v3mr25958783wrs.115.1591069755289; Mon, 01 Jun 2020 20:49:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbFuz2uv/TDCU4M0qN37P/g2y+Wa4iddh/8yNcs/CsBmvsOG4NKyvS+2vtx6Nf23TXqpMcXQ== X-Received: by 2002:a5d:4a43:: with SMTP id v3mr25958746wrs.115.1591069754999; Mon, 01 Jun 2020 20:49:14 -0700 (PDT) Received: from redhat.com (bzq-109-64-41-91.red.bezeqint.net. [109.64.41.91]) by smtp.gmail.com with ESMTPSA id g18sm1578601wme.17.2020.06.01.20.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 20:49:14 -0700 (PDT) Date: Mon, 1 Jun 2020 23:49:11 -0400 From: "Michael S. Tsirkin" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, Anthony Perard , Paolo Bonzini , =?iso-8859-1?Q?Herv=E9?= Poussineau , Helge Deller , qemu-arm@nongnu.org, Marcel Apfelbaum , Stefano Stabellini , Eduardo Habkost , Paul Durrant , Andrew Jeffery , qemu-trivial@nongnu.org, Peter Maydell , Joel Stanley , =?iso-8859-1?Q?C=E9dric?= Le Goater , qemu-ppc@nongnu.org, Richard Henderson Subject: Re: [PATCH v2 0/8] hw: Fix some incomplete memory region size Message-ID: <20200601234822-mutt-send-email-mst@kernel.org> References: <20200601142930.29408-1-f4bug@amsat.org> MIME-Version: 1.0 In-Reply-To: <20200601142930.29408-1-f4bug@amsat.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.120; envelope-from=mst@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/01 23:49:17 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2020 03:49:21 -0000 On Mon, Jun 01, 2020 at 04:29:22PM +0200, Philippe Mathieu-Daudé wrote: > Series fully reviewed. > > Since v1: > - Add parenthesis on the Xen patch (Paul Durrant) > - Add Peter's R-b tags PCI things: Reviewed-by: Michael S. Tsirkin I'll queue pci patches in my tree. > memory_region_set_size() handle the 16 Exabytes limit by > special-casing the UINT64_MAX value. > This is not a problem for the 32-bit maximum, 4 GiB, but > in some places we incorrectly use UINT32_MAX instead of > 4 GiB, and end up missing 1 byte in the memory region. > > This series fixes the cases I encountered. > Also included few patches while reviewing, I replaced some > magic values by the IEC binary prefix equivalent. > > Regards, > > Phil. > > Philippe Mathieu-Daudé (8): > hw/arm/aspeed: Correct DRAM container region size > hw/pci-host/prep: Correct RAVEN bus bridge memory region size > hw/pci/pci_bridge: Correct pci_bridge_io memory region size > hw/pci/pci_bridge: Use the IEC binary prefix definitions > hw/pci-host: Use the IEC binary prefix definitions > hw/hppa/dino: Use the IEC binary prefix definitions > hw/i386/xen/xen-hvm: Use the IEC binary prefix definitions > target/i386/cpu: Use the IEC binary prefix definitions > > hw/arm/aspeed.c | 2 +- > hw/hppa/dino.c | 4 ++-- > hw/i386/xen/xen-hvm.c | 3 ++- > hw/pci-host/i440fx.c | 3 ++- > hw/pci-host/prep.c | 2 +- > hw/pci-host/q35.c | 2 +- > hw/pci-host/versatile.c | 5 +++-- > hw/pci/pci_bridge.c | 7 ++++--- > target/i386/cpu.c | 2 +- > 9 files changed, 17 insertions(+), 13 deletions(-) > > -- > 2.21.3 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:711a:0:0:0:0:0 with SMTP id m26csp3691417lfc; Mon, 1 Jun 2020 20:50:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrAeSK5FJaVzrraWInxCPFyvBeGp9GNJBoaXjapauwPJHGlOhempENr+CnkSBMCfSRU232 X-Received: by 2002:a25:dc0e:: with SMTP id y14mr13771696ybe.198.1591069803305; Mon, 01 Jun 2020 20:50:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591069803; cv=none; d=google.com; s=arc-20160816; b=WYK3dejHTtnc4/59Wud8HToR/N6jwLOJZK/FiMaUTImXqo+UX7nd4WNtez3t47uRHJ tMQ0lzH8iJlY3yWWU+gBRd5i+pbl4yJeFtQxfIpbuHb5wwXuS49DxGbX2vveaWOUMSh7 JeK2xcU022dAWhddqRadyPlp0KlwGFtrXAs4VmVWqC/gzXIrnjI7oGOrML5WGXgvEIby f9QkHLDLuxySxnVNt+YieK7thfMveO9kimNlDSZkdKvV8vY02T/zM3hTiwPuY3B/iz30 Apcr09Nh13WMxUdVszLtPC4pDmh/hH9ORzw7QdtIQptV5MdJefZxF5UhSwzXlq14fdD6 Xcdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-disposition :content-transfer-encoding:in-reply-to:mime-version:references :message-id:subject:to:from:date:dkim-signature; bh=ExLd1Z+1FIxt0ntrrBRLTV4rcrryp6L3gYgD3JMEe7Y=; b=fJvguFOaDdCZ7KErYGlmm7CBzhj20wJpJlklfK54jcvMsaiseeEJh+V/mrgRBWZ1GI fXiG7uzP7TbcORhxjoc2oeV/0Spj4Yj0bTrCFWtv+PW/oLU5guiHv0p0tZvrDzKyHFDC pVHPWYGneprhqmTm2B8Mth03KKQ5CxUGwZX4csej5OVicOUjfRjmUtXjnPSY/8l0S+fc B/HVppjTUXyRA2LEnNqPIhCAhDvbFpb24xZnNWOsADSJ3RZ6bFYfrUfiik0OODShdjz7 HtXBe9jrQdu9hzecRqFI+TJZf0xqEFo/5u11GJ75ly1c/vPD9T0AjzeHqKFk/MMClN7K Jw9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=VIkQo9dN; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n10si1002276ybd.465.2020.06.01.20.50.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Jun 2020 20:50:03 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=VIkQo9dN; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:48192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfxwA-000148-O0 for alex.bennee@linaro.org; Mon, 01 Jun 2020 23:50:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfxvV-0000KY-90 for qemu-devel@nongnu.org; Mon, 01 Jun 2020 23:49:21 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:41719 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jfxvT-0005Ff-Fi for qemu-devel@nongnu.org; Mon, 01 Jun 2020 23:49:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591069758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ExLd1Z+1FIxt0ntrrBRLTV4rcrryp6L3gYgD3JMEe7Y=; b=VIkQo9dNOzPblclGDX9OTxqa+sxRIGC5S6ErfCX9mZboPj4e3nS8pXLWtkyev0tWP3krDk fO1NdcDaPR2DkdAQ+BrkjJQ66vqY4467/A3ttIJfcSVgJIRmttKGsNrYEpzmWIj+2fsjnL SmBuBt+j/c1F5LjrDHqlPIhOT0i10yg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-161-MbdGOPKAM0SG23m6XNS8JA-1; Mon, 01 Jun 2020 23:49:16 -0400 X-MC-Unique: MbdGOPKAM0SG23m6XNS8JA-1 Received: by mail-wr1-f70.google.com with SMTP id h6so831231wrx.4 for ; Mon, 01 Jun 2020 20:49:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=UPZhIAGyj/VLbIsoUlC2KngQ5PLwTgQRP4hRk68ZAN8=; b=ul/+CZ9qW3XQ5MIwEhuA3rtq1WkPZO3/A1PTxfY4+xldWa1QjOq0JPoe/oZErbKrpX JfYKt5D6LRzgExkRraAbSc5YInUEKoPR1VDaXRQah9q9XJw8PYSwHoTchR9zNpg25CrT JqWM6GKsvGvas/NVp/wdn66Xhe1LuCY5meX6vKmICDu9VEG58Mlc681/++uFBbrjN2Bn MGTx+rkScooZ34Xcg5qTVrQEt1NKrkmkxvofX2jmrrP4+o/BdTIjTetwXp3zveY3ZYKw /yDgWPC6Z1r6oX9sp3NrJZJBnVMJleCTkMDo1eezeU2DQuTW718pitUCHzATywCsJIVd 0siw== X-Gm-Message-State: AOAM532o2PW6+EBytr4oCjwoo8zfN5ihY8TS4mvzJYTH5lk9ScPmxeA2 jP98jsMQZxA+HtGPBaN4kLlY8PerC/SOZML86gbDEm0tkFt/+kGmjEMzhdbYEV/89Y5xveCoNTR 3vmBHDXmXRO8SFd0= X-Received: by 2002:a5d:4a43:: with SMTP id v3mr25958781wrs.115.1591069755281; Mon, 01 Jun 2020 20:49:15 -0700 (PDT) X-Received: by 2002:a5d:4a43:: with SMTP id v3mr25958746wrs.115.1591069754999; Mon, 01 Jun 2020 20:49:14 -0700 (PDT) Received: from redhat.com (bzq-109-64-41-91.red.bezeqint.net. [109.64.41.91]) by smtp.gmail.com with ESMTPSA id g18sm1578601wme.17.2020.06.01.20.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 20:49:14 -0700 (PDT) Date: Mon, 1 Jun 2020 23:49:11 -0400 From: "Michael S. Tsirkin" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH v2 0/8] hw: Fix some incomplete memory region size Message-ID: <20200601234822-mutt-send-email-mst@kernel.org> References: <20200601142930.29408-1-f4bug@amsat.org> MIME-Version: 1.0 In-Reply-To: <20200601142930.29408-1-f4bug@amsat.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=mst@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/01 22:14:55 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefano Stabellini , Eduardo Habkost , Paul Durrant , Andrew Jeffery , Helge Deller , qemu-devel@nongnu.org, qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?iso-8859-1?Q?Herv=E9?= Poussineau , Joel Stanley , Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson , qemu-ppc@nongnu.org, =?iso-8859-1?Q?C=E9dric?= Le Goater Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: gMHmPIZkLZHx On Mon, Jun 01, 2020 at 04:29:22PM +0200, Philippe Mathieu-Daudé wrote: > Series fully reviewed. > > Since v1: > - Add parenthesis on the Xen patch (Paul Durrant) > - Add Peter's R-b tags PCI things: Reviewed-by: Michael S. Tsirkin I'll queue pci patches in my tree. > memory_region_set_size() handle the 16 Exabytes limit by > special-casing the UINT64_MAX value. > This is not a problem for the 32-bit maximum, 4 GiB, but > in some places we incorrectly use UINT32_MAX instead of > 4 GiB, and end up missing 1 byte in the memory region. > > This series fixes the cases I encountered. > Also included few patches while reviewing, I replaced some > magic values by the IEC binary prefix equivalent. > > Regards, > > Phil. > > Philippe Mathieu-Daudé (8): > hw/arm/aspeed: Correct DRAM container region size > hw/pci-host/prep: Correct RAVEN bus bridge memory region size > hw/pci/pci_bridge: Correct pci_bridge_io memory region size > hw/pci/pci_bridge: Use the IEC binary prefix definitions > hw/pci-host: Use the IEC binary prefix definitions > hw/hppa/dino: Use the IEC binary prefix definitions > hw/i386/xen/xen-hvm: Use the IEC binary prefix definitions > target/i386/cpu: Use the IEC binary prefix definitions > > hw/arm/aspeed.c | 2 +- > hw/hppa/dino.c | 4 ++-- > hw/i386/xen/xen-hvm.c | 3 ++- > hw/pci-host/i440fx.c | 3 ++- > hw/pci-host/prep.c | 2 +- > hw/pci-host/q35.c | 2 +- > hw/pci-host/versatile.c | 5 +++-- > hw/pci/pci_bridge.c | 7 ++++--- > target/i386/cpu.c | 2 +- > 9 files changed, 17 insertions(+), 13 deletions(-) > > -- > 2.21.3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2FC2C433E0 for ; Tue, 2 Jun 2020 03:50:01 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75B81206C3 for ; Tue, 2 Jun 2020 03:50:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NBW72FDh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75B81206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jfxvW-0007F3-OT; Tue, 02 Jun 2020 03:49:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jfxvU-0007Ey-4X for xen-devel@lists.xenproject.org; Tue, 02 Jun 2020 03:49:20 +0000 X-Inumbo-ID: 08ee76be-a484-11ea-ab8b-12813bfff9fa Received: from us-smtp-1.mimecast.com (unknown [207.211.31.81]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 08ee76be-a484-11ea-ab8b-12813bfff9fa; Tue, 02 Jun 2020 03:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591069757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ExLd1Z+1FIxt0ntrrBRLTV4rcrryp6L3gYgD3JMEe7Y=; b=NBW72FDhpLe52v1SNV4xZxz7ETgpbVoM3nIswTun+gGALr12gJT6LUgiw7MJ3cHcfeQm85 KxuhG4vInCiXzLemhm3NFPfU0BKeDgjF/dOwKC4HfQ40lJKltjnhaMQpEFvdnTs3kuGePW d1ZkPilbswuTPfodPk0smjD72ZZFUhk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-513-v18-1bDFPyKc62xwSlhAWQ-1; Mon, 01 Jun 2020 23:49:16 -0400 X-MC-Unique: v18-1bDFPyKc62xwSlhAWQ-1 Received: by mail-wr1-f70.google.com with SMTP id m14so817680wrj.12 for ; Mon, 01 Jun 2020 20:49:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=UPZhIAGyj/VLbIsoUlC2KngQ5PLwTgQRP4hRk68ZAN8=; b=UpTxBq2qegW9ICRJClvBrPLzUrq7PYtOVMIDkL0C2uVJS3S9eVktkAucUrdEnFI/JB Mu/l0nPxgQUK5rEpE33joWO0OIOAeEo3E1z7QNalbwT/yIwTR1/ylaW9llWvn7T4qABK YV9wOD/epGEALPGwRW6UcJl/u9LSN3+O5GVDuySnyGeN/qQio/8qc2AW0R7bXkQC/Tcq 8zZVDqyuaWiWsaP2Rf0s89k0BZ+VP+6BG2XO/Gk3vGYGw/B6ME9B/KdtEohAZ4J3oPet Uo/rnCifsdeF+BZbL+9UpTVokibf3yTyrVww3Pzcqk85dO7rKwAr2ZXYc6YA+iL2BI3j 72aw== X-Gm-Message-State: AOAM530Q5hpNmzLdecSxS8o6+p342tVlQqAtWLjNYvon8EzUXxnHVqfI qCwlZbvP3bQ91FUSWH+qGW8r9f5Mg88r6/PnrfG3U2ebDpUbD91IvBFowygQ+ExewMJfciSuWBv YtO1FsMWf+rkVcHunJn8i0T5RL8o= X-Received: by 2002:a5d:4a43:: with SMTP id v3mr25958765wrs.115.1591069755171; Mon, 01 Jun 2020 20:49:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbFuz2uv/TDCU4M0qN37P/g2y+Wa4iddh/8yNcs/CsBmvsOG4NKyvS+2vtx6Nf23TXqpMcXQ== X-Received: by 2002:a5d:4a43:: with SMTP id v3mr25958746wrs.115.1591069754999; Mon, 01 Jun 2020 20:49:14 -0700 (PDT) Received: from redhat.com (bzq-109-64-41-91.red.bezeqint.net. [109.64.41.91]) by smtp.gmail.com with ESMTPSA id g18sm1578601wme.17.2020.06.01.20.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 20:49:14 -0700 (PDT) Date: Mon, 1 Jun 2020 23:49:11 -0400 From: "Michael S. Tsirkin" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH v2 0/8] hw: Fix some incomplete memory region size Message-ID: <20200601234822-mutt-send-email-mst@kernel.org> References: <20200601142930.29408-1-f4bug@amsat.org> MIME-Version: 1.0 In-Reply-To: <20200601142930.29408-1-f4bug@amsat.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Content-Disposition: inline X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefano Stabellini , Eduardo Habkost , Paul Durrant , Andrew Jeffery , Helge Deller , qemu-devel@nongnu.org, qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?iso-8859-1?Q?Herv=E9?= Poussineau , Joel Stanley , Marcel Apfelbaum , Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson , qemu-ppc@nongnu.org, =?iso-8859-1?Q?C=E9dric?= Le Goater Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, Jun 01, 2020 at 04:29:22PM +0200, Philippe Mathieu-Daudé wrote: > Series fully reviewed. > > Since v1: > - Add parenthesis on the Xen patch (Paul Durrant) > - Add Peter's R-b tags PCI things: Reviewed-by: Michael S. Tsirkin I'll queue pci patches in my tree. > memory_region_set_size() handle the 16 Exabytes limit by > special-casing the UINT64_MAX value. > This is not a problem for the 32-bit maximum, 4 GiB, but > in some places we incorrectly use UINT32_MAX instead of > 4 GiB, and end up missing 1 byte in the memory region. > > This series fixes the cases I encountered. > Also included few patches while reviewing, I replaced some > magic values by the IEC binary prefix equivalent. > > Regards, > > Phil. > > Philippe Mathieu-Daudé (8): > hw/arm/aspeed: Correct DRAM container region size > hw/pci-host/prep: Correct RAVEN bus bridge memory region size > hw/pci/pci_bridge: Correct pci_bridge_io memory region size > hw/pci/pci_bridge: Use the IEC binary prefix definitions > hw/pci-host: Use the IEC binary prefix definitions > hw/hppa/dino: Use the IEC binary prefix definitions > hw/i386/xen/xen-hvm: Use the IEC binary prefix definitions > target/i386/cpu: Use the IEC binary prefix definitions > > hw/arm/aspeed.c | 2 +- > hw/hppa/dino.c | 4 ++-- > hw/i386/xen/xen-hvm.c | 3 ++- > hw/pci-host/i440fx.c | 3 ++- > hw/pci-host/prep.c | 2 +- > hw/pci-host/q35.c | 2 +- > hw/pci-host/versatile.c | 5 +++-- > hw/pci/pci_bridge.c | 7 ++++--- > target/i386/cpu.c | 2 +- > 9 files changed, 17 insertions(+), 13 deletions(-) > > -- > 2.21.3