Re: [PATCH v2 1/1] iio: accel: bma400: add support for bma400 spi

[Dan Robertson <dan@dlrobertson.com>]

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

On Sun, May 31, 2020 at 10:14:06AM +0100, Jonathan Cameron wrote:
> On Sun, 31 May 2020 10:10:24 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
> 
> > On Sat, 30 May 2020 19:10:10 +0000
> > Dan Robertson <dan@dlrobertson.com> wrote:
> > 
> > > Add basic support for the Bosch Sensortec BMA400 3-axes ultra-low power
> > > accelerometer when configured to use SPI.
> > > 
> > > Signed-off-by: Dan Robertson <dan@dlrobertson.com>  
> > 
> > Hi Dan.
> > 
> > Code looks good, but one suggestion for a possible optimization inline.
> > 
> > I did wonder if it would be possible to use standard spi regmap to
> > do this, but it seems there is only a single pad parameter for both
> > reads and writes so that won't work.
> 
> Changed my mind.  See below.

Yeah I had hoped for the same too.

> Applied to the togreg branch of iio.git and pushed out as testing for
> the autobuilders to play with it.

Thanks!

> Note however that we should add spi stuff to the device tree binding
> docs.  That can happen as a follow up patch. 

Will do.

Cheers,

 - Dan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 902 bytes --]