From: Christoph Hellwig <hch@lst.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Tao pilgrim <pilgrimtao@gmail.com>, Jens Axboe <axboe@kernel.dk>,
hch@lst.de, sth@linux.ibm.com, viro@zeniv.linux.org.uk,
clm@fb.com, jaegeuk@kernel.org, hch@infradead.org,
Mark Fasheh <mark@fasheh.com>,
dhowells@redhat.com, balbi@kernel.org, damien.lemoal@wdc.com,
bvanassche@acm.org, ming.lei@redhat.com,
martin.petersen@oracle.com, satyat@google.com,
chaitanya.kulkarni@wdc.com, houtao1@huawei.com,
asml.silence@gmail.com, ajay.joshi@wdc.com,
linux-kernel@vger.kernel.org,
Muchun Song <songmuchun@bytedance.com>,
hoeppner@linux.ibm.com, heiko.carstens@de.ibm.com,
gor@linux.ibm.com, borntraeger@de.ibm.com,
linux-s390@vger.kernel.org, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-usb@vger.kernel.org,
Josef Bacik <josef@toxicpanda.com>,
dsterba@suse.com, linux-btrfs@vger.kernel.org, chao@kernel.org,
linux-f2fs-devel@lists.sourceforge.net, darrick.wong@oracle.com,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
ocfs2-devel@oss.oracle.com, deepa.kernel@gmail.com
Subject: Re: [PATCH v2] blkdev: Replace blksize_bits() with ilog2()
Date: Tue, 2 Jun 2020 07:51:52 +0200 [thread overview]
Message-ID: <20200602055152.GA11620@lst.de> (raw)
In-Reply-To: <20200601084426.GB1667318@kroah.com>
On Mon, Jun 01, 2020 at 10:44:26AM +0200, Greg KH wrote:
> But does this code path actually show up anywhere that is actually
> measurable as mattering?
>
> If so, please show that benchmark results.
I think the requests are starting to be a bit unreasonable. Tao is
replacing a reimplementation of a standard function with that standard
function / compiler builtin. We don't put such a high burden on that.
And once the proper existing fields are used where possible as shown
in my reply just replacing the rest seems totally obvious - quite
contrary I think keeping a reimplementation would need a high bar.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: hoeppner@linux.ibm.com, heiko.carstens@de.ibm.com,
linux-nvme@lists.infradead.org, dhowells@redhat.com, clm@fb.com,
deepa.kernel@gmail.com, houtao1@huawei.com, hch@lst.de,
linux-s390@vger.kernel.org, Tao pilgrim <pilgrimtao@gmail.com>,
darrick.wong@oracle.com, Mark Fasheh <mark@fasheh.com>,
satyat@google.com, hch@infradead.org, borntraeger@de.ibm.com,
gor@linux.ibm.com, chaitanya.kulkarni@wdc.com,
Josef Bacik <josef@toxicpanda.com>,
ming.lei@redhat.com, dsterba@suse.com, viro@zeniv.linux.org.uk,
Muchun Song <songmuchun@bytedance.com>,
sagi@grimberg.me, jaegeuk@kernel.org, jlbec@evilplan.org,
bvanassche@acm.org, Jens Axboe <axboe@kernel.dk>,
balbi@kernel.org, damien.lemoal@wdc.com,
martin.petersen@oracle.com, joseph.qi@linux.alibaba.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
linux-fsdevel@vger.kernel.org, asml.silence@gmail.com,
linux-btrfs@vger.kernel.org, sth@linux.ibm.com
Subject: Re: [f2fs-dev] [PATCH v2] blkdev: Replace blksize_bits() with ilog2()
Date: Tue, 2 Jun 2020 07:51:52 +0200 [thread overview]
Message-ID: <20200602055152.GA11620@lst.de> (raw)
In-Reply-To: <20200601084426.GB1667318@kroah.com>
On Mon, Jun 01, 2020 at 10:44:26AM +0200, Greg KH wrote:
> But does this code path actually show up anywhere that is actually
> measurable as mattering?
>
> If so, please show that benchmark results.
I think the requests are starting to be a bit unreasonable. Tao is
replacing a reimplementation of a standard function with that standard
function / compiler builtin. We don't put such a high burden on that.
And once the proper existing fields are used where possible as shown
in my reply just replacing the rest seems totally obvious - quite
contrary I think keeping a reimplementation would need a high bar.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: hoeppner@linux.ibm.com, heiko.carstens@de.ibm.com,
linux-nvme@lists.infradead.org, dhowells@redhat.com, clm@fb.com,
deepa.kernel@gmail.com, houtao1@huawei.com, hch@lst.de,
linux-s390@vger.kernel.org, Tao pilgrim <pilgrimtao@gmail.com>,
darrick.wong@oracle.com, Mark Fasheh <mark@fasheh.com>,
satyat@google.com, hch@infradead.org, borntraeger@de.ibm.com,
gor@linux.ibm.com, ajay.joshi@wdc.com,
chaitanya.kulkarni@wdc.com, chao@kernel.org,
Josef Bacik <josef@toxicpanda.com>,
ming.lei@redhat.com, dsterba@suse.com, viro@zeniv.linux.org.uk,
Muchun Song <songmuchun@bytedance.com>,
sagi@grimberg.me, jaegeuk@kernel.org, jlbec@evilplan.org,
bvanassche@acm.org, Jens Axboe <axboe@kernel.dk>,
balbi@kernel.org, damien.lemoal@wdc.com,
martin.petersen@oracle.com, joseph.qi@linux.alibaba.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
linux-fsdevel@vger.kernel.org, asml.silence@gmail.com,
linux-btrfs@vger.kernel.org, sth@linux.ibm.com
Subject: Re: [PATCH v2] blkdev: Replace blksize_bits() with ilog2()
Date: Tue, 2 Jun 2020 07:51:52 +0200 [thread overview]
Message-ID: <20200602055152.GA11620@lst.de> (raw)
In-Reply-To: <20200601084426.GB1667318@kroah.com>
On Mon, Jun 01, 2020 at 10:44:26AM +0200, Greg KH wrote:
> But does this code path actually show up anywhere that is actually
> measurable as mattering?
>
> If so, please show that benchmark results.
I think the requests are starting to be a bit unreasonable. Tao is
replacing a reimplementation of a standard function with that standard
function / compiler builtin. We don't put such a high burden on that.
And once the proper existing fields are used where possible as shown
in my reply just replacing the rest seems totally obvious - quite
contrary I think keeping a reimplementation would need a high bar.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Tao pilgrim <pilgrimtao@gmail.com>, Jens Axboe <axboe@kernel.dk>,
hch@lst.de, sth@linux.ibm.com, viro@zeniv.linux.org.uk,
clm@fb.com, jaegeuk@kernel.org, hch@infradead.org,
Mark Fasheh <mark@fasheh.com>,
dhowells@redhat.com, balbi@kernel.org, damien.lemoal@wdc.com,
bvanassche@acm.org, ming.lei@redhat.com,
martin.petersen@oracle.com, satyat@google.com,
chaitanya.kulkarni@wdc.com, houtao1@huawei.com,
asml.silence@gmail.com, ajay.joshi@wdc.com,
linux-kernel@vger.kernel.org,
Muchun Song <songmuchun@bytedance.com>,
hoeppner@linux.ibm.com, heiko.carstens@de.ibm.com,
gor@linux.ibm.com, borntraeger@de.ibm.com,
linux-s390@vger.kernel.org, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-usb@vger.kernel.org,
Josef Bacik <josef@toxicpanda.com>,
dsterba@suse.com, linux-btrfs@vger.kernel.org, chao@kernel.org,
linux-f2fs-devel@lists.sourceforge.net, darrick.wong@oracle.com,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
ocfs2-devel@oss.oracle.com, deepa.kernel@gmail.com
Subject: [Ocfs2-devel] [PATCH v2] blkdev: Replace blksize_bits() with ilog2()
Date: Tue, 2 Jun 2020 07:51:52 +0200 [thread overview]
Message-ID: <20200602055152.GA11620@lst.de> (raw)
In-Reply-To: <20200601084426.GB1667318@kroah.com>
On Mon, Jun 01, 2020 at 10:44:26AM +0200, Greg KH wrote:
> But does this code path actually show up anywhere that is actually
> measurable as mattering?
>
> If so, please show that benchmark results.
I think the requests are starting to be a bit unreasonable. Tao is
replacing a reimplementation of a standard function with that standard
function / compiler builtin. We don't put such a high burden on that.
And once the proper existing fields are used where possible as shown
in my reply just replacing the rest seems totally obvious - quite
contrary I think keeping a reimplementation would need a high bar.
next prev parent reply other threads:[~2020-06-02 5:52 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 14:11 [PATCH v2] blkdev: Replace blksize_bits() with ilog2() Kaitao Cheng
2020-05-29 14:11 ` [Ocfs2-devel] " Kaitao Cheng
2020-05-29 14:11 ` Kaitao Cheng
2020-05-29 14:11 ` [f2fs-dev] " Kaitao Cheng
2020-05-29 14:13 ` Jens Axboe
2020-05-29 14:13 ` [Ocfs2-devel] " Jens Axboe
2020-05-29 14:13 ` Jens Axboe
2020-05-29 14:13 ` [f2fs-dev] " Jens Axboe
2020-06-01 7:22 ` Tao pilgrim
2020-06-01 7:22 ` [Ocfs2-devel] " Tao pilgrim
2020-06-01 7:22 ` Tao pilgrim
2020-06-01 7:22 ` [f2fs-dev] " Tao pilgrim
2020-06-01 8:44 ` Greg KH
2020-06-01 8:44 ` [Ocfs2-devel] " Greg KH
2020-06-01 8:44 ` Greg KH
2020-06-01 8:44 ` [f2fs-dev] " Greg KH
2020-06-02 5:51 ` Christoph Hellwig [this message]
2020-06-02 5:51 ` [Ocfs2-devel] " Christoph Hellwig
2020-06-02 5:51 ` Christoph Hellwig
2020-06-02 5:51 ` [f2fs-dev] " Christoph Hellwig
2020-06-02 6:13 ` Greg KH
2020-06-02 6:13 ` [Ocfs2-devel] " Greg KH
2020-06-02 6:13 ` Greg KH
2020-06-02 6:13 ` [f2fs-dev] " Greg KH
2020-05-29 14:15 ` Christoph Hellwig
2020-05-29 14:15 ` [Ocfs2-devel] " Christoph Hellwig
2020-05-29 14:15 ` Christoph Hellwig
2020-05-29 14:15 ` [f2fs-dev] " Christoph Hellwig
2020-05-29 20:27 ` Matthew Wilcox
2020-05-29 20:27 ` [Ocfs2-devel] " Matthew Wilcox
2020-05-29 20:27 ` Matthew Wilcox
2020-05-29 20:27 ` [f2fs-dev] " Matthew Wilcox
2020-05-29 22:27 ` Bart Van Assche
2020-05-29 22:27 ` [Ocfs2-devel] " Bart Van Assche
2020-05-29 22:27 ` Bart Van Assche
2020-05-29 22:27 ` [f2fs-dev] " Bart Van Assche
2020-05-29 22:39 ` Jens Axboe
2020-05-29 22:39 ` [Ocfs2-devel] " Jens Axboe
2020-05-29 22:39 ` Jens Axboe
2020-05-29 22:39 ` [f2fs-dev] " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602055152.GA11620@lst.de \
--to=hch@lst.de \
--cc=ajay.joshi@wdc.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=balbi@kernel.org \
--cc=borntraeger@de.ibm.com \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=chao@kernel.org \
--cc=clm@fb.com \
--cc=damien.lemoal@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=deepa.kernel@gmail.com \
--cc=dhowells@redhat.com \
--cc=dsterba@suse.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=houtao1@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=jlbec@evilplan.org \
--cc=josef@toxicpanda.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=pilgrimtao@gmail.com \
--cc=sagi@grimberg.me \
--cc=satyat@google.com \
--cc=songmuchun@bytedance.com \
--cc=sth@linux.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.