From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net,
ast@kernel.org, brouer@redhat.com, toke@redhat.com,
daniel@iogearbox.net, lorenzo.bianconi@redhat.com,
dsahern@kernel.org
Subject: Re: [PATCH bpf-next 4/6] bpf: cpumap: add the possibility to attach an eBPF program to cpumap
Date: Tue, 2 Jun 2020 11:27:34 +0200 [thread overview]
Message-ID: <20200602092734.GA11951@localhost.localdomain> (raw)
In-Reply-To: <20200601223618.ca6bby672wqxgovg@ast-mbp.dhcp.thefacebook.com>
[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]
> On Sun, May 31, 2020 at 11:46:49PM +0200, Lorenzo Bianconi wrote:
> > +
> > + prog = READ_ONCE(rcpu->prog);
> > for (i = 0; i < n; i++) {
> > - void *f = frames[i];
> > + void *f = xdp_frames[i];
> > struct page *page = virt_to_page(f);
> > + struct xdp_frame *xdpf;
> > + struct xdp_buff xdp;
> > + u32 act;
> > + int err;
> >
> > /* Bring struct page memory area to curr CPU. Read by
> > * build_skb_around via page_is_pfmemalloc(), and when
> > * freed written by page_frag_free call.
> > */
> > prefetchw(page);
> > + if (!prog) {
> > + frames[nframes++] = xdp_frames[i];
> > + continue;
> > + }
>
> I'm not sure compiler will be smart enough to hoist !prog check out of the loop.
> Otherwise default cpumap case will be a bit slower.
> I'd like to see performance numbers before/after and acks from folks
> who are using cpumap before applying.
> Also please add selftest for it. samples/bpf/ in patch 6 is not enough.
Hi Alexei,
thx for the review. I will add a selftest and some performance numbers in v2.
Regards,
Lorenzo
>
> Other than the above the feature looks good to me. It nicely complements devmap.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-06-02 9:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 21:46 [PATCH bpf-next 0/6] introduce support for XDP programs in CPUMAP Lorenzo Bianconi
2020-05-31 21:46 ` [PATCH bpf-next 1/6] net: Refactor xdp_convert_buff_to_frame Lorenzo Bianconi
2020-05-31 21:46 ` [PATCH bpf-next 2/6] samples/bpf: xdp_redirect_cpu_user: do not update bpf maps in option loop Lorenzo Bianconi
2020-05-31 21:46 ` [PATCH bpf-next 3/6] cpumap: formalize map value as a named struct Lorenzo Bianconi
2020-05-31 21:46 ` [PATCH bpf-next 4/6] bpf: cpumap: add the possibility to attach an eBPF program to cpumap Lorenzo Bianconi
2020-06-01 22:36 ` Alexei Starovoitov
2020-06-02 9:27 ` Lorenzo Bianconi [this message]
2020-06-02 7:53 ` Jesper Dangaard Brouer
2020-06-02 9:29 ` Lorenzo Bianconi
2020-05-31 21:46 ` [PATCH bpf-next 5/6] bpf: cpumap: implement XDP_REDIRECT for eBPF programs attached to map entries Lorenzo Bianconi
2020-05-31 21:46 ` [PATCH bpf-next 6/6] samples/bpf: xdp_redirect_cpu: load an eBPF program on cpumap Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602092734.GA11951@localhost.localdomain \
--to=lorenzo@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.