From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DE43C433E0 for ; Tue, 2 Jun 2020 12:39:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A8BE206E2 for ; Tue, 2 Jun 2020 12:39:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A8BE206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 129A16E054; Tue, 2 Jun 2020 12:39:07 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4706E6E054 for ; Tue, 2 Jun 2020 12:39:05 +0000 (UTC) IronPort-SDR: xwyxZyUqBskoLc++yVGuXwWojjiw1q0Ia5HnMCXzVDsKjYFC631C/Xmwvs5cyJNhHiT9FkWxJa bDeI707ri5Tw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2020 05:39:04 -0700 IronPort-SDR: Z9sHacOZ9QTw0AsV1gTFkw9Nrt9+lvNyQ6O9Op+uwX0tH76MgM8id8OjJ68nwjV7G8snC+eilC E+aLCHeXU5tg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,464,1583222400"; d="scan'208";a="303995536" Received: from unknown (HELO intel.com) ([10.223.74.178]) by fmsmga002.fm.intel.com with ESMTP; 02 Jun 2020 05:39:02 -0700 Date: Tue, 2 Jun 2020 17:58:07 +0530 From: Anshuman Gupta To: Ville =?utf-8?B?U3lyasOkbMOk?= Message-ID: <20200602122807.GN4452@intel.com> References: <20200601101516.21018-1-anshuman.gupta@intel.com> <20200601141132.GK6112@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200601141132.GK6112@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gMjAyMC0wNi0wMSBhdCAxNzoxMTozMiArMDMwMCwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+ IE9uIE1vbiwgSnVuIDAxLCAyMDIwIGF0IDAzOjQ1OjE2UE0gKzA1MzAsIEFuc2h1bWFuIEd1cHRh IHdyb3RlOgo+ID4gR2VuMTIgaHcgYXJlIGZhaWxpbmcgdG8gZW5hYmxlIGxwc3AgY29uZmlndXJh dGlvbiBkdWUgdG8gUEczIHdhcyBsZWZ0IG9uCj4gPiBkdWUgdG8gdmFsaWQgdXNnYWUgY291bnQg b2YgUE9XRVJfRE9NQUlOX0FVRElPLgo+ID4gSXQgaXMgbm90IHJlcXVpcmVkIHRvIGdldCBQT1dF Ul9ET01BSU5fQVVESU8gcmVmLWNvdW50IHdoZW4gZW5hYmxpbmcKPiA+IGEgY3J0YywgaXQgc2hv dWxkIGJlIGFsd2F5cyBpOTE1X2F1ZGlvX2NvbXBvbmVudCByZXF1ZXN0IHRvIGdldC9wdXQKPiA+ IEFVRElPX1BPV0VSX0RPTUFJTi4KPiA+IAo+ID4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcK PiA+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ ID4gQ2M6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5j b20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBBbnNodW1hbiBHdXB0YSA8YW5zaHVtYW4uZ3VwdGFAaW50 ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9k aXNwbGF5LmMgfCA2ICsrKysrLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyks IDEgZGVsZXRpb24oLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9p bnRlbF9kaXNwbGF5LmMKPiA+IGluZGV4IDZjM2IxMWRlMmRhZi4uZjMxYTU3OWQ3YTUyIDEwMDY0 NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMK PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jCj4g PiBAQCAtNzM1Niw3ICs3MzU2LDExIEBAIHN0YXRpYyB1NjQgZ2V0X2NydGNfcG93ZXJfZG9tYWlu cyhzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiA+ICAJCW1hc2sgfD0gQklU X1VMTChpbnRlbF9lbmNvZGVyLT5wb3dlcl9kb21haW4pOwo+ID4gIAl9Cj4gPiAgCj4gPiAtCWlm IChIQVNfRERJKGRldl9wcml2KSAmJiBjcnRjX3N0YXRlLT5oYXNfYXVkaW8pCj4gPiArCS8qCj4g PiArCSAqIEdlbjEyIGNhbiBkcml2ZSBscHNwIG9uIGhkbWkvZHAgb3V0cHVzLCBpdCBkb2Vzbid0 IHJlcXVpcmUgdG8KPiA+ICsJICogZW5hYmxlIEFVRElPIHBvd2VyIGluIG9yZGVyIHRvIGVuYWJs ZSBhIGNydGMKPiAKPiBOb3RoaW5nIHJlcXVpcmVzIGF1ZGlvIHBvd2VyIHRvIGVuYWJsZSBhIGNy dGMuIFdoYXQgdGhpcyBpcyBzYXlpbmcgaXMKPiB0aGF0IGlmIHdlIHdhbnQgYXVkaW8gdGhlbiB3 ZSBtdXN0IGVuYWJsZSB0aGUgYXVkaW8gcG93ZXIuIElmIHlvdQo+IGRpZG4ndCB3YW50IGF1ZGlv IHRoZW4geW91IHdvdWxkbid0IGhhdmUgLmhhc19hdWRpbyBzZXQuCklNTyBpOTE1X2F1ZGlvX2Nv bXBvbmVudF9nZXRfcG93ZXIgYWxzbyBlbmFibGVzIGF1ZGlvIHBvd2VyLCBhbmQKaTkxNV9hdWRp b19jb21wb25lbnRfcHV0X3Bvd2VyIHJlbGVhc2VzIHRoZSB1c2FnZSBjb3VudCBiYXNlZCB1cG9u IGF1ZGlvCnJ1bnRpbWUgaWRsZW5lc3MgYnV0IGhlcmUgZ2V0X2NydGNfcG93ZXJfZG9tYWlucygp IGdldHMgdGhlIFBPV0VSX0RPTUFJTl9BVURJTyB1c2FnZXMKY291bnQsIHdoaWNoIHdpbGwgYmUg cmVsZWFzZWQgb25seSB3aGVuIHRoaXMgY3J0YyBnZXQgZGlzYmFsZWQuCkl0IG1heSBlbmFibGUg QVVESU8gcG93ZXIgZGVzcGl0ZSBvZiBmYWN0IHRoYXQgYXVkaW8gZHJpdmVyIGhhcyByZWxlYXNl ZCB0aGUKdXNhZ2UgY291bnQuClBsZWFzZSBjb3JyZWN0IG1lIGlmIGkgYW0gd3JvbmcgaGVyZS4K Cj4gCj4gVGhhdCBzYWlkLCBsb29rcyBsaWtlIGF1ZGlvIGlzIG1vdmluZyBpbnRvIHRoZSBhbHdh eXMgb24gd2VsbCwgYnV0IG5vdAo+IHlldCBpbiB0Z2wuClN0aWxsIHNvbWUgb2YgYXVkaW8gZnVu Y3Rpb25hbCBzdHVmZiBsaWVzIGluIFBHMywgbm90IGNvbXBsZXRlbHkgcmVtb3ZlZApmcm9tIFBH My4KVGhhbmtzLApBbnNodW1hbiBHdXB0YS4KPiAKPiAuCj4gPiArCSAqLwo+ID4gKwlpZiAoSU5U RUxfR0VOKGRldl9wcml2KSA8IDEyICYmIEhBU19EREkoZGV2X3ByaXYpICYmIGNydGNfc3RhdGUt Pmhhc19hdWRpbykKPiA+ICAJCW1hc2sgfD0gQklUX1VMTChQT1dFUl9ET01BSU5fQVVESU8pOwo+ ID4gIAo+ID4gIAlpZiAoY3J0Y19zdGF0ZS0+c2hhcmVkX2RwbGwpCj4gPiAtLSAKPiA+IDIuMjYu Mgo+IAo+IC0tIAo+IFZpbGxlIFN5cmrDpGzDpAo+IEludGVsCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A12C433DF for ; Tue, 2 Jun 2020 12:39:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D53020678 for ; Tue, 2 Jun 2020 12:39:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726130AbgFBMjF (ORCPT ); Tue, 2 Jun 2020 08:39:05 -0400 Received: from mga17.intel.com ([192.55.52.151]:16533 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726007AbgFBMjE (ORCPT ); Tue, 2 Jun 2020 08:39:04 -0400 IronPort-SDR: pNF6xHoxiLNHJbDEZRNxmM/vwWDf/ZLU4PCAMmu69KbK8acAk7Qacen4QziThTKAfUkVMSCPtC t4zaaZ2qvNnw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2020 05:39:04 -0700 IronPort-SDR: Z9sHacOZ9QTw0AsV1gTFkw9Nrt9+lvNyQ6O9Op+uwX0tH76MgM8id8OjJ68nwjV7G8snC+eilC E+aLCHeXU5tg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,464,1583222400"; d="scan'208";a="303995536" Received: from unknown (HELO intel.com) ([10.223.74.178]) by fmsmga002.fm.intel.com with ESMTP; 02 Jun 2020 05:39:02 -0700 Date: Tue, 2 Jun 2020 17:58:07 +0530 From: Anshuman Gupta To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Maarten Lankhorst Subject: Re: [RFC] drm/i915: lpsp with hdmi/dp outputs Message-ID: <20200602122807.GN4452@intel.com> References: <20200601101516.21018-1-anshuman.gupta@intel.com> <20200601141132.GK6112@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200601141132.GK6112@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 2020-06-01 at 17:11:32 +0300, Ville Syrjälä wrote: > On Mon, Jun 01, 2020 at 03:45:16PM +0530, Anshuman Gupta wrote: > > Gen12 hw are failing to enable lpsp configuration due to PG3 was left on > > due to valid usgae count of POWER_DOMAIN_AUDIO. > > It is not required to get POWER_DOMAIN_AUDIO ref-count when enabling > > a crtc, it should be always i915_audio_component request to get/put > > AUDIO_POWER_DOMAIN. > > > > Cc: stable@vger.kernel.org > > Cc: Ville Syrjälä > > Cc: Maarten Lankhorst > > Signed-off-by: Anshuman Gupta > > --- > > drivers/gpu/drm/i915/display/intel_display.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > > index 6c3b11de2daf..f31a579d7a52 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > @@ -7356,7 +7356,11 @@ static u64 get_crtc_power_domains(struct intel_crtc_state *crtc_state) > > mask |= BIT_ULL(intel_encoder->power_domain); > > } > > > > - if (HAS_DDI(dev_priv) && crtc_state->has_audio) > > + /* > > + * Gen12 can drive lpsp on hdmi/dp outpus, it doesn't require to > > + * enable AUDIO power in order to enable a crtc > > Nothing requires audio power to enable a crtc. What this is saying is > that if we want audio then we must enable the audio power. If you > didn't want audio then you wouldn't have .has_audio set. IMO i915_audio_component_get_power also enables audio power, and i915_audio_component_put_power releases the usage count based upon audio runtime idleness but here get_crtc_power_domains() gets the POWER_DOMAIN_AUDIO usages count, which will be released only when this crtc get disbaled. It may enable AUDIO power despite of fact that audio driver has released the usage count. Please correct me if i am wrong here. > > That said, looks like audio is moving into the always on well, but not > yet in tgl. Still some of audio functional stuff lies in PG3, not completely removed from PG3. Thanks, Anshuman Gupta. > > . > > + */ > > + if (INTEL_GEN(dev_priv) < 12 && HAS_DDI(dev_priv) && crtc_state->has_audio) > > mask |= BIT_ULL(POWER_DOMAIN_AUDIO); > > > > if (crtc_state->shared_dpll) > > -- > > 2.26.2 > > -- > Ville Syrjälä > Intel