From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07BAEC433E0 for ; Tue, 2 Jun 2020 12:56:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D228720663 for ; Tue, 2 Jun 2020 12:55:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591102559; bh=pMI6eRLslYCASoIsWsxp6VlaySudpGXDUM673vBl8gU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fYbp0WdAYQxcztnf2a7jswjc4dJinnIKi7uMFLDFDSBymUvAvAbhHv+QEt+Zu910u XANk46F+fbOwGs8DTtmPvbBcRDK4Kyf8klFnvlETaChtoBCDTRep/3Sk7tGVYZwO1x MM74L8TqPol1jNdVw97uC7qX31RKhR/zou2z6s3c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725940AbgFBMz7 (ORCPT ); Tue, 2 Jun 2020 08:55:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:50364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726371AbgFBMz6 (ORCPT ); Tue, 2 Jun 2020 08:55:58 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CC154206A4; Tue, 2 Jun 2020 12:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591102558; bh=pMI6eRLslYCASoIsWsxp6VlaySudpGXDUM673vBl8gU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tSb1kyaaQmlz+6GDbyIQeerhIxnmHkaw8ZWjOdjxj1eqM4FdJP5Wi+O1I6NOgkyhu Jgy1sX42ZoAxQjk9qDw4F2D0GPEotl8QydeVuBPsdR2ZxvjnyagLLyt/qe37RBPrds FnN1OBZ+PTYa7jYyxu+IAC2CAVsu1lnfXJk5dv04= From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Leon Romanovsky , linux-rdma@vger.kernel.org, Mark Zhang Subject: [PATCH rdma-next 1/3] RDMA/mlx5: Return an error if copy_to_user fails Date: Tue, 2 Jun 2020 15:55:46 +0300 Message-Id: <20200602125548.172654-2-leon@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200602125548.172654-1-leon@kernel.org> References: <20200602125548.172654-1-leon@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Leon Romanovsky In theoretical event, the ib_copy_to_udata() can fail, so return -EFAULT error to the user, so he will destroy the QP. Fixes: 50aec2c3135e ("RDMA/mlx5: Return ECE data after modify QP") Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/qp.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index bc776542efd3..e8427231cf15 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -4305,12 +4305,8 @@ int mlx5_ib_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, /* resp.response_length is set in ECE supported flows only */ if (!err && resp.response_length && udata->outlen >= resp.response_length) - /* - * We don't check return value of the function below - * on purpose, because it is unclear how to unwind the - * error flow after QP was modified to the new state. - */ - ib_copy_to_udata(udata, &resp, resp.response_length); + /* Return -EFAULT to the user and expect him to destroy QP. */ + err = ib_copy_to_udata(udata, &resp, resp.response_length); out: mutex_unlock(&qp->mutex); -- 2.26.2