From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 743D7C433DF for ; Tue, 2 Jun 2020 22:43:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11EC7205CB for ; Tue, 2 Jun 2020 22:43:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="L0tGdsNh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11EC7205CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F5F889C1B; Tue, 2 Jun 2020 22:43:06 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 932BD89C1B for ; Tue, 2 Jun 2020 22:43:05 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A38052A4; Wed, 3 Jun 2020 00:43:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1591137783; bh=5bzngJE3PovcLPH25pHOBugEzQ/pVC9pCN0P2WYHsyQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L0tGdsNhzZ5Se6JRLO9Q7N6vkvtnTmMAFe/Bgpz10F/m3ijD+KDZf/S+OaX2+7hXi DEqqZ0wLZXonNeYeqokqrb3c73hhUT75dsRYrxZsv/gSPlzVa6TnSQBgYZKCinGPW+ kfQHh57ZVt0ABYqKBhoQfWVlvJsrmcPmf93JpF34= Date: Wed, 3 Jun 2020 01:42:48 +0300 From: Laurent Pinchart To: Emil Velikov Subject: Re: [PATCH v2 22/22] drm: mxsfb: Support the alpha plane Message-ID: <20200602224248.GN6547@pendragon.ideasonboard.com> References: <20200530031015.15492-1-laurent.pinchart@ideasonboard.com> <20200530031015.15492-23-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , ML dri-devel , NXP Linux Team , Sascha Hauer , Robert Chiras , leonard.crestez@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Emil, On Sun, May 31, 2020 at 05:54:04PM +0100, Emil Velikov wrote: > HI Laurent, > > From a quick glance the series looks really good and neat. Thank you :-) > Then again, I don't know much about the hardware to provide meaningful > review. > > A couple of small ideas below. > > On Sat, 30 May 2020 at 04:11, Laurent Pinchart wrote: > > > +#define LCDC_AS_BUF 0x220 > > +#define LCDC_AS_NEXT_BUF 0x230 > > s/LCDC_AS_BUF/LCDC_AS_CUR_BUF/ - to stay consistent with the primary > plane name scheme. The register names come directly from the datasheet (and yes, the datasheet uses CUR_BUF and NEXT_BUF for the primary plane, and BUF and NEXT_BUF for the overlay plane :-S). I'd thus rather keep them aligned with the documentation. > Would it make sense to store the above registers in mxsfb_devdata, > just like we do for the primary planes? The reason the register addresses are stored in mxsfb_devdata for the primary plane is because they differ between hardware revisions (don't they teach hardware engineers in school these days *not* to move registers around ? :-)). The overlay plane is only supported in the latest versions of the IP core, and are always located at the same address as far as I can tell. I don't think we need an extra level of indirection. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel