Re: [PATCH] checkpatch: reversed logic with acpi test checks

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, Jun 04, 2020 at 08:45:15PM +0200, Paolo Bonzini wrote:
> On 02/06/20 07:36, Michael S. Tsirkin wrote:
> > Logic reversed: allowed list should just be ignored. Instead we
> > only take that into account :(
> > 
> > Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list")
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  scripts/checkpatch.pl | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 0ba213e9f2..55aa45dc16 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -1267,7 +1267,7 @@ sub checkfilename {
> >          # files and when changing tests.
> >  	if ($name =~ m#^tests/data/acpi/# and not $name =~ m#^\.sh$#) {
> >  		$$acpi_testexpected = $name;
> > -	} elsif ($name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
> > +	} elsif (not $name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
> >  		$$acpi_nontestexpected = $name;
> >  	}
> >  	if (defined $$acpi_testexpected and defined $$acpi_nontestexpected) {
> > 
> 
> Queued with "!~" to achieve the logical not.
> 
> Paolo

Hmm perl manual says "not" is the logical not. Weird.
What's !~? My perl is a bit rusty :)