From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C938C433E0 for ; Thu, 4 Jun 2020 15:25:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 069432072E for ; Thu, 4 Jun 2020 15:25:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 069432072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9EA1F6E436; Thu, 4 Jun 2020 15:25:54 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4B7CC6E436 for ; Thu, 4 Jun 2020 15:25:53 +0000 (UTC) IronPort-SDR: Da4NwmKIEHATbKDXJphw4qhd7BGzYiT0QCPRTITSkwwHgsLxbkbCIRg7tRf49zJgvQBaAEg40K L4KEBDpd/2KA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2020 08:25:46 -0700 IronPort-SDR: uBNlxwU/e0jYzh+MHU/Hh/GP6+mQHuPVqrkXUjdIi0DWw4RoCWGbas9bn+Lc8bNNdoFiJ+ZRIS ipB2AO1QEF9g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,472,1583222400"; d="scan'208";a="257758802" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga007.fm.intel.com with SMTP; 04 Jun 2020 08:25:44 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 04 Jun 2020 18:25:43 +0300 Date: Thu, 4 Jun 2020 18:25:43 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Manasi Navare Message-ID: <20200604152543.GU6112@intel.com> References: <20200604002359.17128-1-manasi.d.navare@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200604002359.17128-1-manasi.d.navare@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH] drm/i915/dp: Reset link params on connector disconnect X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Jun 03, 2020 at 05:23:59PM -0700, Manasi Navare wrote: > We have noticed that when link training fails the panel > sends a long pulse indicating connector disconnect. In this case > we need to reset the link parameters instead of continuing > to use the fallback parameters since else this long pulse > by the panel followed by a modeset request which was triggered by the use= rspace > before getting the connector status as disconnected, will > result into a modeset now using lower link rate/lane count values. > = > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1385 > Cc: Jani Nikula > Cc: Ville Syrj=E4l=E4 > Signed-off-by: Manasi Navare > --- > drivers/gpu/drm/i915/display/intel_dp.c | 28 +++++++++++++++++-------- > 1 file changed, 19 insertions(+), 9 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i9= 15/display/intel_dp.c > index 55fda074c0ad..f7af372647dd 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -6111,6 +6111,18 @@ intel_dp_unset_edid(struct intel_dp *intel_dp) > intel_dp->edid_quirks =3D 0; > } > = > +static void > +intel_dp_reset_link_params(struct intel_dp *intel_dp) > +{ > + /* Initial max link lane count */ > + intel_dp->max_link_lane_count =3D intel_dp_max_common_lane_count(intel_= dp); > + > + /* Initial max link rate */ > + intel_dp->max_link_rate =3D intel_dp_max_common_rate(intel_dp); > + > + intel_dp->reset_link_params =3D false; > +} > + > static int > intel_dp_detect(struct drm_connector *connector, > struct drm_modeset_acquire_ctx *ctx, > @@ -6139,6 +6151,11 @@ intel_dp_detect(struct drm_connector *connector, > memset(&intel_dp->compliance, 0, sizeof(intel_dp->compliance)); > memset(intel_dp->dsc_dpcd, 0, sizeof(intel_dp->dsc_dpcd)); > = > + /*Reset the immutable VRR Capable property */ > + drm_connector_set_vrr_capable_property(connector, > + false); > + intel_dp_reset_link_params(intel_dp); > + Why would we care what those are when the sink is disconnected? > if (intel_dp->is_mst) { > drm_dbg_kms(&dev_priv->drm, > "MST device may have disappeared %d vs %d\n", > @@ -6152,15 +6169,8 @@ intel_dp_detect(struct drm_connector *connector, > goto out; > } > = > - if (intel_dp->reset_link_params) { > - /* Initial max link lane count */ > - intel_dp->max_link_lane_count =3D intel_dp_max_common_lane_count(intel= _dp); > - > - /* Initial max link rate */ > - intel_dp->max_link_rate =3D intel_dp_max_common_rate(intel_dp); > - > - intel_dp->reset_link_params =3D false; > - } > + if (intel_dp->reset_link_params) > + intel_dp_reset_link_params(intel_dp); > = > intel_dp_print_rates(intel_dp); > = > -- = > 2.19.1 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx