All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Rosbrook <rosbrookn@gmail.com>
To: George Dunlap <George.Dunlap@citrix.com>
Cc: Nick Rosbrook <rosbrookn@ainfosec.com>,
	xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
	Ian Jackson <Ian.Jackson@citrix.com>
Subject: [PATCH v2 1/5] libxl: Generate golang bindings in libxl Makefile
Date: Thu, 4 Jun 2020 14:29:38 -0400	[thread overview]
Message-ID: <20200604182938.GA10975@six> (raw)
In-Reply-To: <5CF4AE1D-C80C-4E4C-B4AA-0779E7DC53E7@citrix.com>

> The simplest short-term way to fix this would be to remove the `go fmt` call from `gengotypes.py`.  It’s actually relatively unusual for generated code to look pretty (or even be looked at).  We could also consider adding in some “manual” formatting in gengotypes.py, like indentation, so that it doesn’t look too terrible.
> 
> Nick, do you have time to work on a patch like that?

Yes, I have time to work on a quick patch for this. I'll see what it
would take to add a bit of basic manual formatting, but of course the
original purpose of using gofmt was to avoid re-creating formatting
logic. I'll likely just remove the call to go fmt.

Out of curiosity, would it be totally out of the question to require
having gofmt installed (not for 4.14, but in the future)? I ask because
I haven't seen it discussed one way or the other.

Thanks,
-NR


  reply	other threads:[~2020-06-04 18:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26 22:16 [PATCH v2 0/5] Golang build fixes / improvements George Dunlap
2020-05-26 22:16 ` [PATCH v2 1/5] libxl: Generate golang bindings in libxl Makefile George Dunlap
2020-06-04 16:40   ` George Dunlap
2020-06-04 18:29     ` Nick Rosbrook [this message]
2020-06-08  9:54       ` George Dunlap
2020-06-08 14:10         ` Nick Rosbrook
2020-06-08 11:16     ` Ian Jackson
2020-06-08 11:48       ` George Dunlap
2020-05-26 22:16 ` [PATCH v2 2/5] golang/xenlight: Get rid of GOPATH-based build artefacts George Dunlap
2020-05-26 23:57   ` Nick Rosbrook
2020-05-27  0:03   ` Nick Rosbrook
2020-05-26 22:16 ` [PATCH v2 3/5] automation/archlinux: Add 32-bit glibc headers George Dunlap
2020-05-27 10:43   ` Anthony PERARD
2020-05-27 11:29     ` Wei Liu
2020-05-28 11:32       ` George Dunlap
2020-05-29 16:37         ` Anthony PERARD
2020-05-26 22:16 ` [PATCH v2 4/5] automation: Add golang packages to various dockerfiles George Dunlap
2020-05-26 22:16 ` [PATCH v2 5/5] automation/containerize: Add a shortcut for Debian unstable George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200604182938.GA10975@six \
    --to=rosbrookn@gmail.com \
    --cc=George.Dunlap@citrix.com \
    --cc=Ian.Jackson@citrix.com \
    --cc=rosbrookn@ainfosec.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.